aboutsummaryrefslogtreecommitdiffstats
path: root/actionview/CHANGELOG.md
diff options
context:
space:
mode:
authorVipul A M <vipulnsward@gmail.com>2016-05-09 02:36:58 +0530
committerVipul A M <vipulnsward@gmail.com>2016-05-21 15:43:35 +0800
commit9bfd968bed1a76888ec82e0f7b524a989d0e1108 (patch)
tree67b396ef0b92385bd5996fb0617abab989f166e9 /actionview/CHANGELOG.md
parent694cbbf801e46d7ec533ece4637412838f02723e (diff)
downloadrails-9bfd968bed1a76888ec82e0f7b524a989d0e1108.tar.gz
rails-9bfd968bed1a76888ec82e0f7b524a989d0e1108.tar.bz2
rails-9bfd968bed1a76888ec82e0f7b524a989d0e1108.zip
Confirm with the specification when generating emtpy option for select with `include_blank: true` option.
We now generate option with empty label, example: `<select id="places" name="places"><option value="" label=" "></option></select>` for include_blank: true. This is only done, if content is missing on the option, and we providing the value from this option. Fixes #24816
Diffstat (limited to 'actionview/CHANGELOG.md')
-rw-r--r--actionview/CHANGELOG.md17
1 files changed, 17 insertions, 0 deletions
diff --git a/actionview/CHANGELOG.md b/actionview/CHANGELOG.md
index 1d7ec77e70..0b40699c77 100644
--- a/actionview/CHANGELOG.md
+++ b/actionview/CHANGELOG.md
@@ -1,2 +1,19 @@
+* `select_tag`'s `include_blank` option for generation for blank option tag, now adds an empty space label,
+ when the value as well as content for option tag are empty, so that we confirm with html specification.
+ Ref: https://www.w3.org/TR/html5/forms.html#the-option-element.
+
+ Generation of option before:
+
+ ```html
+ <option value=""></option>
+ ```
+
+ Generation of option after:
+
+ ```html
+ <option value="" label=" "></option>
+ ```
+
+ *Vipul A M *
Please check [5-0-stable](https://github.com/rails/rails/blob/5-0-stable/actionview/CHANGELOG.md) for previous changes.