Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Needless requires | Akira Matsuda | 2013-01-06 | 2 | -6/+0 | |
| | | ||||||
* | | Missing requires | Akira Matsuda | 2013-01-06 | 2 | -0/+2 | |
| | | ||||||
* | | These are already required through AS/rails | Akira Matsuda | 2013-01-06 | 5 | -6/+0 | |
| | | | | | | | | | | | | | | * core_ext/object/blank * concern * core_ext/class/attribute * deprecation | |||||
* | | Rename route_wrapper partial layout to table | Carlos Antonio da Silva | 2013-01-06 | 2 | -1/+1 | |
| | | | | | | | | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler. | |||||
* | | Move table routes formatter class to the inspector and rename it | Carlos Antonio da Silva | 2013-01-06 | 3 | -19/+19 | |
| | | | | | | | | | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page. | |||||
* | | Merge pull request #8777 from goshakkk/delegate-class | Andrew White | 2013-01-06 | 2 | -2/+2 | |
|\ \ | | | | | | | Delegate to :class rather than 'self.class' | |||||
| * | | delegate to :class rather than 'self.class' | Gosha Arinich | 2013-01-06 | 2 | -2/+2 | |
| | | | ||||||
* | | | Refactor the logic that checks whether or not to emit the hidden id field | Carlos Antonio da Silva | 2013-01-06 | 1 | -7/+6 | |
| | | | | | | | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects. | |||||
* | | | Move the hidden :id field logic to where it belongs to | Carlos Antonio da Silva | 2013-01-06 | 1 | -6/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense. | |||||
* | | | Eliminate the usage of parent_builder option from form_for | Carlos Antonio da Silva | 2013-01-06 | 1 | -19/+15 | |
| | | | | | | | | | | | | Just use it internally from fields_for until we come up with a better solution. | |||||
* | | | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 2 | -6/+18 | |
| | | | ||||||
* | | | Refactor to not call path.ast twice | Carlos Antonio da Silva | 2013-01-06 | 1 | -2/+3 | |
| | | | ||||||
* | | | refactor Route#ast to use or-equals and block, instead of return with a cond | Gosha Arinich | 2013-01-06 | 1 | -5/+4 | |
| | | | ||||||
* | | | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 6 | -38/+26 | |
|/ / | ||||||
* | | Fix documentation to content_tag_for [ci skip] | Rafael Mendonça França | 2013-01-05 | 1 | -2/+2 | |
| | | ||||||
* | | Merge pull request #8766 from jcoglan/session_token_docs | Andrew White | 2013-01-05 | 1 | -7/+4 | |
|\ \ | | | | | | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip] | |||||
| * | | Remove suggestion that Procs can be used as session secrets. | James Coglan | 2013-01-05 | 1 | -7/+4 | |
| | | | ||||||
* | | | deprecate `assert_blank` and `assert_present`. | Yves Senn | 2013-01-05 | 6 | -16/+16 | |
| | | | | | | | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?` | |||||
* | | | Remove warning, remove not used variable, and make methods private | Carlos Antonio da Silva | 2013-01-05 | 1 | -3/+5 | |
|/ / | | | | | | | Warning: "shadowing outer local variable - routes". | |||||
* | | Close container div tag in routing error page | Carlos Antonio da Silva | 2013-01-05 | 1 | -9/+11 | |
| | | ||||||
* | | Move style to head to make routes page valid html5 | Carlos Antonio da Silva | 2013-01-05 | 2 | -4/+6 | |
| | | ||||||
* | | Action Pack changelog improvements [ci skip] | Carlos Antonio da Silva | 2013-01-05 | 1 | -32/+35 | |
| | | ||||||
* | | display mountable engine routes on RoutingError. | Yves Senn | 2013-01-05 | 4 | -11/+46 | |
| | | ||||||
* | | split formatting concerns from RoutesInspector | Yves Senn | 2013-01-05 | 2 | -24/+63 | |
| | | ||||||
* | | Rename the last occurrence of UnexpectedParameters | Rafael Mendonça França | 2013-01-05 | 1 | -2/+2 | |
| | | ||||||
* | | Wrong copy and paste :bomb: | Rafael Mendonça França | 2013-01-05 | 1 | -1/+1 | |
| | | | | | | | | [ci skip] | |||||
* | | Add documentation to raise_on_unpermitted_parameters option | Rafael Mendonça França | 2013-01-05 | 1 | -2/+17 | |
| | | | | | | | | [ci skip] | |||||
* | | Rename the configuration to raise_on_unpermitted_parameters | Rafael Mendonça França | 2013-01-05 | 3 | -15/+17 | |
| | | | | | | | | Also changed the exception to UnpermittedParameters | |||||
* | | Ensure that raise_on_unexpected_params configuration will work | Rafael Mendonça França | 2013-01-05 | 1 | -9/+7 | |
| | | ||||||
* | | Merge pull request #8752 from thomasfedb/master | Rafael Mendonça França | 2013-01-05 | 3 | -6/+64 | |
|\ \ | | | | | | | Exception on unexpected params when enabled. | |||||
| * | | Allow developers to enable raising of exception when unexpected params are ↵ | Thomas Drake-Brockman | 2013-01-05 | 3 | -6/+64 | |
| | | | | | | | | | | | | provided. | |||||
* | | | Allow use of durations for ActionDispatch::SSL configuration | Andrew White | 2013-01-04 | 2 | -1/+8 | |
| | | | ||||||
* | | | Remove unnecessary `ERB::Util::h` | Ryunosuke SATO | 2013-01-05 | 7 | -17/+17 | |
| | | | | | | | | | | | | It is automatically applied when strings is unsafe for html. | |||||
* | | | Suppress warning about IO#lines in Ruby 2.0 | Ryunosuke SATO | 2013-01-04 | 1 | -1/+1 | |
|/ / | | | | | | | actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead | |||||
* | | Merge pull request #8723 from goshakkk/refactor-error-page | Guillermo Iguaran | 2013-01-03 | 3 | -5/+27 | |
|\ \ | | | | | | | Move error page js into script tag | |||||
| * | | move error page js into script tag | Gosha Arinich | 2013-01-04 | 3 | -5/+27 | |
| | | | ||||||
* | | | Add documentation to ActionDispatch::Http::UploadedFile#headers | Rafael Mendonça França | 2013-01-03 | 1 | -0/+1 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | Remove a useless TODO comment | Robin Dupret | 2013-01-03 | 1 | -1/+0 | |
| | | | ||||||
* | | | Merge pull request #8705 from amparo-luna/change_update_attributes_to_update | Guillermo Iguaran | 2013-01-03 | 4 | -8/+8 | |
|\ \ \ | | | | | | | | | Rename update_attributes method to update | |||||
| * | | | Change docs to use update instead of update_attributes | Amparo Luna + Guillermo Iguaran | 2013-01-03 | 4 | -8/+8 | |
| | | | | ||||||
* | | | | Typo and grammar fixes in the ActionPack CHANGELOG | Matt Bridges | 2013-01-03 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #8713 from goshakkk/better-error-page | Guillermo Iguaran | 2013-01-03 | 2 | -12/+10 | |
|\ \ \ | | | | | | | | | Fix env toggling, improve error page styling | |||||
| * | | | fix env toggling, improve error page styling | Gosha Arinich | 2013-01-03 | 2 | -12/+10 | |
| | | | | ||||||
* | | | | Fix typo on form_tag_helper.rb | Paulo Luis Franchini Casaretto | 2013-01-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | The inline documentantion had a typo that was somewhat confusing. | |||||
* | | | | Merge pull request #8715 from goshakkk/refactor-mapper | Carlos Antonio da Silva | 2013-01-03 | 1 | -9/+4 | |
|\ \ \ \ | | | | | | | | | | | Refactor Routing::Mapper#matches? | |||||
| * | | | | refactor Routing::Mapper | Gosha Arinich | 2013-01-03 | 1 | -9/+4 | |
| |/ / / | ||||||
* | | | | Explain the possible precautions | Andre Arko | 2013-01-02 | 1 | -3/+4 | |
| | | | | ||||||
* | | | | Restore original remote_ip algorithm. | Andre Arko | 2013-01-02 | 3 | -111/+164 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Proxy servers add X-Forwarded-For headers, resulting in a list of IPs. We remove trusted IP values, and then take the last given value, assuming that it is the most likely to be the correct, unfaked value. See [1] for a very thorough discussion of why that is the best option we have at the moment. [1]: http://blog.gingerlime.com/2012/rails-ip-spoofing-vulnerabilities-and-protection/ Fixes #7979 | |||||
* | | | | Changelog improvements [ci skip] | Carlos Antonio da Silva | 2013-01-02 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Merge pull request #8697 from goshakkk/undup | Rafael Mendonça França | 2013-01-02 | 1 | -5/+3 | |
|\ \ \ | | | | | | | | | Remove another unnecessary dup |