aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* stop passing the options hash to `_process_format`Aaron Patterson2015-08-262-4/+4
| | | | | | We don't need to pass the full hash just to pull one value out. It's better to just pass the value that the method needs to know about so that we can abstract it away from "options"
* remove RackDelegation moduleAaron Patterson2015-08-2613-71/+16
| | | | | | Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
* remove useless methodAaron Patterson2015-08-261-5/+0
| | | | | the subclass sets the body on the response object, so we don't need the superclass doing it too
* include ActionView::Rendering in the minimal controllerAaron Patterson2015-08-262-1/+2
| | | | without this module, the content type is not set correctly
* Merge pull request #21387 from ronakjangir47/remove_dup_minitestKasper Timm Hansen2015-08-261-1/+0
|\ | | | | Removed duplicate require 'minitest/mock'
| * Removed duplicate requiring minitest/mock as it is already required in ↵Ronak Jangir2015-08-261-1/+0
| | | | | | | | method_call_assertions
* | `headers` should delegate to the response objectAaron Patterson2015-08-261-1/+2
| |
* | remove useless status setAaron Patterson2015-08-261-2/+0
| | | | | | | | | | | | Now that `Controller#status=` just delegates to the response object, we don't need to set the response on the controller and the response. We can just set it in one place.
* | remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | | | | we always have a response object, so there is no reason to test it
* | remove ivars from the "protected" listAaron Patterson2015-08-261-1/+1
| | | | | | | | these ivars don't exist anymore, so we can remove them from the list
* | use the content_type method on the request objectAaron Patterson2015-08-261-1/+1
| | | | | | | | | | since the controller always has a request on it, we can just ask the request for the content type.
* | ask the response for the statusAaron Patterson2015-08-261-3/+2
| | | | | | | | | | | | The controller instance always has an instance of a response object. We should store the status code on the response object so that it's only store in one place.
* | remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | | | | | | We always have a response object in controller instances, so we can remove this conditional
* | remove useless conditionalAaron Patterson2015-08-261-1/+1
|/ | | | | controller instances always have a response object, so we don't need to test to see if there is one, just always call to_a on the response.
* provide a request and response to all controllersAaron Patterson2015-08-2510-39/+49
| | | | | | | | | | Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
* :snip: whitespaceAaron Patterson2015-08-251-2/+2
|
* Fix another rack SPEC violationAaron Patterson2015-08-251-1/+1
|
* rack SPEC doesn't allow `first` on the bodyAaron Patterson2015-08-251-8/+12
| | | | collect the body and make assert against the collected body
* move response allocation to the class levelAaron Patterson2015-08-252-8/+22
| | | | | | we don't need an instance to figure out what type of response to allocate. Later we'll pull this up the stack and pass the response object down
* adding a direct dispatch method to controller classesAaron Patterson2015-08-253-9/+13
| | | | This saves a lambda and request allocation on each request.
* always dispatch to controllers the same wayAaron Patterson2015-08-253-7/+26
| | | | | controllers should always go through the `action` class method so that their middleware is respected.
* always return a controller class from the `controller_class` methodAaron Patterson2015-08-252-9/+14
| | | | | now the caller can just treat it like a regular controller even though it will return a 404
* Merge pull request #21368 from rodzyn/remove_mochaKasper Timm Hansen2015-08-255-163/+209
|\ | | | | Get rid of mocha tests in actionpack - part 2
| * Get rid of mocha tests - part 2Marcin Olichwirowicz2015-08-255-163/+209
| |
* | Merge pull request #21375 from rodzyn/unused_requiresRafael Mendonça França2015-08-251-2/+0
|\ \ | | | | | | Remove unused requires
| * | Remove unused requiresMarcin Olichwirowicz2015-08-251-2/+0
| | | | | | | | | | | | They are already required in `actionpack/lib/action_dispatch.rb` (L25-L26)
* | | Merge pull request #21366 from amitsuroliya/remove_unused_variableRafael Mendonça França2015-08-252-13/+13
|\ \ \ | |/ / |/| | Remove more unused block arguments
| * | Remove more unused block arguments amitkumarsuroliya2015-08-252-13/+13
| | |
* | | Make `assert_index` privateMarcin Olichwirowicz2015-08-251-3/+1
| | | | | | | | | | | | | | | This `protected` keyword looks like some leftover, since we are not using explicit receiver, this should go under `private`
* | | Merge pull request #21345 from aditya-kapoor/trim-apRafael Mendonça França2015-08-252-6/+4
|\ \ \ | |/ / |/| | Trim out least needed controllers from AP test suite
| * | Trim out unneeded controllers from AP test suiteAditya Kapoor2015-08-242-6/+4
| | |
* | | remove unused require ‘set’NehaGautam2015-08-251-1/+0
| | |
* | | Merge pull request #21094 from aditya-kapoor/add-missing-ap-testsRafael Mendonça França2015-08-251-0/+10
|\ \ \ | | | | | | | | add missing test for action regexp for routing
| * | | add missing tests for action regexpAditya Kapoor2015-08-021-0/+10
| | | |
* | | | Remove unused block argumentsAnshul Sharma2015-08-252-2/+2
| | | |
* | | | Remove unused block argumentsamitkumarsuroliya2015-08-251-1/+1
| | | |
* | | | remove more direct `env` mutationsAaron Patterson2015-08-242-2/+4
| | | |
* | | | remove another `@env` accessAaron Patterson2015-08-241-1/+1
| | | |
* | | | remove more direct access to `env`Aaron Patterson2015-08-242-3/+4
| | | |
* | | | fewer calls to `env`Aaron Patterson2015-08-241-2/+2
| | | | | | | | | | | | | | | | We don't want to directly access the env hash
* | | | stop using `@env` in the GET / POST methodsAaron Patterson2015-08-242-4/+11
| | | | | | | | | | | | | | | | | | | | I want to implement this with something besides `@env` in the future, so lets stop directly referencing it.
* | | | rm useless methodAaron Patterson2015-08-241-4/+0
| | | | | | | | | | | | | | | | superclass already has this method, so remove this one
* | | | remove dead code :bomb:Aaron Patterson2015-08-241-2/+0
| | | |
* | | | pull up dispatcher allocationAaron Patterson2015-08-242-5/+1
| | | | | | | | | | | | | | | | | | | | the dispatcher class isn't configurable anymore, so pull up allocation to the method that needs it.
* | | | directly ask the request for the controller classAaron Patterson2015-08-241-6/+1
| | | | | | | | | | | | | | | | | | | | | | | | Now that we don't have subclasses depending on this method (they augment the request class instead of the dispatch class) we can remove this method and directly ask the request object for the controller class
* | | | use `make_set` helper method to generate route setsAaron Patterson2015-08-241-31/+1
| | | | | | | | | | | | | | | | We should keep the route set generation logic in one place
* | | | remove useless ivarAaron Patterson2015-08-241-2/+1
| | | |
* | | | remove setter for the dispatcher classAaron Patterson2015-08-241-2/+2
| | | | | | | | | | | | | | | | we don't need it anymore. We always use the same dispatcher in tests.
* | | | subclass and delegate rather than mutating existing objectsAaron Patterson2015-08-241-12/+29
| | | | | | | | | | | | | | | | | | | | If we subclass and augment the superclass, then we don't need to have setters for particular things on the superclass.
* | | | temp files are no more requireGaurav Sharma2015-08-251-1/+0
| | | | | | | | | | | | `:nail_care:`
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 18:27:44 +0000