Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | AV::logger returns AC::logger if it's defined, workaround meanwhile AV ↵ | Santiago Pastorino | 2010-06-28 | 1 | -2/+3 | |
| | | | | | | doesn't have it's own logger Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Move Rails module to abstract_unit to make test in isolation work | Santiago Pastorino | 2010-06-28 | 2 | -3/+3 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixed that an ArgumentError is thrown when request.session_options[:id] is ↵ | Michael Lovitt | 2010-06-27 | 6 | -36/+113 | |
| | | | | | | | | read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types. [#4938] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Normalize recall params when the route is not a standard route otherwise ↵ | Andrew White | 2010-06-27 | 2 | -3/+48 | |
| | | | | | | :controller and :action may appear in the generated url [#4326 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Change reference to Test::Unit::AssertionFailedError to the generic ↵ | David Trasbo | 2010-06-26 | 1 | -1/+1 | |
| | | | | | | ActiveSupport::TestCase::Assertion [#4987 state:commited] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Small changes to responder: | José Valim | 2010-06-26 | 1 | -5/+13 | |
| | | | | | | * resources is always an array; * Lazy retrieve request and formats; * Alias api_location and navigation_location to resource_location, making easier to change its behavior without affecting each other and without a need to reimplement any of the behavior methods. | |||||
* | Support optional static segements as well [#4832 state:resolved] | Andrew White | 2010-06-26 | 2 | -1/+35 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Fixed normalize_path in Routing::Mapper to handle optional prefix segments ↵ | Paul Barry | 2010-06-26 | 2 | -1/+47 | |
| | | | | | | with static and dynamic parts Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Don't force pluralization of controller name when defining a resource [#4980 ↵ | Andrew White | 2010-06-26 | 2 | -1/+18 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | URL fragments should not have safe characters escaped. Ref: Appendix A, ↵ | Andrew White | 2010-06-25 | 2 | -4/+10 | |
| | | | | | | | | http://tools.ietf.org/rfc/rfc3986.txt [#4762 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Failing test for whether glob parameters accept regexps | Andrew White | 2010-06-25 | 1 | -0/+9 | |
| | | | | | | [#4970 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Add failing test case for parameters with periods | Andrew White | 2010-06-25 | 1 | -0/+27 | |
| | | | | | | [#2536 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Do not mark the session as loaded if an error happened while doing it. | José Valim | 2010-06-25 | 1 | -2/+1 | |
| | ||||||
* | Calling exists? in the session store, without checking for stale sessions, ↵ | José Valim | 2010-06-25 | 2 | -10/+10 | |
| | | | | was causing the cookie store to panic because we need to unpack the whole session to get its key. This commit fixes this issue and also caches exists calls for performance improvements. | |||||
* | Do not wrap hidden fields with error proc [#4962 state:resolved] | Carlos Antonio da Silva | 2010-06-25 | 3 | -3/+23 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Make sure that Rails doesn't resent session_id cookie over and over again if ↵ | Prem Sichanugrist | 2010-06-25 | 3 | -1/+27 | |
| | | | | | | | | it's already there [#2485 state:resolved] This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Just reading flash messages should not create a session if one does not ↵ | José Valim | 2010-06-25 | 3 | -5/+29 | |
| | | | | exist yet. | |||||
* | Avoid deserializing cookies too early, which causes session objects to not ↵ | José Valim | 2010-06-24 | 3 | -21/+25 | |
| | | | | be available yet. Unfortunately, could not reproduce this in a test case. | |||||
* | Fix namespaced redirects [#4389 state:resolved] | Andrew White | 2010-06-24 | 2 | -1/+15 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 11 | -104/+101 | |
| | | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] | |||||
* | Avoid using Pathname on Resolver and AS::Dependencies. | José Valim | 2010-06-24 | 1 | -1/+1 | |
| | ||||||
* | Sessions should not be created until written to and session data should be ↵ | Michael Lovitt | 2010-06-23 | 8 | -35/+190 | |
| | | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Expose view via the view() method in AV::TestCase::Behavior | David Chelimsky | 2010-06-23 | 2 | -17/+24 | |
| | | | | | | | | | | - was exposed as _view, which suggested it was private - left _view as an alias of view as not to break any extensions that are relying on _view [#4932 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | In ActionView::TestCase::Behavior, assign variables right before | David Chelimsky | 2010-06-23 | 3 | -2/+16 | |
| | | | | | | | | | | | rendering the view. - Previously, _assigns were locked down the first time _view was referenced. [#4931 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | make text_field and hidden_field omit the value attribute if the developer ↵ | Jeff Dean | 2010-06-23 | 2 | -4/+14 | |
| | | | | | | explicitly passes in :value => nil [#4839 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> | |||||
* | Fix controller_name for non default controller paths [#4901 state:resolved] | knapo | 2010-06-23 | 2 | -1/+39 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Tidy up asset tag a bit and make railties tests green again. | José Valim | 2010-06-23 | 3 | -29/+24 | |
| | ||||||
* | refactored the javascript asset tag helpers and moved the default scripts ↵ | Josh Kalderimis | 2010-06-23 | 3 | -29/+21 | |
| | | | | | | setup within the railtie Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Update CHANGELOG. | José Valim | 2010-06-23 | 1 | -0/+6 | |
| | ||||||
* | Add the :path option to match routes when given as symbols. This is ↵ | Carlos Antonio da Silva | 2010-06-23 | 2 | -10/+28 | |
| | | | | | | | | | | specially useful in http helpers for generating routes in scenarios like: resources :users, :path => 'usuarios' do get :search, :on => :collection, :path => 'pesquisar' end Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Provive resources_path_names helpers in the router. | José Valim | 2010-06-23 | 2 | -0/+15 | |
| | ||||||
* | Stop filling the blocks scope array with nil. | José Valim | 2010-06-22 | 1 | -1/+3 | |
| | ||||||
* | Allow namespace accept options in routes [#4936 state:resolved] | Carlos Antonio da Silva | 2010-06-22 | 2 | -3/+17 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Deprecate :name_prefix in the new router DSL. | José Valim | 2010-06-22 | 3 | -23/+27 | |
| | ||||||
* | Remove unused variable on assert_recognizes [#4912 state:resolved] | Paco Guzman | 2010-06-22 | 1 | -1/+0 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | update the list of instance variables that are excluded from assigns in view ↵ | David Chelimsky | 2010-06-22 | 1 | -9/+10 | |
| | | | | | | | | tests [#4930 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | adds minus to value part of id [#4862 state:resolved] | RainerBlessing | 2010-06-22 | 1 | -1/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | test for #4862 | Neeraj Singh | 2010-06-22 | 1 | -0/+5 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add support for specifying locals in view tests with assert template [#4927 ↵ | David Chelimsky | 2010-06-22 | 3 | -5/+44 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Ensure overwritten callbacks conditions in controllers work [#4761 ↵ | José Valim | 2010-06-22 | 1 | -2/+12 | |
| | | | | state:resolved] [#3913 state:resolved] | |||||
* | Bump rack-mount to 0.6.5 for tokenizer speedup | Jeremy Kemper | 2010-06-21 | 1 | -1/+1 | |
| | ||||||
* | removed 'unless const_defined?' code smell | Josh Kalderimis | 2010-06-21 | 6 | -47/+39 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 28 | -281/+727 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | |||||
| * | Use the new ActiveSupport::FileUpdateChecker instead of RoutesReloader. | José Valim | 2010-06-20 | 1 | -1/+1 | |
| | | ||||||
| * | Fixed date_select date_separator when discard_month and/or discard_day are ↵ | Thibaud Guillaume-Gentil | 2010-06-20 | 2 | -2/+31 | |
| | | | | | | | | | | | | true [#4856 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Adding missing test to autolink with other protocols (file) [#4886 ↵ | Carlos Antonio da Silva | 2010-06-20 | 1 | -0/+1 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Make sure a namespaced <%= render form %> still renders the _form partial ↵ | Jan De Poorter | 2010-06-20 | 3 | -1/+13 | |
| | | | | | | | | | | | | [#4784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Use Rack::Utils.bytesize when calculating content-length of exception pages. ↵ | Tarsoly András | 2010-06-20 | 1 | -1/+1 | |
| | | | | | | | | | | | | [#4727 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | remove executable permission from files that don't need it. [#4802 ↵ | rohit | 2010-06-20 | 1 | -0/+0 | |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
| * | Support render_template in view tests. Useful for specifying which | David Chelimsky | 2010-06-20 | 2 | -0/+9 | |
| | | | | | | | | | | | | | | | | partials are rendered under different conditions. [#4903 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> |