| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Remove HelperyTestHelper not used in any test
|
| |
| |
| |
| |
| |
| | |
HelperyTestHelper was introduced in 66ef922 by @josevalim
to pair with HelperyTestController. This test controller was
later removed in e10a253 by @strzalek, leaving HelperyTestHelper unused
|
| | |
|
| | |
|
| |
| |
| |
| | |
Onf of the sides can be nil and it will raise a Conversion error
|
| |
| |
| |
| | |
test for regression introduced by https://github.com/rails/rails/pull/9155
|
|\ \
| | |
| | |
| | | |
Adding documentation and tests to ``polymorphic_url`` and ``link_to``
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
concerning the options that it inherits from +url_for+. The way that
+polymorhpic_url+ is built allows it to have options
like +:anchor+, +:script_name+, etc. but this is currently not
documented.
|
|\ \ \
| | | |
| | | | |
Rewrite Journey::Visitors::Formatter for performance
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The previous regex was allowing `_` in the URI scheme, which is not
allowed by RFC 3986. This change brings the regex in line with the RFC.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In some instances, `assert_redirected_to` assertion was returning an
incorrect and misleading failure message when the assertion failed.
This was due to a disconnect in how the assertion computes the redirect
string for the failure message and how `redirect_to` computes the
string that is actually used for redirection.
I made the `_compute_redirect_to_loaction` method used by `redirect_to`
public and call that from the method `assert_redirect_to` uses to
calculate the URL.
The reveals a new test failure due to the regex used by
`_compute_redirect_to_location` allow `_` in the URL scheme.
|
|\ \ \ \
| | | | |
| | | | | |
Remove 1.8 compatible code
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
Previously it was raising a NilException
|
| | | | |
|
| |_|/
|/| |
| | |
| | |
| | | |
This gem is used by Active Support but it should not be a dependency of
Action Pack.
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Custom flash should be defined only for the class that defines it and it's subclasses
Fixes #12057
|
| | | |
| | | |
| | | |
| | | | |
subclasses.
|
|\ \ \ \
| |/ / /
|/| | | |
Fix typos: the indefinite articles(a -> an).
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
do not break params filtering on nil values
|
| | | | |
| | | | |
| | | | |
| | | | | |
closes #12149
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit ab5cd54b7e791f8419f689d1bef5394890268a6f, reversing
changes made to cdc10c898d4865302740340eedec4f5f4ca76565.
Reason: This way of defining root path is still supported. See
https://github.com/rails/rails/blob/d262773ab7f0aae5de2d354ac2eca168e95b653d/actionpack/test/controller/routing_test.rb#L450-457
|
|\ \ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The documentation in this section is referring to a profile,
so the resource that's created should probably also be a
profile of some sort.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The docs refference a blacklist, but really what's being described
is a whitelist. Anything that matches the constraint gets through to
the path.
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reference:
Bloody mess internals
http://gusiev.com/slides/rails_contribution/static/#40
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The fixture for module AbcHelper defines three functions bare_a,
bare_b and bare_c, but only bare_a is used in the code that tests
helper functions.
|
| | | | | | |
|
| | | | | | |
|
| |/ / / /
|/| | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Update mapper documenation for match helper [ci skip]
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This piece of documentation is out of date.
The use of match without any via option is prevented, now
the HTTP verbs have to be explicitly set. If they're not set then
the error message in normalize_conditions! (around line 186) is
shown.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The methods:
* #render_to_body
* #render_to_string
* #_normalize_render
Haven't had anything specyfic to ActionView. This was common code which should belong to AbstractController
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit 7de994fa215e9f4c2856d85034bc4dd7b65d0c01.
|