aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #21181 from denisenkom/mypatchKasper Timm Hansen2016-01-101-0/+19
|\ | | | | Test basic auth with symbols in password
| * Test basic auth with symbols in login and passwordMikhail Denisenko2015-10-241-0/+19
| |
* | [ci skip] Fix typo Renderering --> RenderingAkshay Vishnoi2016-01-091-1/+1
| |
* | Fix typo in ActionPack CHANGELOG [ci skip]Prathamesh Sonpatki2016-01-081-1/+1
| |
* | add gregBen Toews2016-01-071-1/+1
| |
* | Better error message when running `rake routes` with CONTROLLER arg:Edouard CHIN2016-01-073-7/+64
| | | | | | | | | | | | | | - `CONTROLLER` argument can now be supplied in different ways (Rails::WelcomeController, Rails::Welcome, rails/welcome) - If `CONTROLLER` argument was supplied but it does not exist, will warn the user that this controller does not exist - If `CONTROLLER` argument was supplied and no routes could be found matching this filter, will warn the user that no routes were found matching the supplied filter - If no routes were defined in the config/routes.rb file, will warn the user with the original message
* | Merge pull request #20109 from prathamesh-sonpatki/keep-only-one-rootKasper Timm Hansen2016-01-071-21/+21
|\ \ | | | | | | Remove original root method from Base module and kept overridden implementation in Resources module.
| * | Kept overridden root method and removed original methodPrathamesh Sonpatki2016-01-071-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - The root method is defined and documented in Base module and decorated in Resources module. - The documentation in Base module actually talks about method signature of decorated method from Resources module. - Argument handling was moved to decorated method in https://github.com/rails/rails/commit/977455cc2efb94f40b4c0d46d1842be198ed7c4c to handle options such as :as with directly passed path parameter. - To avoid the confusion, removed original root method from Base module and only kept overridden version in Resources module. - References - https://github.com/rails/rails/pull/12208 & https://github.com/rails/rails/pull/12208#issuecomment-24350897.
* | | Remove splat operator warning from ssl_testPrathamesh Sonpatki2016-01-071-1/+1
| | | | | | | | | | | | | | | | | | - Removes following warning - `rails/actionpack/test/dispatch/ssl_test.rb:203: warning: `*' interpreted as argument prefix`.
* | | Allow AC::Parameters as an argument to url_helpersPrathamesh Sonpatki2016-01-073-2/+40
| | | | | | | | | | | | | | | | | | | | | | | | - Earlier only Hash was allowed as params argument to url_helpers. - Now ActionController::Parameters instances will also be allowed. - If the params are not secured then it will raise an ArgumentError to indicate that constructing URLs with non-secure params is not recommended. - Fixes #22832.
* | | Merge pull request #22275 from mastahyeti/per-form-csrfRafael França2016-01-063-11/+230
|\ \ \ | | | | | | | | Per-form CSRF tokens
| * | | add option for per-form CSRF tokensBen Toews2016-01-043-11/+230
| | | |
* | | | Merge pull request #22906 from bf4/rendering_exceptionsRafael França2016-01-043-88/+163
|\ \ \ \ | |/ / / |/| | | Add ActionController:Renderers test
| * | | Group related methods togetherBenjamin Fleischer2016-01-031-67/+67
| | | |
| * | | Add ActionController:Renderers testBenjamin Fleischer2016-01-033-24/+99
| | | | | | | | | | | | | | | | To complement actionpack/test/controller/metal/renderers_test.rb
* | | | Merge pull request #22890 from DNNX/times-mapSantiago Pastorino2016-01-031-1/+1
|\ \ \ \ | | | | | | | | | | Replace x.times.map{} with Array.new(x){} in AD::Journey::Path::Pattern
| * | | | Replace x.times.map{} with Array.new(x){}Viktar Basharymau2016-01-021-1/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The former is slightly more readable, performant and has fewer method calls. ```ruby Benchmark.ips do |x| x.report('times.map') { 5.times.map{} } x.report('Array.new') { Array.new(5){} } x.compare! end __END__ Calculating ------------------------------------- times.map 21.188k i/100ms Array.new 30.449k i/100ms ------------------------------------------------- times.map 311.613k (± 3.5%) i/s - 1.568M Array.new 590.374k (± 1.2%) i/s - 2.954M Comparison: Array.new: 590373.6 i/s times.map: 311612.8 i/s - 1.89x slower ```
* / / / Fix typo in test desctiption [skip ci]Anton Davydov2016-01-041-1/+1
|/ / /
* | | Merge pull request #22519 from bf4/test_use_renderersRafael França2015-12-314-0/+86
|\ \ \ | | | | | | | | Add tests for ActionController::Renderers::use_renderers
| * | | Test ActionController::Renderers::use_renderersBenjamin Fleischer2015-12-314-0/+86
| | | |
* | | | Update copyright notices to 2016 [ci skip]Rashmi Yadav2015-12-313-3/+3
|/ / /
* | | Merge pull request #22850 from prathamesh-sonpatki/fix_ac_params_unsafe_h_2Kasper Timm Hansen2015-12-313-6/+22
|\ \ \ | | | | | | | | Fix AC::Parameters#to_unsafe_h to return all unfiltered values
| * | | Fix AC::Parameters#to_unsafe_h to return all unfiltered valuesPrathamesh Sonpatki2015-12-313-6/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - AC::Parameters#convert_parameters_to_hashes should return filtered or unfiltered values based on whether it is called from `to_h` or `to_unsafe_h` instead of always defaulting to `to_h`. - Fixes #22841
* | | | Merge pull request #22826 from timrogers/actiondispatch-ssl-configRafael França2015-12-312-23/+42
|\ \ \ \ | | | | | | | | | | Configurable redirect and secure cookies for ActionDispatch::SSL
| * | | | Flexible configuration for ActionDispatch::SSLTim Rogers2015-12-292-23/+42
| | | | |
* | | | | Avoid `Time.parse` for static dateRafaël Blais Masson2015-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Benchmark.ips do |x| x.report('Time.parse') { Time.parse('2011-01-01') } x.report('Time.new') { Time.new(2011, 1, 1) } end Calculating ------------------------------------- Time.parse 6.640k i/100ms Time.new 15.082k i/100ms ------------------------------------------------- Time.parse 71.915k (± 3.1%) i/s - 365.200k Time.new 167.645k (± 3.3%) i/s - 844.592k
* | | | | Fix test for AC::Parameters#to_unsafe_hPrathamesh Sonpatki2015-12-301-2/+2
| |/ / / |/| | | | | | | | | | | - Test should call `to_unsafe_h` instead of `to_h`
* | | | Merge pull request #22830 from jcoyne/parameters_includeRichard Schneeman2015-12-293-1/+11
|\ \ \ \ | | | | | | | | | | Add AC::Parameters#include?
| * | | | Add AC::Parameters#include?Justin Coyne2015-12-293-1/+11
| |/ / / | | | | | | | | | | | | Fixes #22818
* | | | Format from Accept headers have higher precedence than path extension formatJorge Bejar2015-12-292-2/+11
| | | |
* | | | Rely on default Mime format when MimeNegotiation#format_from_path_extension ↵Jorge Bejar2015-12-292-3/+15
|/ / / | | | | | | | | | | | | | | | is not a valid type Closes #22747
* | | Improve RDoc documentation of ActionDispatch::SSLTim Rogers2015-12-241-12/+14
| | |
* | | Currectly test the Middleware#==Rafael Mendonça França2015-12-221-4/+8
| | |
* | | Merge pull request #22743 from maclover7/fix-22738Rafael Mendonça França2015-12-222-0/+21
|\ \ \ | | | | | | | | | | | | Add #== back to ActionDispatch::MiddlewareStack::Middleware
| * | | Add #== back to ActionDispatch::MiddlewareStack::MiddlewareJon Moss2015-12-212-0/+21
| | | | | | | | | | | | | | | | | | | | This was causing bug #22738 to occur. Also added extra tests to make sure everything is A-OK.
* | | | release notes, extract notable changes from Action Pack CHANGELOG.Yves Senn2015-12-221-24/+25
|/ / / | | | | | | | | | [ci skip]
* | | Remember the parameter hash we returnMatthew Draper2015-12-221-1/+1
| | | | | | | | | | | | Callers expect to be able to manipulate it.
* | | No more no changes entries in the CHANGELOGsGenadi Samokovarov2015-12-211-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the following: ``` * No changes. ``` It is kinda confusing as there are indeed changes after it. Not a biggie, just a small pass over the CHANGELOGs. [ci skip]
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2015-12-202-3/+3
|\ \ \
| * | | Add missing punctuation mark [ci skip]Gaurav Sharma2015-11-182-3/+3
| | | |
* | | | Add CHANGELOG headers for Rails 5.0.0.beta1eileencodes2015-12-181-0/+5
| | | |
* | | | Change `alpha` to `beta1` to prep for release of Rails 5eileencodes2015-12-181-1/+1
| | | | | | | | | | | | | | | | :tada: :beers:
* | | | Merge pull request #22650 from derekprior/dp-actionpack-warningsRafael França2015-12-181-0/+5
|\ \ \ \ | | | | | | | | | | Fix "instance variable not initialized" in tests
| * | | | Fix "instance variable not initialized" in testsDerek Prior2015-12-171-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ActionPack test suite had a handful of these warnings when run. This was due to `assert_response` being tested outside the context of a controller instance where those instance variables would already have been initialized.
* | | | | Merge pull request #20797 from byroot/prevent-url-for-ac-parametersRafael França2015-12-185-5/+14
|\ \ \ \ \ | | | | | | | | | | | | Prevent ActionController::Parameters in url_for
| * | | | | Prevent ActionController::Parameters from being passed to url_for directlyJean Boussier2015-12-155-5/+14
| | | | | |
* | | | | | Refer to rails command instead of rake in a bunch of placesDavid Heinemeier Hansson2015-12-182-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Still more to do. Please assist!
* | | | | | Document when fallback_location is used [ci-skip]Derek Prior2015-12-171-2/+8
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you're not familiar with how the `Referer` header works, you likely won't understand why you need to provide a fallback or under what circumstances it would be used. Hopefully this clarifies things a bit.
* | | | | Only dup Ruby's Hash and Array.Kasper Timm Hansen2015-12-172-2/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling `to_h` on an `ActionController::Parameters` instance it would `deep_dup` its internal parameters. This inadvertently called `dup` on a passed Active Record model which would create new models. Fix by only dupping Ruby's Arrays and Hashes.
* | | | | Deprecate `redirect_to :back`Derek Prior2015-12-163-12/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Applications that use `redirect_to :back` can be forced to 500 by clients that do not send the HTTP `Referer` (sic) header. `redirect_back` requires the user to consider this possibility up front and avoids this trivially-caused application error.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 07:36:26 +0000