| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | Restore test deliveries for ActionMailer. | Zuhao Wan | 2014-06-07 | 1 | -1/+4 | |
| | | | ||||||
| * | | Handle client disconnect during live streaming | Matthew Draper | 2014-06-08 | 4 | -13/+189 | |
| | | | | | | | | | .. even when the producer is blocked for a write. | |||||
| * | | adds some details to the rationale of converted_arrays [ci skip] | Xavier Noria | 2014-06-07 | 2 | -1/+5 | |
| | | | ||||||
| * | | adds a regression test for the strong params converted arrays cache | Xavier Noria | 2014-06-07 | 1 | -1/+18 | |
| | | | | | | | | | This is a regression test for 29844dd. | |||||
| * | | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded" | Xavier Noria | 2014-06-07 | 2 | -7/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b. | |||||
| * | | [ci skip] Fix capitalization | Akshay Vishnoi | 2014-06-07 | 2 | -3/+3 | |
| | | | ||||||
| * | | remove another wasteful AS::SafeBuffer allocation | Aaron Patterson | 2014-06-06 | 1 | -1/+1 | |
| | | | ||||||
| * | | eliminate wasteful AS::SafeBuffer allocation | Aaron Patterson | 2014-06-06 | 1 | -1/+1 | |
| |/ | ||||||
| * | Use a frozen Set instance for CGI_VARIABLES. | Nathaniel Bibler | 2014-06-05 | 1 | -8/+21 | |
| | | | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility. | |||||
| * | Avoid misuse of underscore argument | Corey Ward | 2014-06-05 | 1 | -2/+2 | |
| | | | | Per convention, underscore-only argument names should be used for unused parameters. | |||||
| * | Merge pull request #15530 from zuhao/refactor_actionpack_reloader_test | Matthew Draper | 2014-06-06 | 1 | -0/+5 | |
| |\ | | | | | Reset callbacks after test. | |||||
| | * | Reset callbacks after test. | Zuhao Wan | 2014-06-05 | 1 | -0/+5 | |
| | | | | | | | | | Otherwise the state of callback chain is leaked. | |||||
| * | | Merge pull request #15532 from zuhao/refactor_actionpack_response_test | Yves Senn | 2014-06-05 | 1 | -2/+4 | |
| |\ \ | | | | | | | Restore Response.default_headers after test. | |||||
| | * | | Restore Response.default_headers after test. | Zuhao Wan | 2014-06-05 | 1 | -2/+4 | |
| | | | | ||||||
| * | | | Avoid hard-coded value in test setup/teardown. | Zuhao Wan | 2014-06-05 | 1 | -1/+2 | |
| |/ / | ||||||
| * | | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_test | Yves Senn | 2014-06-05 | 2 | -8/+0 | |
| |\ \ | |/ |/| | Make sure Mime::Type is not altered after tests. | |||||
| | * | Mime::PNG is already defined. | Zuhao Wan | 2014-06-05 | 2 | -8/+0 | |
| | | | ||||||
| * | | Avoid hardcoded value in test setup/teardown. | Zuhao Wan | 2014-06-05 | 1 | -1/+2 | |
| |/ | ||||||
| * | Merge branch 'master' of github.com:rails/rails | Aaron Patterson | 2014-06-04 | 8 | -50/+19 | |
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: For our build, stick with mail 2.5.x for now Correct result, previously showing wrong result Collapse PG default extractoin of most types to single regex Change wording of explanation about precision & scale of decimal numbers [ci skip] Cleaned up duplicated CHANGELOG entry [ci skip] reuse available belongs_to? method Convert StrongParameters cache to a hash. This fixes an unbounded memory leak demonstrated on @tenderlove's latest blog post: Partially revert deprecation of *_filter Pluralize params Add default_i18n_subject to the guides Fix regression on eager loading association based on SQL query rather than existing column. Relax mail gem constraint from ~> 2.5.4 to ~> 2.5, >= 2.5.4 Keep column defaults in type cast form Return a null column when no column exists for an attribute Refactor XML serializer to not depend on `serialized_attributes` Test the serialized types of virtual columns in XML implement ActiveRecord::Base#pretty_print + changelog Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | |||||
| | * | Merge pull request #15498 from zenspider/fix_memory_leak | Guillermo Iguaran | 2014-06-03 | 2 | -7/+7 | |
| | |\ | | | | | | | Convert StrongParameters cache to a hash. This fixes an unbounded memory leak | |||||
| | | * | Convert StrongParameters cache to a hash. This fixes an unbounded | Ryan Davis | 2014-06-03 | 2 | -7/+7 | |
| | | | | | | | | | | | | | | | | | | | memory leak demonstrated on @tenderlove's latest blog post: http://tenderlovemaking.com/2014/06/02/yagni-methods-are-killing-me.html | |||||
| | * | | Partially revert deprecation of *_filter | Rafael Mendonça França | 2014-06-03 | 3 | -36/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are going to deprecate only on Rails 5 to make easier plugin maintainers support different Rails versions. Right now we are only discouraging their usage. This reverts commit 6c5f43bab8206747a8591435b2aa0ff7051ad3de. Conflicts: actionpack/CHANGELOG.md | |||||
| | * | | Merge pull request #15349 from tgxworld/remove_duplicated_method_call | Rafael Mendonça França | 2014-06-03 | 3 | -7/+3 | |
| | |\ \ | | | | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | |||||
| | | * | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access. | Guo Xiang Tan | 2014-05-26 | 3 | -7/+3 | |
| | | | | | ||||||
| * | | | | push splitting "to" up the callstack | Aaron Patterson | 2014-06-03 | 1 | -15/+20 | |
| |/ / / | ||||||
| * | | | oops! :bomb: | Aaron Patterson | 2014-06-03 | 2 | -92/+0 | |
| | | | | ||||||
| * | | | Routes specifying 'to:' must be a string that contains a "#" or a rack | Aaron Patterson | 2014-06-03 | 6 | -27/+149 | |
| | | | | | | | | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`. | |||||
| * | | | use the factory method to construct the mapping | Aaron Patterson | 2014-06-03 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | add tests for mixing :to and controller / action | Aaron Patterson | 2014-06-03 | 1 | -0/+48 | |
| | | | | ||||||
| * | | | push some options munging to an alternate constructor | Aaron Patterson | 2014-06-03 | 1 | -13/+19 | |
| | | | | ||||||
| * | | | add tests for nested lambda constraints | Aaron Patterson | 2014-06-03 | 1 | -0/+27 | |
| | | | | ||||||
| * | | | move options_constraints tests next to each other | Aaron Patterson | 2014-06-03 | 1 | -2/+2 | |
| | | | | ||||||
| * | | | only do is_a checks on `formatted` once | Aaron Patterson | 2014-06-03 | 1 | -9/+5 | |
| | | | | ||||||
| * | | | push options_constraints processing up | Aaron Patterson | 2014-06-03 | 1 | -22/+24 | |
| | | | | | | | | | | | | | | | | this lets us reduce is_a checks on the options_constraints and push "callable constraints" verification to the right place. | |||||
| * | | | remove options as an ivar | Aaron Patterson | 2014-06-03 | 1 | -6/+8 | |
| | | | | ||||||
| * | | | only do Regexp === option once | Aaron Patterson | 2014-06-03 | 1 | -3/+4 | |
| | | | | ||||||
| * | | | return early from add_request_method | Aaron Patterson | 2014-06-03 | 1 | -11/+11 | |
| | | | | ||||||
| * | | | only loop over `options` once (hopefully) | Aaron Patterson | 2014-06-03 | 1 | -13/+11 | |
| | | | | ||||||
| * | | | only loop through constraints once | Aaron Patterson | 2014-06-03 | 1 | -19/+15 | |
| | | | | ||||||
| * | | | change defaults allocation to a one-liner | Aaron Patterson | 2014-06-03 | 1 | -3/+2 | |
| | | | | ||||||
| * | | | no longer need the scope ivar | Aaron Patterson | 2014-06-03 | 1 | -2/+1 | |
| | | | | ||||||
| * | | | only look up scope[:module] once | Aaron Patterson | 2014-06-03 | 1 | -6/+6 | |
| | | | | ||||||
| * | | | remove IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+8 | |
| | | | | ||||||
| * | | | :only is never used in Mapping, so rm the key | Aaron Patterson | 2014-06-03 | 1 | -1/+2 | |
| | | | | ||||||
| * | | | remove :defaults from the IGNORE_OPTIONS list | Aaron Patterson | 2014-06-03 | 1 | -4/+4 | |
| | | | | ||||||
| * | | | remove :constraints from IGNORE_OPTIONS | Aaron Patterson | 2014-06-03 | 1 | -4/+5 | |
| | | | | ||||||
| * | | | disconnect normalize_defaults! from options[:constraints] | Aaron Patterson | 2014-06-03 | 1 | -6/+6 | |
| | | | | ||||||
| * | | | disconnect options and scope from the `blocks` method | Aaron Patterson | 2014-06-03 | 1 | -7/+8 | |
| | | | | ||||||
| * | | | disconnect the constraints method from the options and scope hashes | Aaron Patterson | 2014-06-03 | 1 | -12/+15 | |
| | | | | ||||||
| * | | | :on is removed from options before the Mapping is instantiated, so remove it ↵ | Aaron Patterson | 2014-06-03 | 1 | -1/+1 | |
| | | | | | | | | | | | | | from IGNORE_OPTIONS | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/actionpack