| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Authorization scheme should be case insensitive. Fixes #21199
|
| | |
|
| |
| |
| |
| |
| | |
this way we don't have to insert / delete it from the options hash so
many times.
|
| |
| |
| |
| |
| | |
eventually we'll remove the need to access `scope` inside the Mapping
object.
|
| | |
|
| |
| |
| |
| |
| |
| | |
`using_match_shorthand?` doesn't need to know that an options hash
exists. Also use this opportunity to make the boolean logic a little
more sane
|
| | |
|
| |
| |
| |
| |
| | |
this simplifies the "downstream" logic since we know we'll only be
dealing with one particular type
|
| | |
|
| |
| |
| |
| |
| | |
I think we can find the original place where `action` is added to the
options hash now.
|
| | |
|
| |
| |
| |
| |
| |
| | |
we want to try to pull this logic up to where the user actually passed
in "controller" so that it's close to the related call. That way when
we're down the stack, we don't need to wonder "why are we doing this?"
|
| | |
|
| |
| |
| |
| |
| | |
There are some cases where :path is nil on option and we should respect
that.
|
| |
| |
| |
| | |
We already know how to handle `path`, so lets just handle it on our own.
|
| |
| |
| |
| |
| |
| |
| | |
All callers of `action_path` interpolate the return value in to a
string, so there is no need for the method to to_s it. to_sym on a
symbol will return the same symbol, though I think `action_path` may
always be called with a symbol so this might not be necessary.
|
| |
| |
| |
| | |
we only need to check for `path` once.
|
| |
| |
| |
| | |
Now we can see where `defaults` options originate
|
| | |
|
| |
| |
| |
| |
| | |
since `controller` and `controller_scope` were the same, just combine
them
|
| | |
|
| |
| |
| |
| |
| | |
This method isn't used internally, isn't tested, isn't documented. We
should delete it.
|
| |
| |
| |
| |
| | |
add a predicate method so that we can avoid is_a? calls on the resource
object.
|
| |
| |
| |
| |
| | |
calling `scope` isn't cheap, so try to call cheaper methods that do the
same thing for those particular parameters (in this case `path_scope`)
|
| |
| |
| |
| |
| | |
`resource_scope` should just put resource scopes on the stack, and
doesn't need to know what a `scope_level` is.
|
| |
| |
| |
| |
| | |
We just want to augment the scope level, not the frame itself, so just
copy the frame to the new scope object.
|
| |
| |
| |
| | |
this gives us an easier way to iterate the stack
|
| |
| |
| |
| |
| | |
The same information is stored in the `@scope` linked list, so just get
it from there.
|
| |
| |
| |
| | |
this lets us remove the setter and make the Resource object Read-Only
|
| |
| |
| |
| |
| | |
We don't need to ask `scope` for the resource because we already have it
right here.
|
| |
| |
| |
| |
| | |
This method raises conditionally not always so we should not documment
as it always raise.
|
| | |
|
| |
| |
| |
| |
| | |
We should return when the contoller key is not present or if the
controller doesn't exist and we didn't raised an error.
|
| |
| |
| |
| | |
Related with dc1b937db780155089fce522f03d340e62f5df36
|
| |
| |
| |
| |
| |
| | |
eliminates calling `scope` in one method, pushes the other calls up one
frame. This goes a little way towards eliminating the internal calls to
`scope`.
|
| |
| |
| |
| | |
we don't really need this hash.
|
| |
| |
| |
| |
| |
| |
| | |
we need to get a grip on what `scope` actually does. This commit
removes some of the internal calls to `scope`. Eventually we should add
public facing methods that provide the API that `scope` is trying to
accomplish.
|
| |
| |
| |
| |
| |
| | |
`prepare_params!` would raise an exception if `params` wasn't
initialized, so it must always be available. Remove the existence
conditional from the `controller` method.
|
| |
| |
| |
| |
| | |
The method we called already has the conditional we need. Just add an
else block so that we don't need two tests.
|
| |
| |
| |
| |
| |
| |
| | |
`Dispatcher` doesn't need to hold on to the defaults hash. It only used
the hash to determine whether or not it should raise an exception if
there is a name error. We can pass that in further up the stack and
alleviate Dispatcher from knowing about that hash.
|
| |
| |
| |
| |
| |
| | |
We know in advance whether the object is a dispatcher or not, so we can
configure the Constraints object with a strategy that will call the
right method.
|
| | |
|
| |
| |
| |
| | |
it isn't used.
|
|\ \
| | |
| | | |
replace each with each_key when only the key is needed
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using each_key is faster and more intention revealing.
Calculating -------------------------------------
each 31.378k i/100ms
each_key 33.790k i/100ms
-------------------------------------------------
each 450.225k (± 7.0%) i/s - 2.259M
each_key 494.459k (± 6.3%) i/s - 2.467M
Comparison:
each_key: 494459.4 i/s
each: 450225.1 i/s - 1.10x slower
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The tests and methods were hard to read with `options[:options]` all
over the place. This refactoring makes the code easier to understand.
The change came out of work for moving the underlying code of controller
tests to integraiton tests.
|
|\ \ \
| | | |
| | | | |
Allow a custom dispatcher to be provided to routing.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
scope so that they are available to subclasses.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Using the string version of the class reference is now deprecated when
referencing middleware. This should be written as a class not as a string.
Deprecation warning that this change fixes:
```
DEPRECATION WARNING: Passing strings or symbols to the middleware
builder is deprecated, please change
them to actual class references. For example:
"ActionDispatch::ShowExceptions" => ActionDispatch::ShowExceptions
```
|