aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Fix spacingDavid Heinemeier Hansson2012-08-291-8/+8
| | |
* | | Fix spacingDavid Heinemeier Hansson2012-08-291-5/+4
| | |
* | | Merge pull request #7230 from schneems/schneems/expose_required_keysAndrew White2012-08-296-30/+41
|\ \ \ | | | | | | | | Add Missing Keys from Journey on Failed URL Format
| * | | refactor route_set `generate_extras` functionalityschneems2012-08-281-17/+9
| | | | | | | | | | | | | | | | | | | | | | | | The result of Generator with or without the @extras instance variable set contains the desired information. Rather than preserving state when initializing the original object, we can simply extract the keys from the resultant parameters. ATP Actionpack, railties
| * | | Add Missing Keys from Journey on failed URL formatschneems2012-08-286-16/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many named routes have keys that are required to successfully resolve. If a key is left off like this: <%= link_to 'user', user_path %> This will produce an error like this: No route matches {:action=>"show", :controller=>"users"} Since we know that the :id is missing, we can add extra debugging information to the error message. No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id] This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url. While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious. This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message. Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
* | | | Fixed indendationAyrton De Craene2012-08-291-3/+3
| | | |
* | | | CHANGELOGs are now per branchXavier Noria2012-08-281-6069/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes in old branches needed to be manually synched in CHANGELOGs of newer ones. This has proven to be brittle, sometimes one just forgets this manual step. With this commit we switch to CHANGELOGs per branch. When a new major version is cut from master, the CHANGELOGs in master start being blank. A link to the CHANGELOG of the previous branch allows anyone interested to follow the history.
* | | removed : warning: `*' interpreted as argument prefixArun Agrawal2012-08-281-1/+1
| | |
* | | Add missing requireRafael Mendonça França2012-08-281-0/+1
| | |
* | | Merge pull request #7452 from arunagw/memcached_dalliRafael Mendonça França2012-08-282-7/+7
|\ \ \ | | | | | | | | Memcached to dalli for actionpack test.
| * | | More fixes for action pack tests with Dalli.Arun Agrawal2012-08-271-3/+3
| | | |
| * | | Let's run action pack tests with DalliArun Agrawal2012-08-271-4/+4
| | | | | | | | | | | | There is no memcache gem left in repo.
* | | | Update AP's CHANGELOG with user facing changesPiotr Sarnacki2012-08-281-0/+14
| | | |
* | | | Deprecate AV::RecordIdentifier in controllersPiotr Sarnacki2012-08-283-4/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Methods provided by RecordIdentifier are not widely used in controllers nowadays as they're view specific (this is probably a legacy left after RJS rendering directly in controllers). However if people still need to use it, it's trivial to include ActionView::RecordIdentifier by themselves.
* | | | Fix ActionView::RecordIdentifier to work as a singletonPiotr Sarnacki2012-08-282-0/+10
| | | | | | | | | | | | | | | | | | | | We extend it with self, but the methods were not working properly were used directly on module.
* | | | No need to use included hook for includePiotr Sarnacki2012-08-281-3/+1
| | | | | | | | | | | | | | | | | | | | When module is extended ActiveSupport::Concern, include calls are lazily loaded, so there is no need to wrap it with included hook.
* | | | Deprecate Template#mime_typePiotr Sarnacki2012-08-282-0/+13
| | | |
* | | | Add deprecation horizon to html-scannerPiotr Sarnacki2012-08-281-1/+2
| | | |
* | | | Implement ActionView::Template::TypesPiotr Sarnacki2012-08-285-4/+65
| | | | | | | | | | | | | | | | | | | | | | | | AV::Template::Types is a small abstraction to allow to specify template types that can be used in ActionView. When Action Pack is loaded it's replaced with Mime::Type.
* | | | Don't require action_dispatch in ActionView::UrlHelpersPiotr Sarnacki2012-08-288-100/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required.
* | | | Use ActionView::Base.logger instead of AC::Base.loggerPiotr Sarnacki2012-08-282-2/+2
| | | |
* | | | Add ActionView::Base.default_formatsPiotr Sarnacki2012-08-284-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | default_formats array is used by LookupContext in order to allow rendering templates when :formats option is not passed. Previously it was always set to Mime::SET, which created dependency on Action Pack. In order to remove this dependency, Mime::SET is used only if ActionController is loaded.
* | | | Remove Mime::Type translations from Action ViewPiotr Sarnacki2012-08-284-11/+10
| | | | | | | | | | | | | | | | | | | | Action View should not be responsible for translating mime types. Any translation that's needed should be handled at controller level.
* | | | Deprecate mime types lookup in auto_discovery_link_tagPiotr Sarnacki2012-08-282-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | Automatically handling mime types for things other than :rss and :atom is not functionality that justifies dependency on Mime::Type from actionpack.
* | | | Remove comment about getting rid of old AV::Base.new behaviorPiotr Sarnacki2012-08-281-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've talked to José Valim, who added this comment, and there is no need to remove old API. It's good to have a simple way to instantiate ActionView::Base, by just passing view paths as a first argument, instead of constructing LookupContext and then the Renderer. [ci skip]
* | | | Remove stubs from LogSubscriber testsPiotr Sarnacki2012-08-281-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We can use another way to instantiate ActionView::Base, by passing renderer as a first option. Thanks to that we can just pass prefixes to LookupContext instead stubbing them on the controller. This is also good, because that kind of API is used in Rails code.
* | | | Move action_controller/vendor/html-scanner to action_viewPiotr Sarnacki2012-08-2816-27/+32
| | | | | | | | | | | | | | | | | | | | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
* | | | Deprecate ActionController::RecordIdentifierPiotr Sarnacki2012-08-282-0/+12
| | | |
* | | | Add ActionView::ModelNamingPiotr Sarnacki2012-08-283-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's just a duplicate of ActionController::ModelNaming. These are just a simple helpers for decoupling Active Model, so it does not make sense to extract it to Active Support, but the point is to decouple also Action View and Action Pack
* | | | Move ActionController::RecordIdentifier to ActionViewPiotr Sarnacki2012-08-287-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round.
* | | | Remove dependency on actionpack in ActionView::AssetPathsPiotr Sarnacki2012-08-284-6/+20
|/ / / | | | | | | | | | | | | | | | Since Action View should not depend on actionpack, it's best to delegate invalid_asset_host! to controller and just rely on such simple contract instead of raising ActionController::RoutingError directly.
* | | Create variable only in the test that uses itCarlos Antonio da Silva2012-08-251-3/+3
| | | | | | | | | | | | | | | Instead of building a Blog::Post instance for every test in form helper tests, just build it in the test that uses it.
* | | correct handling of date selects when using both disabled and discard optionsVasiliy Ermolovich2012-08-253-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we should take disabled option not only from `html_options` hash but from `options` hash too like `build_select` method does it. So datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true }) datetime_select("post", "updated_at", :discard_minute => true , :disabled => true) both these variants work now closes #7431
* | | Extract ActiveRecord::SessionStore from RailsPrem Sichanugrist2012-08-243-297/+4
| | | | | | | | | | | | | | | This functionality will be available from gem `active_record-session_store` instead.
* | | copy edit the time_ago_in_words helper docsVijay Dev2012-08-231-4/+4
| | |
* | | Merge pull request #7398 from iamvery/time_ago_in_words-docsVijay Dev2012-08-221-0/+7
|\ \ \ | |/ / |/| | Extended documentation for `time_ago_in_words` helper
| * | Extended documentation for `time_ago_in_words` helperJay Hayes2012-08-201-0/+7
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-221-4/+4
|\ \ \
| * | | Make a doc example output in match actual outputEvan Farrar2012-08-151-4/+4
| | | | | | | | | | | | | | | | | | | | Make doc output in grouped_options_for_select divider example match actual output. The options groups were in backwards order of actual.
* | | | Get rid of config.preload_frameworks in favor of config.eager_load_namespacesJosé Valim2012-08-216-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The new option allows any Ruby namespace to be registered and set up for eager load. We are effectively exposing the structure existing in Rails since v3.0 for all developers in order to make their applications thread-safe and CoW friendly.
* | | | Add CHANGELOG entry for #7410Rafael Mendonça França2012-08-211-0/+5
| | | |
* | | | option_tags coerced to "" instead of nilSandeep2012-08-212-0/+13
| | | |
* | | | Merge pull request #7406 from janko-m/documentation_fixesRafael Mendonça França2012-08-212-45/+45
|\ \ \ \ | | | | | | | | | | Fixed some documentation mistakes
| * | | | Fix documentation mistakesJanko Marohnić2012-08-212-45/+45
| | | | |
* | | | | Make sure :via works with mountPratik Naik2012-08-202-2/+12
| | | | |
* | | | | Access @rs only through attr_accessortomykaira2012-08-201-11/+11
|/ / / /
* | / / Added X-Content-Type-Options to the header defaults.Jim Jones2012-08-183-4/+8
| |/ / |/| | | | | | | | With a value of "nosniff", this prevents Internet Explorer from MIME-sniffing a response away from the declared content-type.
* | | Fix slightly broken Markdown syntax in actionpack/CHANGELOG.mdhollowspace2012-08-171-10/+10
| | |
* | | Remove the active_model require from action_dispatch.Rafael Mendonça França2012-08-161-1/+0
|/ / | | | | | | | | | | | | | | Since we removed the ActiveModel dependenxy from ActionPack at 166dbaa7526a96fdf046f093f25b0a134b277a68 we don't need to require it anymore. Closes #7370
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-162-3/+15
|\ \
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 09:52:36 +0000