Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push model and class handling to a helper builder object | Aaron Patterson | 2014-05-12 | 1 | -36/+48 |
| | |||||
* | adding a method to handle strings using the same api | Aaron Patterson | 2014-05-12 | 1 | -22/+32 |
| | |||||
* | break each polymorphic type to it's own method | Aaron Patterson | 2014-05-12 | 1 | -24/+81 |
| | |||||
* | remove dead code | Aaron Patterson | 2014-05-12 | 1 | -12/+0 |
| | |||||
* | only test `persisted?` on the record once | Aaron Patterson | 2014-05-12 | 1 | -3/+7 |
| | | | | | also avoid the case of calling `persisted?` on something that doesn't respond to it | ||||
* | only send options if there are any options | Aaron Patterson | 2014-05-12 | 1 | -5/+7 |
| | |||||
* | remove should_pop variable | Aaron Patterson | 2014-05-12 | 1 | -4/+1 |
| | |||||
* | only pop records when we get an array | Aaron Patterson | 2014-05-12 | 1 | -6/+7 |
| | |||||
* | remove unnecessary array allocations | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -5/+1 |
| | |||||
* | simplified route method name generation | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -27/+17 |
| | |||||
* | small refactoring | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -6/+2 |
| | |||||
* | pulling helpermethods up before refactoring | Coraline Ada Ehmke + Aaron Patterson | 2014-05-12 | 1 | -20/+46 |
| | |||||
* | push all is_a tests up, always pass options to the named route | Aaron Patterson | 2014-05-12 | 1 | -28/+27 |
| | |||||
* | pull nil checks up | Aaron Patterson | 2014-05-12 | 1 | -3/+5 |
| | |||||
* | skip another Array is_a check | Aaron Patterson | 2014-05-12 | 1 | -4/+6 |
| | |||||
* | only do the Array is_a check once | Aaron Patterson | 2014-05-12 | 1 | -4/+3 |
| | |||||
* | we always convert this variable to a list, so we can remove the unconversion | Aaron Patterson | 2014-05-12 | 1 | -1/+0 |
| | |||||
* | record as a hash is not possible, so rm branch | Aaron Patterson | 2014-05-12 | 1 | -2/+0 |
| | |||||
* | stop popping in build_named_route_call | Aaron Patterson | 2014-05-12 | 1 | -4/+3 |
| | |||||
* | remove extract_record since we have extracted the list | Aaron Patterson | 2014-05-12 | 1 | -12/+1 |
| | |||||
* | always pass a list to build_named_route_call | Aaron Patterson | 2014-05-12 | 1 | -10/+19 |
| | |||||
* | add a test for passing two models to the polymorphic_url method | Aaron Patterson | 2014-05-12 | 1 | -1/+1 |
| | |||||
* | reduce conditionals in url_for | Aaron Patterson | 2014-05-12 | 1 | -3/+6 |
| | |||||
* | extract route key translation to a method and reuse it | Aaron Patterson | 2014-05-12 | 1 | -17/+14 |
| | |||||
* | make the module version quack the same as the instance | Aaron Patterson | 2014-05-12 | 1 | -3/+10 |
| | | | | this way we can stop checking respond_to on every call. | ||||
* | Hash#except is expensive and this is a hotspot, so use a dup + delete | Aaron Patterson | 2014-05-12 | 1 | -1/+2 |
| | |||||
* | Remove redundant tests method. | Guo Xiang Tan | 2014-05-11 | 1 | -2/+0 |
| | |||||
* | docs, make `ActionNotFound` public API. [ci skip] | Yves Senn | 2014-05-11 | 1 | -1/+2 |
| | | | | | | | | | This is a follow up to #15058. This exception is regularly raised during development. This means it will enter the user realm. We should provide an API page to show that this exception is public API. /cc @schneems | ||||
* | adding complete message in documentation [ci skip] | Gaurav Sharma | 2014-05-11 | 1 | -3/+4 |
| | |||||
* | Always use the provided port for protocol relative urls | Andrew White | 2014-05-11 | 3 | -0/+20 |
| | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided. | ||||
* | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵ | Guilherme Cavalcanti | 2014-05-11 | 2 | -2/+12 |
| | | | | relative URL. | ||||
* | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-05-10 | 1 | -1/+22 |
|\ | |||||
| * | copy edits [ci skip] | Vijay Dev | 2014-05-10 | 1 | -8/+8 |
| | | |||||
| * | [ci skip] doc Http::Headers methods | schneems | 2014-05-09 | 1 | -1/+17 |
| | | |||||
| * | copy edits [ci skip] | Vijay Dev | 2014-05-08 | 1 | -2/+1 |
| | | |||||
| * | [ci skip] document ActionDispatch::HTTP::Headers | schneems | 2014-05-07 | 1 | -0/+6 |
| | | |||||
* | | skip dealing with params if none are provided | Aaron Patterson | 2014-05-09 | 1 | -4/+11 |
| | | | | | | | | | | | | | | | | | | | | | | This lets us avoid 1. A slow call to Hash#slice 2. An is_a? test 3. Extra hash allocations (from slice) 4. String allocations etc. | ||||
* | | don't mutate the options hash, so we don't have to dup | Aaron Patterson | 2014-05-09 | 1 | -4/+3 |
| | | | | | | | | avoids extra hash allocations on each call | ||||
* | | use unless and || since these options are boolean | Aaron Patterson | 2014-05-09 | 1 | -1/+1 |
| | | |||||
* | | just call the method and assert the return value | Aaron Patterson | 2014-05-09 | 1 | -8/+1 |
| | | | | | | | | do not test internals | ||||
* | | HTTP::Headers#key? correctly converts | schneems | 2014-05-07 | 2 | -1/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if you were looking for a given key, the header may incorrectly tell you that it did not exist even though it would return a valid value: ```ruby env = { "CONTENT_TYPE" => "text/plain" } headers = ActionDispatch::Http::Headers.new(env) headers["Content-Type"] # => "text/plain" headers.key?("Content-Type") # => false ``` This PR fixes that behavior by converting the key before checking for presence | ||||
* | | Merge pull request #14945 from tomkadwill/form_authenticity_param_refactor | Rafael Mendonça França | 2014-05-06 | 3 | -6/+34 |
|\ \ | | | | | | | Moved 'params[request_forgery_protection_token]' into its own method and... | ||||
| * | | Moved 'params[request_forgery_protection_token]' into its own method and ↵ | Tom Kadwill | 2014-05-06 | 3 | -6/+34 |
| | | | | | | | | | | | | improved tests. | ||||
* | | | Only accept actions without File::SEPARATOR in the name. | Rafael Mendonça França | 2014-05-06 | 2 | -4/+41 |
|/ / | | | | | | | | | | | | | | | | | This will avoid directory traversal in implicit render. Fixes: CVE-2014-0130 Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
* | | Get rid of extra local var that does not add to the logic | Carlos Antonio da Silva | 2014-05-05 | 1 | -2/+2 |
| | | | | | | | | There are too many "action name" variables around the process method. | ||||
* | | Improve CHANGELOG entry | Rafael Mendonça França | 2014-05-04 | 1 | -2/+2 |
| | | |||||
* | | Use assert_raises | Rafael Mendonça França | 2014-05-04 | 1 | -3/+1 |
| | | |||||
* | | Do not use short-circuit return | Rafael Mendonça França | 2014-05-04 | 1 | -2/+3 |
| | | |||||
* | | Merge pull request #11166 from xavier/callable_constraint_verification | Rafael Mendonça França | 2014-05-04 | 3 | -0/+29 |
|\ \ | | | | | | | | | | | | | | | | | | | Callable route constraint verification Conflicts: actionpack/CHANGELOG.md | ||||
| * | | Verify that route constraints respond to the expected messages instead of ↵ | Xavier Defrang | 2013-06-28 | 3 | -0/+29 |
| | | | | | | | | | | | | silently failing to enforce the constraint |