| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
|
| |
| |
| |
| | |
ActionView::Helpers::FormTagHelper were deprecated.
|
| |
| |
| |
| | |
ActionView::Helpers::JavascriptHelper were deprecated.
|
| |
| |
| |
| | |
ActionView::Helpers::UrlHelper#link_to and #button_to were deprecated.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is
a bit sparse. This class is useful when you're writing tests, as often you want to assert various
things about the response that's coming back. Better docs would make this easier for people new
to testing in Rails.
I only added some descriptions for various properties that were defined, and mostly just a sentence
or two. Most of these things are familliar if you're working with HTTP, but some words is better
than no words at all.
Hopefully further commits will fix up things that aren't just documentation.
|
|\ \
| | |
| | | |
Extract ActionDispatch::Request#deep_munge
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
ActionDispatch::Request#deep_munge was introduced as a private method,
but was turned into a public one for the use of
ActionDispatch::ParamsParser.
I have extracted it into ActionDispatch::Request::Utils, so it does not
get mixed up with the Request public methods.
|
|/ |
|
|
|
|
| |
These stopped running don't know when.
But these should be running now.
|
|
|
|
|
| |
minitest/autorun required minitest/spec and we are avoiding to require
it.
|
|\
| |
| | |
Eliminate minitest warnings
|
| |
| |
| |
| | |
https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When named route that is nested is used in 3.2.13
Example `routes.rb`:
```
resources :nested do
resources :builder, :controller => 'nested/builder'
end
```
In 3.2.12 and 3.2.12 this named route would work:
```
nested_builder_path(:last_step, :nested_id => "foo")
```
Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys.
Not sure if this is exactly how the original version worked, but this fixes this use case regression.
|
|\
| |
| | |
Squishy minitest5
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit ad46884af567d6f8d6d8d777f372c39e81a560ba.
Conflicts:
actionpack/CHANGELOG.md
actionpack/lib/action_dispatch/testing/integration.rb
actionpack/test/controller/integration_test.rb
Reason: It will conflict with a lot of test cases. Better to call
`process` directly since this is a very uncommon HTTP method.
Fixes #10638.
|
|\ \
| | |
| | | |
fix rails4 regression with asset_host Proc returning nil
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 0303c2325fab253adf5e4a0b738cb469c048f008.
Conflicts:
actionpack/lib/action_controller/test_case.rb
REASON: It will conflict with a lot of test cases. Better to call
`process` directly since this is a very uncommon HTTP method.
Fixes #10638.
|
|\ \ \
| |/ /
|/| | |
add test for skip_before_filter with condition
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| | |
c43ca06ca091fc09e2c86bb051ac92b648f12b64
|
| |
| |
| |
| |
| |
| |
| | |
The nested `if` was replaced by using `presence` which takes account for
the given hash when it is `nil` or when it is empty. The `else` was
removed because what it was doing was to assign to `env[KEY]` the
value it already had.
|
| | |
|
|\ \
| | |
| | | |
Can you improve the commit message a little bit? It's good to describe why the change is happening.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
[ci skip] document protect_against_forgery? method
|
| | | |
|
|\ \ \
| | | |
| | | | |
remove variable and fix warning
|
| | | | |
|
|/ / / |
|
|/ /
| |
| |
| | |
for their status, by default, not the message from the underlying exception
|
| |
| |
| |
| | |
https://github.com/rails/etagger/pull/3
|
|\ \
| | |
| | | |
Allow numbers in partial name for digesting
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add failing test for template with number at the end
Use \w for RENDER_DEPENDENCY regex
Spacing
Add CHANGELOG entry
|
|\ \ \
| |/ /
|/| | |
Instrument template compilation
|
| | | |
|
|\ \ \
| |_|/
|/| | |
use canonical #controller_path logic in controller test cases
|
| | | |
|
| | | |
|
|/ / |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
A regression was introduced in 5b3bb6, generating route from within an
engine to an another engine resulted in prefixing a path with the
SCRIPT_NAME value.
The regression was caused by the fact that SCRIPT_NAME should be
appended only if it's the SCRIPT_NAME for the application, not if it's
SCRIPT_NAME from the current engine.
closes #10409
|
|\
| |
| | |
Add styling to h1 for default rescue layout
|
| | |
|
|/ |
|