aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Fix handling of positional url helper arguments when format is falseTatiana Soukiassian2014-12-133-2/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no need to subtract one from the path_params size when there is no format parameter because it is not present in the path_params array. Fixes #17819.
* | | | Merge pull request #18006 from sikachu/add-params-to_unsafe_hRafael Mendonça França2014-12-122-0/+12
|\ \ \ \ | | | | | | | | | | Add AC::Parameters#to_unsafe_h
| * | | | Add AC::Parameters#to_unsafe_hPrem Sichanugrist2014-12-122-0/+12
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As suggested in #16299([1]), this method should be a new public API for retrieving unfiltered parameters from `ActionController::Parameters` object, given that `Parameters#to_hash` will no longer work in Rails 5.0+ as we stop inheriting `Parameters` from `Hash`. [1]: https://github.com/rails/rails/pull/16299#issuecomment-50220919
* / / / Make AC::Params.permit_all_parameters thread safePrem Sichanugrist2014-12-121-1/+10
|/ / / | | | | | | | | | | | | | | | | | | As discussed in #16299[1], this attribute is not thread safe and could potentially create a security issue. [1]: https://github.com/rails/rails/pull/16299#discussion_r15424533
* | | Only check that it is a Rails application onceRafael Mendonça França2014-12-081-5/+7
| | | | | | | | | | | | Also avoid using try since is_a? is faster for this case.
* | | Mounted Rack apps should have default named routes based on app nameT.J. Schuck2014-12-062-14/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression in 4.2.0 from 4.1.8. https://github.com/rails/rails/pull/17823 fixed a similar regression regarding _explicitly_ named routes for a mounted Rack app, but there was another regression for the default value. With a route like: Rails.application.routes.draw do mount Mountable::Web, at: 'some_route' end The "Prefix" column of rake routes gives the following: - 4.1.8: mountable_web - 4.2.0.beta1-4: [nothing] - 4.2.0.rc1: [nothing] - 4.2.0.rc2: some_route <- regression This fixes the default to go back to being based off the name of the class like the docs specify: https://github.com/rails/rails/blob/785d04e3109f69d0b9b9f4732179592f0ef04e52/actionpack/lib/action_dispatch/routing/mapper.rb#L558-L560 Explicitly named routes still work correctly per https://github.com/rails/rails/pull/17823: Rails.application.routes.draw do mount Mountable::Web, at: 'some_route', as: 'named' end - 4.1.8: named - 4.2.0.beta1-4: [nothing] - 4.2.0.rc1: [nothing] - 4.2.0.rc2: named
* | | remove unused `#optional_parts`Sergey Alekseev2014-12-051-4/+0
| | | | | | | | | | | | | | | This method was copied from journey at https://github.com/rails/rails/commit/56fee39c392788314c44a575b3fd66e16a50c8b5#diff-2cfaf53c860732fea8689d6f2002594bR78. `grep -nr 'optional_parts' .`
* | | remove unused `#generalized_table`Sergey Alekseev2014-12-051-45/+0
| | | | | | | | | | | | This method wass copied from journey at https://github.com/rails/rails/commit/56fee39c392788314c44a575b3fd66e16a50c8b5#diff-d89de8881fc4b9f10cb3e4fc7b2463f3R53. However it looks the method was unused in journey at those point as well.
* | | Typo: Hello = Guten Tag (in German)Tu Hoang2014-12-052-3/+3
| | |
* | | We don't need to call to_sym. Just compare the stringRafael Mendonça França2014-12-041-1/+1
| | |
* | | Merge pull request #17792 from rockrep/masterRafael Mendonça França2014-12-042-1/+11
|\ \ \ | | | | | | | | | | | | allow 'all' for :domain option in addition to :all
| * | | allow 'all' for :domain option in addition to :allrockrep2014-11-262-1/+11
| | | |
* | | | remove unused #await_closeSergey Alekseev2014-12-041-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The method was added in https://github.com/rails/rails/commit/30d21dfcb7fafe49b3805b8249454485a90097b6#diff-5055d9f16b442adb1d2f0f65903a196bR141. With the method call in https://github.com/rails/rails/commit/30d21dfcb7fafe49b3805b8249454485a90097b6#diff-cc7bb557df2247c0a42bc180fdb6eb05R47. Later one more method call was added in https://github.com/rails/rails/commit/401787db4bc428dce88b04e343a64c6a6c3b681c#diff-cc7bb557df2247c0a42bc180fdb6eb05R183. And both method calls were deleted in https://github.com/rails/rails/commit/3df07d093a1e4207caa63fd2e3b67599211f5800#diff-cc7bb557df2247c0a42bc180fdb6eb05L47 and https://github.com/rails/rails/commit/3df07d093a1e4207caa63fd2e3b67599211f5800#diff-cc7bb557df2247c0a42bc180fdb6eb05L189. Just do `grep -nr 'await_close' .`.
* | | | Remove "rescue" clause around "require 'openssl'"claudiob2014-12-031-10/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some `require 'openssl'` statements were surrounded by `rescue` blocks to deal with Ruby versions that did not support `OpenSSL::Digest::SHA1` or `OpenSSL::PKCS5`. [As @jeremy explains](https://github.com/rails/rails/commit/a6a0904fcb12b876469c48b1c885aadafe9188cf#commitcomment-8826666) in the original commit: > If jruby didn't have jruby-openssl gem, the require wouldn't work. Not sure whether either of these are still relevant today. According to the [release notes for JRuby 1.7.13](http://www.jruby.org/2014/06/24/jruby-1-7-13.html): > jruby-openssl 0.9.5 bundled which means the above `rescue` block is not needed anymore. All the Ruby versions supported by the current version of Rails provide those OpenSSL libraries, so Travis CI should also be happy by removing the `rescue` blocks. --- Just to confirm, with JRuby: $ ruby --version #=> jruby 1.7.16.1 (1.9.3p392) 2014-10-28 4e93f31 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64] $ irb irb(main):001:0> require 'openssl' #=> true irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1 irb(main):003:0> OpenSSL::PKCS5 # => OpenSSL::PKCS5 And with Ruby 2.1: $ ruby --version #=> ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0] $ irb irb(main):001:0> require 'openssl' #=> true irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1 irb(main):003:0> OpenSSL::PKCS5 #=> OpenSSL::PKCS5
* | | | Fix "nonexistent" typo in testsMelissa Xie2014-12-021-2/+2
| | | |
* | | | Action View is needed for DebugExceptionsRafael Mendonça França2014-12-021-0/+2
| | | | | | | | | | | | | | | | We should remove this dependency later.
* | | | Merge pull request #17873 from kirs/refactor-debug-erbRafael Mendonça França2014-12-024-23/+54
|\ \ \ \ | | | | | | | | | | Refactor debug view
| * | | | Refactor debug viewKir Shatrov2014-12-024-23/+54
| | | | | | | | | | | | | | | Avoid logic in ERB and use helpers
* | | | | Merge pull request #17862 from lucasmazza/lm-hide-actionRafael Mendonça França2014-12-022-1/+4
|/ / / / | | | | | | | | | | | | `_generate_paths_by_default` should always be private.
* | | | Merge pull request #17827 from rkh/rkh-fix-or-patternAaron Patterson2014-12-012-0/+7
|\ \ \ \ | | | | | | | | | | Fix OR in Journey patterns
| * | | | make OR in journey patterns compile to a valid regular expressionKonstantin Haase2014-11-292-0/+7
| | | | |
* | | | | Pretty-print request params on exception pageKir Shatrov2014-12-012-1/+9
| | | | |
* | | | | Merge pull request #17823 from byroot/fix-mount-rack-apps-with-asSean Griffin2014-11-292-8/+2
|\ \ \ \ \ | | | | | | | | | | | | Pure rack apps can be mounted with a name
| * | | | | Pure rack apps can be mounted with a nameJean Boussier2014-11-292-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/commit/9b15828b5c347395b42066a588c88e5eb4e72279#commitcomment-8764492
* | | | | | Pass symbol as an argument instead of a blockErik Michaels-Ober2014-11-2914-25/+23
| | | | | |
* | | | | | Bump required Ruby version to 2.1.0claudiob2014-11-281-1/+1
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [This article](http://weblog.rubyonrails.org/2014/8/20/Rails-4-2-beta1/#maintenance-consequences-and-rails-5-0) states that: > Rails 5.0 is in most likelihood going to target Ruby 2.2. Before the exact minimum version is fully decided, @arthurnn [suggests](https://github.com/rails/rails/pull/17830#issuecomment-64940383) that **at least** version 2.1.0 **must** be required by the `gemspec` files.
* | | | | Start Rails 5 development :tada:Rafael Mendonça França2014-11-282-413/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | We will support only Ruby >= 2.1. But right now we don't accept pull requests with syntax changes to drop support to Ruby 1.9.
* | | | Bump to rack 1.6.0.beta2Santiago Pastorino2014-11-271-1/+1
| | | |
* | | | Merge pull request #17803 from sadfuzzy/patch-2Abdelkader Boudih2014-11-271-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | Update cookies.rb Conflicts: actionpack/lib/action_dispatch/middleware/cookies.rb
* | | | Merge pull request #17186 from tgxworld/header_authentication_tokenMatthew Draper2014-11-273-4/+37
|\ \ \ \ | | | | | | | | | | | | | | | Allow authentication header to not have to specify 'token=' key.
| * | | | Allow authentication header to not have to specify 'token=' key.Guo Xiang Tan2014-10-102-4/+30
| | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/rails/rails/issues/17108.
* | | | | Refactor nested ifBruno Sutic2014-11-261-5/+3
| | | | |
* | | | | Remove extra empty lineArtur Cygan2014-11-261-1/+0
| | | | |
* | | | | :scissors:Rafael Mendonça França2014-11-261-1/+1
| | | | |
* | | | | getting the location of the serverdilpreet922014-11-261-2/+2
| | | | |
* | | | | Merge pull request #17728 from jcutrell/jcutrell/docs-to_session_value-for-prRafael Mendonça França2014-11-251-3/+6
|\ \ \ \ \ | | | | | | | | | | | | Adding simple docs for ActionDispatch::Flash::FlashHash#to_session_value
| * | | | | adding nodoc to private methodsJonathan Cutrell2014-11-231-2/+2
| | | | | |
| * | | | | Adding simple docs for ActionDispatch::Flash::FlashHash#to_session_valueJonathan Cutrell2014-11-231-1/+4
| | | | | |
* | | | | | Merge pull request #17733 from yuki24/do-not-rescue-exception-in-params-parserRafael Mendonça França2014-11-252-1/+11
|\ \ \ \ \ \ | | | | | | | | | | | | | | Do not rescue Exception in ActionDispatch::ParamsParser
| * | | | | | Do not rescue Exception in ParamsParserYuki Nishijima2014-11-232-1/+11
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | Unlike ShowExceptions or PublicExceptions, ParamsParser shouldn't transform exceptions like Interrupt and NoMemoryError into ParserError.
* | | | | | Use released rails-dom-testingRafael Mendonça França2014-11-251-1/+1
| | | | | |
* | | | | | CSS fix for the router visualizerBruno Sutic2014-11-251-4/+0
| | | | | |
* | | | | | Merge pull request #17753 from gsamokovarov/dont-center-routing-tableSantiago Pastorino2014-11-251-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Don't center the routes table on routing errors
| * | | | | | Don't center the routes table on routing errorsGenadi Samokovarov2014-11-241-1/+1
| | | | | | |
* | | | | | | Merge branch 'nil_script_name'Santiago Pastorino2014-11-252-1/+8
|\ \ \ \ \ \ \
| * | | | | | | Add regression test case to ensure script_name as nil is not used anymore in ↵Santiago Pastorino2014-11-251-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | url_for
| * | | | | | | sets script_name to always be a string.JONBRWN2014-11-251-1/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #17615 #17616 when script_name is nil in the options hash, script_name is set to nil. options = {script_name: nil} script_name = options.delete(:script_name) {‘’} # => nil Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | | | | | | Changelog formatSean Griffin2014-11-241-2/+3
| | | | | | |
* | | | | | | Merge branch 'deprecate-string-options-in-url-helpers'Sean Griffin2014-11-243-1/+43
|\ \ \ \ \ \ \
| * | | | | | | Deprecate string options in URL helpersMelanie Gilman2014-11-243-1/+43
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/issues/16958 [Byron Bischoff & Melanie Gilman]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 13:15:35 +0000