aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | Nobody sucks so nobody should call this awful method nameRafael Mendonça França2014-08-121-1/+1
|/ / / / / / / /
* | | | | | | | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent!Akira Matsuda2014-08-121-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework.
* | | | | | | | Merge pull request #16440 from tgxworld/pass_log_in_blockSantiago Pastorino2014-08-091-4/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Pass block for logging.
| * | | | | | | | Pass block for logging.Guo Xiang Tan2014-08-091-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* | | | | | | | | Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option"Santiago Pastorino2014-08-083-30/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!!
* | | | | | | | | Add config option for cookies digestŁukasz Strzałkowski2014-08-083-2/+30
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256'
* | | | | | | | Merge pull request #16427 from ryandao/full_stack_source_extractGuillermo Iguaran2014-08-089-69/+114
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Full stack source extract
| * | | | | | | | Update actionpack CHANGELOGRyan Dao2014-08-081-0/+5
| | | | | | | | |
| * | | | | | | | Retrieve source code for the entire stack traceRyan Dao2014-08-088-69/+109
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors.
* / / / / / / / Fixes to TestCaseTest.Guo Xiang Tan2014-08-081-4/+5
|/ / / / / / /
* | | | | | | Fix spelling.Guo Xiang Tan2014-08-071-1/+1
| | | | | | |
* | | | | | | Remove ActionController::RaiseActionExceptions.Guo Xiang Tan2014-08-071-34/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The latest modification to the code was done in https://github.com/rails/rails/commit/5e3517ea. In Rails 3.2, `ActionController#rescue_action` was deprecated and `rescue_action_without_handler` is no longer being used.
* | | | | | | refactor Redirecting so we do not need a controller instanceAaron Patterson2014-08-062-10/+7
| | | | | | |
* | | | | | | call the routes method on enginesAaron Patterson2014-08-051-74/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | if we access the instance, we can free up lots of codes
* | | | | | | a rails application should be an engine subclassAaron Patterson2014-08-051-1/+1
| | | | | | |
* | | | | | | no reason to lazily instantiate the routesAaron Patterson2014-08-051-45/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | especially if you're just going to add a call two lines down that populates the cache. common.
* | | | | | | just assign the instance variables on the testAaron Patterson2014-08-051-7/+3
| | | | | | |
* | | | | | | avoid testing only_pathAaron Patterson2014-08-042-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we know that this call only wants the path returned, so lets call a method that returns the path.
* | | | | | | Regenerate sid when sbdy tries to fixate the sessionSantiago Pastorino2014-08-042-12/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed broken test. Thanks Stephen Richards for reporting.
* | | | | | | Using no_result_var in Journey's parser generatorJack Danger Canty2014-08-032-43/+33
| |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the generated parser had an intermediate local variable `result` that really useful if you're building up a stateful object but Journey always discards the result argument to the reduce functions. This produces a simpler parser for anybody who actually wants to read the thing. Sadly, there's no real performance speedup with this change.
* | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-08-021-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/testing.md
| * | | | | | copy edits[ci skip]Vijay Dev2014-08-021-3/+1
| | | | | | |
| * | | | | | Performed Returns true if redirect/render has happenedGaurish Sharma2014-07-191-1/+4
| | | | | | |
* | | | | | | just set the host, no need for another hash allocation / merge!Aaron Patterson2014-08-011-1/+1
| | | | | | |
* | | | | | | always return a string from find_script_nameAaron Patterson2014-08-012-7/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | this allows us to avoid nil checks on the return value
* | | | | | | use `get` instead of accessing the named routes internalsAaron Patterson2014-07-311-1/+1
| | | | | | |
* | | | | | | invert check so we fail fasterAaron Patterson2014-07-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | there's no reason to to_sym the string if it doesn't match the regexp anyway
* | | | | | | do a hash lookup for collision detectionAaron Patterson2014-07-312-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | hash lookup should be faster than searching an array.
* | | | | | | Realign assignments :scissors:Carlos Antonio da Silva2014-07-311-5/+5
| | | | | | |
* | | | | | | Do not reassign variable when mutation is happeningCarlos Antonio da Silva2014-07-311-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods mutate the path variable/argument so there is no need to reassign it every time.
* | | | | | | Only concatenate path if it was given rather than converting blindlyCarlos Antonio da Silva2014-07-311-1/+1
| | | | | | |
* | | | | | | Rename variable to better show its intentCarlos Antonio da Silva2014-07-311-12/+12
| | | | | | |
* | | | | | | Simplify conditionalCarlos Antonio da Silva2014-07-311-3/+2
| | | | | | |
* | | | | | | Push options check up so we can simplify internal methodsCarlos Antonio da Silva2014-07-311-13/+10
| | | | | | |
* | | | | | | Simplify code branch, remove #tapCarlos Antonio da Silva2014-07-311-7/+6
| | | | | | |
* | | | | | | Avoid a new hash objectCarlos Antonio da Silva2014-07-311-1/+1
| | | | | | |
* | | | | | | Remove unnecessary call to #tapCarlos Antonio da Silva2014-07-311-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not storying the RouteSet instance anywhere as the other examples in the file, so no need to use #tap.
* | | | | | | remove useless deupAaron Patterson2014-07-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | every call to default_resources_path_names allocates a new hash, no need to dup
* | | | | | | push options inside the scope objectAaron Patterson2014-07-301-4/+9
| | | | | | |
* | | | | | | turn scope in to a linked listAaron Patterson2014-07-301-15/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | this makes scope rollback much easier
* | | | | | | remove alias_method_chainAaron Patterson2014-07-301-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | we can `super` in to the previous implementation.
* | | | | | | avoid instrospection on the moduleAaron Patterson2014-07-301-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we already know what helpers are path helpers, so just iterate through that list and define the helpers with warnings
* | | | | | | fix variable nameAaron Patterson2014-07-301-3/+3
| | | | | | |
* | | | | | | split path_helpers and url_helpersAaron Patterson2014-07-301-18/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this lets us avoid hard coding a regexp for separating path and url helpers in the clear! method.
* | | | | | | `add` will remove the method if it exists alreadyAaron Patterson2014-07-301-1/+0
| | | | | | |
* | | | | | | Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-304-51/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
* | | | | | | Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
* | | | | | | oops! :bomb:Aaron Patterson2014-07-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | use helpers.include? so we don't get any false positives
* | | | | | | ask the named routes collection if the route is definedAaron Patterson2014-07-292-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we should not be accessing internals to figure out if a method is defined.
* | | | | | | helpers should be a Set so it doesn't grow unboundedAaron Patterson2014-07-291-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since helpers is a set, we can be confident about when to remove methods from the module.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 06:43:05 +0000