Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | disconnect path from the instance | Aaron Patterson | 2014-05-29 | 1 | -6/+6 | |
| | | | ||||||
* | | | reuse the ast we already made | Aaron Patterson | 2014-05-29 | 1 | -9/+10 | |
| | | | ||||||
* | | | use a parser to extract the group parts from the path | Aaron Patterson | 2014-05-29 | 3 | -5/+9 | |
| | | | ||||||
* | | | pass the parsed parameters through the methods so we don't reparse or | Aaron Patterson | 2014-05-29 | 1 | -38/+34 | |
| | | | | | | | | | | | | require caching code | |||||
* | | | Merge branch 'master' into mapper | Aaron Patterson | 2014-05-29 | 6 | -26/+27 | |
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Update url to rake docs [ci skip] Name#model_name doesn't return a String object Result sets never override a model's column type [ci skip] Make last note show up in postgresql guide. Add missing `:param` option from the docs for Mapper#match [ci skip] Option discovered by @zackperdue in #14741, implemented in #5581. Add @senny's changed from #14741, including code font for `resources` options, and wrapped to 80 chars. [ci skip] Use github url for homepage of log4r [ci skip] Remove TODO. Ensure we always use instances of the adapter specific column class Fix indentation from 1b4b26f [ci skip] [ci skip] Improve form_helpers.md guide. Clear inflections after test. Remove unnecessary include for integration tests. Added documentation for the :param option for resourceful routing | |||||
| * | | Update url to rake docs [ci skip] | Zachary Scott | 2014-05-29 | 1 | -1/+1 | |
| | | | ||||||
| * | | Merge pull request #15061 from tgxworld/remove_unnecessary_include | Matthew Draper | 2014-05-29 | 2 | -7/+0 | |
| |\ \ | | | | | | | | | Remove unnecessary include for integration tests. | |||||
| | * | | Remove unnecessary include for integration tests. | Guo Xiang Tan | 2014-05-11 | 2 | -7/+0 | |
| | | | | ||||||
| * | | | Add missing `:param` option from the docs for Mapper#match [ci skip] | Zachary Scott | 2014-05-29 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | Option discovered by @zackperdue in #14741, implemented in #5581. | |||||
| * | | | Merge pull request #15399 from tgxworld/remove_todo_router_test | Guillermo Iguaran | 2014-05-28 | 1 | -11/+1 | |
| |\ \ \ | | | | | | | | | | | Remove TODO. | |||||
| | * | | | Remove TODO. | Guo Xiang Tan | 2014-05-28 | 1 | -11/+1 | |
| | | | | | ||||||
| * | | | | Merge pull request #15384 from zuhao/refactor_actionpack_params_wrapper_test | Yves Senn | 2014-05-29 | 1 | -7/+19 | |
| |\ \ \ \ | | | | | | | | | | | | | Clear inflections after test. | |||||
| | * | | | | Clear inflections after test. | Zuhao Wan | 2014-05-28 | 1 | -7/+19 | |
| | | | | | | ||||||
* | | | | | | "controllers" should be a valid path name | Aaron Patterson | 2014-05-29 | 2 | -1/+11 | |
| | | | | | | ||||||
* | | | | | | controllers with slash names are also not supported, so we can reuse the message | Aaron Patterson | 2014-05-28 | 1 | -6/+2 | |
| | | | | | | ||||||
* | | | | | | only validate controllers | Aaron Patterson | 2014-05-28 | 1 | -15/+17 | |
| | | | | | | ||||||
* | | | | | | golf down a bit | Aaron Patterson | 2014-05-28 | 1 | -8/+4 | |
| | | | | | | ||||||
* | | | | | | only error handling between controller and action is the same | Aaron Patterson | 2014-05-28 | 1 | -18/+16 | |
| | | | | | | ||||||
* | | | | | | add a test for controllers without colons | Aaron Patterson | 2014-05-28 | 1 | -0/+10 | |
| | | | | | | ||||||
* | | | | | | move nil check to a method that yields to a block if the value is not nil | Aaron Patterson | 2014-05-28 | 1 | -17/+16 | |
| | | | | | | ||||||
* | | | | | | translate action / controller to the desired object | Aaron Patterson | 2014-05-28 | 1 | -12/+11 | |
| | | | | | | ||||||
* | | | | | | only one nil check on the action variable | Aaron Patterson | 2014-05-28 | 1 | -10/+8 | |
| | | | | | | ||||||
* | | | | | | change to case / when on types | Aaron Patterson | 2014-05-28 | 1 | -8/+7 | |
| | | | | | | ||||||
* | | | | | | only do one nil check against the controller | Aaron Patterson | 2014-05-28 | 1 | -9/+9 | |
| | | | | | | ||||||
* | | | | | | extract controller and action parsing to a method | Aaron Patterson | 2014-05-28 | 1 | -19/+26 | |
| | | | | | | ||||||
* | | | | | | we don't need the call to presence. that is my present, to you! | Aaron Patterson | 2014-05-28 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | swtich to returning early if to responds to call | Aaron Patterson | 2014-05-28 | 1 | -35/+32 | |
| | | | | | | ||||||
* | | | | | | return early if we have a valid controller name | Aaron Patterson | 2014-05-28 | 1 | -5/+5 | |
| | | | | | | ||||||
* | | | | | | trade 2 is_a? checks for a nil check | Aaron Patterson | 2014-05-28 | 1 | -2/+4 | |
| | | | | | | ||||||
* | | | | | | invert logic to remove nil? and exclude? checks (use ruby rather than AS ↵ | Aaron Patterson | 2014-05-28 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | when possible | |||||
* | | | | | | fewer blank? calls | Aaron Patterson | 2014-05-28 | 1 | -4/+4 | |
| | | | | | | ||||||
* | | | | | | reduce action.blank? calls | Aaron Patterson | 2014-05-28 | 1 | -4/+6 | |
| | | | | | | ||||||
* | | | | | | reduce blank? checks | Aaron Patterson | 2014-05-28 | 1 | -4/+9 | |
| | | | | | | ||||||
* | | | | | | extract controller checks to methods | Aaron Patterson | 2014-05-28 | 1 | -19/+26 | |
| | | | | | | ||||||
* | | | | | | set defaults at the top so we can avoid the ||= test | Aaron Patterson | 2014-05-28 | 1 | -6/+9 | |
| | | | | | | ||||||
* | | | | | | add a test for existing mapper functionality | Aaron Patterson | 2014-05-28 | 1 | -0/+12 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior | |||||
* | | | | | add tests for argument error cases | Aaron Patterson | 2014-05-28 | 1 | -0/+27 | |
| | | | | | ||||||
* | | | | | Merge pull request #15386 from ↵ | Santiago Pastorino | 2014-05-28 | 1 | -3/+6 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionpack_request_forgery_protection_test Avoid hardcoded `request_forgery_protection_token` value in teardown. | |||||
| * | | | | | Avoid hardcoded value in teardown. | Zuhao Wan | 2014-05-28 | 1 | -3/+6 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #15388 from zuhao/refactor_actionpack_send_file_test | Santiago Pastorino | 2014-05-28 | 1 | -2/+6 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Unregister Mime::Type in teardown. | |||||
| * | | | | | | Unregister Mime::Type in teardown. | Zuhao Wan | 2014-05-28 | 1 | -2/+6 | |
| |/ / / / / | ||||||
* | | | | | | Merge pull request #15385 from zuhao/refactor_actionpack_render_other_test | Santiago Pastorino | 2014-05-28 | 1 | -4/+7 | |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Add and remove renderer inside the test to prevent leak. | |||||
| * | | | | | Add and remove renderer inside the test to prevent leak. | Zuhao Wan | 2014-05-28 | 1 | -4/+7 | |
| |/ / / / | ||||||
* | | | | | Merge pull request #15383 from ↵ | Yves Senn | 2014-05-28 | 1 | -10/+8 | |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | zuhao/refactor_actionpack_localized_templates_test Move I18n.locale setting into setup and teardown. | |||||
| * | | | | Move I18n.locale setting into setup and teardown. | Zuhao Wan | 2014-05-28 | 1 | -10/+8 | |
| |/ / / | ||||||
* / / / | Add with_default_charset helper. | Zuhao Wan | 2014-05-28 | 1 | -12/+20 | |
|/ / / | ||||||
* | | | Deprecate all *_filter callbacks in favor of *_action callbacks | Rafael Mendonça França | 2014-05-27 | 5 | -214/+224 | |
| | | | | | | | | | | | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c | |||||
* | | | rm dead code | Aaron Patterson | 2014-05-27 | 1 | -5/+0 | |
| | | | ||||||
* | | | PARAMETERS_KEY is only used in the request, so move the constant there | Aaron Patterson | 2014-05-27 | 3 | -9/+9 | |
| | | | ||||||
* | | | Merge branch 'constraints' | Aaron Patterson | 2014-05-27 | 11 | -75/+85 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb |