aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Avoid Rack security warning no secret providedSantiago Pastorino2013-01-081-0/+2
| | | | This avoids "SECURITY WARNING: No secret option provided to Rack::Session::Cookie."
* improve StrongParameters documentation [ci skip]Francesco Rodriguez2013-01-071-8/+7
|
* access `@path` and `@routes` via reader methods in journeyGosha Arinich2013-01-072-3/+3
|
* refactor ShowExceptions' #call to use def-rescue instead of begin-rescueGosha Arinich2013-01-071-7/+4
|
* remove begin-rescue in favor of def-rescueGosha Arinich2013-01-071-10/+9
|
* Fix operators precedence issueRafael Mendonça França2013-01-061-1/+1
|
* Merge pull request #8787 from tank-bohr/masterRafael Mendonça França2013-01-061-2/+2
|\ | | | | masgn and response variable
| * return multiple assingment and response variabletank-bohr2013-01-071-2/+2
| |
* | Merge pull request #8785 from goshakkk/refactor-debug-exceptionsRafael Mendonça França2013-01-061-2/+1
|\ \ | |/ |/| Refactor DebugExceptions
| * refactor DebugExceptions by combining two conditionals into oneGosha Arinich2013-01-071-2/+1
| |
* | Reduce number of Strings a bitAkira Matsuda2013-01-072-4/+4
| |
* | Namespace HashWithIndifferentAccessAkira Matsuda2013-01-074-6/+5
|/
* Merge pull request #8783 from goshakkk/refactor-journey-routesRafael Mendonça França2013-01-061-12/+11
|\ | | | | Refactor Journey::Routes
| * refactor Journey::RoutesGosha Arinich2013-01-071-12/+11
| | | | | | | | | | * prefer do-end for multiline blocks * prefer or-equals over returns with checks
* | fix for rbxtank-bohr2013-01-071-2/+2
|/ | | | | | | | | Rubinius returns a boolean after such assingment response = (_, headers, body = @app.call(env)) see https://github.com/rubinius/rubinius/issues/2117 get rid of a local variable
* Needless requiresAkira Matsuda2013-01-062-6/+0
|
* Missing requiresAkira Matsuda2013-01-062-0/+2
|
* These are already required through AS/railsAkira Matsuda2013-01-065-6/+0
| | | | | | | * core_ext/object/blank * concern * core_ext/class/attribute * deprecation
* Rename route_wrapper partial layout to tableCarlos Antonio da Silva2013-01-062-1/+1
| | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler.
* Move table routes formatter class to the inspector and rename itCarlos Antonio da Silva2013-01-063-19/+19
| | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page.
* Merge pull request #8777 from goshakkk/delegate-classAndrew White2013-01-062-2/+2
|\ | | | | Delegate to :class rather than 'self.class'
| * delegate to :class rather than 'self.class'Gosha Arinich2013-01-062-2/+2
| |
* | Refactor the logic that checks whether or not to emit the hidden id fieldCarlos Antonio da Silva2013-01-061-7/+6
| | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects.
* | Move the hidden :id field logic to where it belongs toCarlos Antonio da Silva2013-01-061-6/+9
| | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense.
* | Eliminate the usage of parent_builder option from form_forCarlos Antonio da Silva2013-01-061-19/+15
| | | | | | | | Just use it internally from fields_for until we come up with a better solution.
* | Do not call fields_for from form_for, to avoid instantiating two buildersCarlos Antonio da Silva2013-01-062-6/+18
| |
* | Refactor to not call path.ast twiceCarlos Antonio da Silva2013-01-061-2/+3
| |
* | refactor Route#ast to use or-equals and block, instead of return with a condGosha Arinich2013-01-061-5/+4
| |
* | Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-066-38/+26
|/
* Fix documentation to content_tag_for [ci skip]Rafael Mendonça França2013-01-051-2/+2
|
* Merge pull request #8766 from jcoglan/session_token_docsAndrew White2013-01-051-7/+4
|\ | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip]
| * Remove suggestion that Procs can be used as session secrets.James Coglan2013-01-051-7/+4
| |
* | deprecate `assert_blank` and `assert_present`.Yves Senn2013-01-056-16/+16
| | | | | | | | | | They don't add any benefits over `assert object.blank?` and `assert object.present?`
* | Remove warning, remove not used variable, and make methods privateCarlos Antonio da Silva2013-01-051-3/+5
|/ | | | Warning: "shadowing outer local variable - routes".
* Close container div tag in routing error pageCarlos Antonio da Silva2013-01-051-9/+11
|
* Move style to head to make routes page valid html5Carlos Antonio da Silva2013-01-052-4/+6
|
* Action Pack changelog improvements [ci skip]Carlos Antonio da Silva2013-01-051-32/+35
|
* display mountable engine routes on RoutingError.Yves Senn2013-01-054-11/+46
|
* split formatting concerns from RoutesInspectorYves Senn2013-01-052-24/+63
|
* Rename the last occurrence of UnexpectedParametersRafael Mendonça França2013-01-051-2/+2
|
* Wrong copy and paste :bomb:Rafael Mendonça França2013-01-051-1/+1
| | | | [ci skip]
* Add documentation to raise_on_unpermitted_parameters optionRafael Mendonça França2013-01-051-2/+17
| | | | [ci skip]
* Rename the configuration to raise_on_unpermitted_parametersRafael Mendonça França2013-01-053-15/+17
| | | | Also changed the exception to UnpermittedParameters
* Ensure that raise_on_unexpected_params configuration will workRafael Mendonça França2013-01-051-9/+7
|
* Merge pull request #8752 from thomasfedb/masterRafael Mendonça França2013-01-053-6/+64
|\ | | | | Exception on unexpected params when enabled.
| * Allow developers to enable raising of exception when unexpected params are ↵Thomas Drake-Brockman2013-01-053-6/+64
| | | | | | | | provided.
* | Allow use of durations for ActionDispatch::SSL configurationAndrew White2013-01-042-1/+8
| |
* | Remove unnecessary `ERB::Util::h`Ryunosuke SATO2013-01-057-17/+17
| | | | | | | | It is automatically applied when strings is unsafe for html.
* | Suppress warning about IO#lines in Ruby 2.0Ryunosuke SATO2013-01-041-1/+1
|/ | | | actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead
* Merge pull request #8723 from goshakkk/refactor-error-pageGuillermo Iguaran2013-01-033-5/+27
|\ | | | | Move error page js into script tag