| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```ruby
require 'benchmark/ips'
Benchmark.ips do |x|
x.report("$&") {
"foo".sub(/f/) { $&.upcase }
}
x.report("block var") {
"foo".sub(/f/) {|match| match.upcase }
}
end
```
```
Calculating -------------------------------------
$& 48.658k i/100ms
block var 49.666k i/100ms
-------------------------------------------------
$& 873.156k (± 9.3%) i/s - 4.331M
block var 969.744k (± 9.2%) i/s - 4.818M
```
It's faster, and gets rid of a few "magic" global variables
|
| |\ \ \ \
| | | | |
| | | | | |
Have Bearer be valid as well
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Deprecate `assert_template` and `assigns()`.
|
| | | |/ / /
| |/| | | |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | | |
Move expectation to instance level.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
The tests would still pass if the cache call in the rendered templates were removed.
|
| | |_|/ /
|/| | |
| | | |
| | | |
| | | |
| | | | |
It's better to use Ruby methods when possible over methods defined by
Active Support because then it does not need to rely on any
dependencies.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
match method without setting `:via` option has been deprecated
fix minor typo
|
| | |/ /
|/| | |
|
| |\ \ \
| | | |
| | | | |
Remove unused code.
|
| | | | |
| | | |
| | | |
| | | | |
Code was moved into the `assign` method.
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
vngrs/remove_already_defined_methods_in_rack_request
Remove already defined methods in super class of ActionDispatch::Request class
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These methods had defined in 2004 by dhh in initial commit and `ActionDispatch::Request`
class has been inherited from `Rack::Request` class in 2009 by josh.
In 2014 these methods and more of them defined in `Rack::Request` class
so we don't need them anymore in rails codebase.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
config.static_index configures directory Index "index.html" filename
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Set `config.static_index` to serve a static directory index file not
named `index`. For example, to serve `main.html` instead of `index.html`
for directory requests, set `config.static_index` to `"main"`.
|
| |\ \ \ \
| | | | |
| | | | | |
Remove unused package tasks
|
| | |/ / /
| | | |
| | | |
| | | | |
We are using `all:build` now.
|
| |/ / /
| | |
| | |
| | | |
`head` method works similar to `render` method with `:nothing` option
|
| |\ \ \
| | | |
| | | | |
Add application/vnd.api+json alias to the JSON MIME Type.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | | |
[PoC] Stop shadowing parameters named `action`
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
vngrs/add_assertion_for_get_method_into_request_test
Add assertion for get? method into test cases
|
| | | | | | | |
|
| |/ / / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Remove broken and unused release task
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- We do release with release.rb
- There is no `rake/gemcutter`
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
add missing dot to end of the doc
|
| | |_|/ / /
|/| | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
I should have deleted this earlier with 42e66fac38b54dd53d062fb5d3376218ed2ffdae
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
if we add an else conditional to the `presence` check, we can eliminate
the second `||` branch in the caller
|
| | | | | |
| | | | |
| | | | |
| | | | | |
this way we can keep the knowledge of `env` hash keys in one place.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
spelling fix [ci skip]
example to be consistent [ci skip]
grammatical fix
typo fixes [ci skip]
|
| |\ \ \ \
| | | | |
| | | | | |
Issue#17703 Test case for tempfile attribute
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
+ To avoid regression I am adding this test case on action pack
Changed to assert from assert_equal
+ Added msg to assertion
Modified msg
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Based on #19976 and #18305.
|
| | |_|/ /
|/| | | |
|
| |\ \ \ \
| | | | |
| | | | | |
[ci skip] Remove comments about Rails 3.1
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939
where @senny said:
> From my point of view, all the docs (guides, API) are version bound.
> They should describe that version and continue to be available when newer versions are released.
> The cross referencing can be done by the interested user.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I think we are better off leaving `sudo` outside of the documented
way of installing gems (`activerecord`, `actionpack`, …).
We don’t want newbies to think that `sudo` is required or, even worse, than
they actually have to type `[sudo] gem install`.
In most scenarios, `sudo` is not needed to install gems, and people who do
need it, probably already know about it.
What do you think? :grin:
|
| | |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This moves `TemplateAssertions` out of the `test_case.rb` file and into
it's own `template_assertions` file. It still inherits from
`ActionController`.`
This is in preparation for combining the code for Integration tests and
Controller tests. This will need to be it's own file to be added to the
`requires` for Integration tests. This does not currently change ANY
behavior, just moving it for access later on.
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | | |
[ci skip]
|
