aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* adds test coverage for with_output_bufferXavier Noria2010-03-151-3/+45
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Reinstate old default_url_options method signatureJeremy Kemper2010-03-151-1/+1
|
* Add deprecation notices for <% %>.Carlhuda2010-03-1515-97/+88
| | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString.
* with_output_buffer cannot assume there's an output_bufferXavier Noria2010-03-152-1/+7
| | | | | | [#4182 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* to_str works hereJeremy Kemper2010-03-151-1/+1
|
* Don't force singularization of singleton resource names, e.g. /preferences ↵Andrew White2010-03-152-8/+15
| | | | | | [#4089 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* read_ and write_fragment cache preserve html safety yet cache strings onlyJeremy Kemper2010-03-142-6/+19
|
* There's a Ruby issue with File.basename different versions returns different ↵Santiago Pastorino2010-03-141-1/+0
| | | | things, so we shouldn't test that
* Making escaped things more readableSantiago Pastorino2010-03-143-3/+3
|
* Optimize DetailsKey generation.José Valim2010-03-141-4/+5
|
* Ensure controller filters are executed before stuff starts to happen.José Valim2010-03-133-3/+21
|
* Remove formats setters from render template, speeding up partial and ↵José Valim2010-03-131-2/+1
| | | | collection renderings.
* Made asset_tag_helper use config.perform_caching instead of ↵Denis Odorcic2010-03-122-32/+32
| | | | | | ActionController::Base.perform_caching Signed-off-by: José Valim <jose.valim@gmail.com>
* Finish cleaning up rendering stack from views and move assigns evaluation to ↵José Valim2010-03-1213-72/+66
| | | | controller (so plugins and/or controllers can overwrite just one method).
* Allow anything that responds to render to be given as :template and use ↵José Valim2010-03-127-118/+63
| | | | find_template instead of find in views.
* %= works for content_tag and does not require parenthesis on method callJosé Valim2010-03-122-49/+8
|
* Make all AP tests pass for Ruby 1.9.1.José Valim2010-03-124-17/+19
|
* Fix testJeremy Kemper2010-03-111-1/+1
|
* Write strings to fragment cache, not outputbuffersJeremy Kemper2010-03-111-1/+3
|
* Delegate #encoding to SafeBuffer tooJeremy Kemper2010-03-111-0/+4
|
* simplify alt tag generation for imagesEaden McKee2010-03-112-3/+6
| | | | | | [#2837 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* ActionController::Base.request_forgery_protection_token should actually be ↵Carl Lerche2010-03-111-1/+1
| | | | the name of the token and not true.
* Add tests for lookup context.José Valim2010-03-114-34/+203
|
* Merge branch 'master' of github.com:rails/railswycats2010-03-1014-114/+110
|\
| * Merge branch 'master' of gitproxy:rails/railsJosé Valim2010-03-1010-109/+96
| |\
| * | Optimize and clean up how details key get expired.José Valim2010-03-109-37/+71
| | |
| * | Remove uneeded methods.José Valim2010-03-102-33/+4
| | |
| * | Merge branch 'master' of gitproxy:rails/railsJosé Valim2010-03-099-159/+143
| |\ \
| * | | Clean up the API required from ActionView::Template.José Valim2010-03-095-44/+35
| | | |
* | | | Make form helpers work with <%= wycats2010-03-0910-126/+188
| | | |
* | | | Deprecate block_called_from_erb? pending a solution for getting it into appsCarlhuda2010-03-099-64/+154
| |_|/ |/| |
* | | skip_relative_url_root url_for option is deadJoshua Peek2010-03-094-7/+5
| | |
* | | Allow default_url_options to be set on route setJoshua Peek2010-03-093-0/+13
| | |
* | | RouteSet#rewrite => url_forJoshua Peek2010-03-095-7/+6
| | |
* | | Unused RouteSet#url_for is hogging a good method nameJoshua Peek2010-03-091-13/+4
| | |
* | | Move AC::UrlRewriter onto route setJoshua Peek2010-03-097-90/+76
| |/ |/|
* | Reinstate dom_id in controllers.Justin Ko2010-03-092-0/+9
| | | | | | | | | | | | | | [#3040 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* | Refactor the RouteSet so it uses a Generator object instead of one huge method.wycats2010-03-092-88/+109
| |
* | Get rid of the instance-level URL rewriterwycats2010-03-095-71/+25
|/
* Reinstate default_url_options and remove url_options= writerJeremy Kemper2010-03-083-71/+39
|
* Remove outdated, distracting commented codeJeremy Kemper2010-03-081-25/+0
|
* Now that class_attribute creates an instance method, remove it to avoid ↵wycats2010-03-081-1/+2
| | | | deprecation warnings ;)
* Simplify the action endpoint:Carlhuda2010-03-084-31/+17
| | | | | | | * Remove ActionEndpoint in favor of passing a block to MiddlewareStack * Always create a Request; the performance win of RackDelegation is around the response; the Request object hit is limited to a single object allocation * #dispatch takes a Request
* Add memoizing to AD::RequestCarlhuda2010-03-081-0/+8
|
* Require 'active_support/core_ext/hash/except' in the router.Carl Lerche2010-03-081-0/+2
|
* Clean LookupContext API.José Valim2010-03-0811-46/+43
|
* Move request forgery protection configuration to the AC config objectCarl Lerche2010-03-082-6/+44
| | | | This is an interim solution pending revisiting the rails framework configuration situation.
* Whoops. We meant to switch from returning to tap, not vice versaCarlhuda2010-03-081-1/+1
|
* Add support for mount RackApp, :at => "/sprockets" with a shorthand of mount ↵Carlhuda2010-03-084-10/+61
| | | | | | | | | | Sprockets => "/sprockets". This is different from the match syntax in that it cannot be used for controller/action and it does not assume an anchor at the end of the match. For instance, in the above example, if the client asked for "/sprockets/foo.js", the Sprockets app would have a SCRIPT_NAME of "/sprockets" and PATH_INFO of "/foo.js".
* Merge master.José Valim2010-03-0816-27/+54
|\