aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Fix nodoc commentRafael Mendonça França2012-10-071-16/+15
|
* More Ruby 1.9 hash syntax.Rafael Mendonça França2012-10-061-52/+47
|
* We don't need to check blank? here.Rafael Mendonça França2012-10-061-1/+1
| | | | | | | | Also the blank? check introduced a bug. $ rails generate model Foo blank:boolean form_for(Foo.new(:blank => true)) => ArgumentError, "First argument in form cannot contain nil or be empty"
* Update some code styles.Rafael Mendonça França2012-10-062-200/+228
| | | | | * Uses the Ruby 1.9 hash syntax * Avoid escaping " inside string using the %{} syntax
* Accept :remote as symbol in link_to optionsRiley Lynch2012-10-063-2/+21
| | | | | Accept either :remote or 'remote' in both the html_options and (url_)options hash arguments to link_to.
* can't pass :locals to #assert_template without a view test case. Closes #3415Yves Senn2012-10-063-4/+24
| | | | | | | | | | | the documentation on #assert_template states that the :locals option is only available in view test cases: # In a view test case, you can also assert that specific locals are passed # to partials: I added a warning when it's passed in an inapropriate context to prevent a NoMethodError.
* We don't need the each call since grep take a block and yield each matchRafael Mendonça França2012-10-061-1/+1
| | | | | | to the block. Thanks @tenderlove
* Allow parameter filters to match multi-parameter attributesRafael Mendonça França2012-10-052-0/+34
| | | | | | | This will make easier to permit date/time attributes generated by helpers like date_select. [Sven Schwyn + Rafael Mendonça França]
* Revert "Use flat_map { } instead of map {}.flatten"Santiago Pastorino2012-10-051-2/+2
| | | | | | | | | | | This reverts commit abf8de85519141496a6773310964ec03f6106f3f. We should take a deeper look to those cases flat_map doesn't do deep flattening. irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten => [1, 3, 1, 2] irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i} => [[1, 3], [1, 2]]
* Use flat_map { } instead of map {}.flattenSantiago Pastorino2012-10-051-2/+2
|
* Update CHANGELOG entry about rack-cache extractGuillermo Iguaran2012-10-041-3/+7
|
* config.action_dispatch.rack_cache should set explicitly to enable Rack::CacheGuillermo Iguaran2012-10-041-6/+1
|
* Remove unneeded CHANGELOG entry.Rafael Mendonça França2012-10-041-3/+0
| | | | | | | This was added in Rails 4 and we don't need changelog entries to behavior changes [ci skip]
* Merge pull request #7847 from bloudermilk/recursive_permitDavid Heinemeier Hansson2012-10-043-0/+15
|\ | | | | ActionController::Parameters#permit! is recursive
| * ActionController::Parameters#permit! is recursiveBrendan Loudermilk2012-10-043-0/+15
| |
* | Do not set removed optionRafael Mendonça França2012-10-041-1/+0
|/ | | | | Sine page caching was remove from the core we don't have the page_cache_directory anymore
* Merge pull request #7833 from frodsan/extract_ap_pages_actions_cachingRafael Mendonça França2012-10-047-1138/+58
|\ | | | | Extract AP Page and Action caching from Rails
| * add CHANGELOG entry for AP page and action caching extraction [ci skip]Francesco Rodriguez2012-10-041-0/+11
| |
| * rename page_cache_extension option to default_static_extensionFrancesco Rodriguez2012-10-033-11/+28
| |
| * extract AP Page and Action caching to actionpack-deprecated_caching gemFrancesco Rodriguez2012-10-035-1138/+30
| |
* | Add nodoc to now public fragment_name_with_digestRyan Garver2012-10-041-0/+1
| |
* | Merge branch 'master' into feature/public-fragment_name_with_digestRyan Garver2012-10-0225-209/+359
|\|
| * Failsafe exception returns text/plain.Steve Klabnik2012-10-013-3/+21
| | | | | | | | | | | | | | It's best to just return text/plain when something has gone terribly wrong. Fixes #5660.
| * Merge pull request #7708 from bdurand/optimize_log_subscribersRafael Mendonça França2012-10-012-8/+16
| |\ | | | | | | Optimize log subscribers to check if the log level is sufficient
| | * Optimize log subscribers to check if the log level is sufficient before ↵Brian Durand2012-09-302-8/+16
| | | | | | | | | | | | performing an operations.
| * | Add the CHANGELOG entry that Guillermo forgot :PSantiago Pastorino2012-10-021-0/+5
| | |
| * | Merge pull request #7794 from guilleiguaran/extract-rack-cacheSantiago Pastorino2012-10-011-1/+0
| |\ \ | | | | | | | | Use Rack::Cache middleware only if is in Gemfile
| | * | Use Rack::Cache middleware only if is in GemfileGuillermo Iguaran2012-10-011-1/+0
| | | |
| * | | prefix TemplateAssertions ivars (#7459)Yves Senn2012-10-013-23/+29
| | | |
| * | | resource and resources do no longer modify passed optionsYves Senn2012-10-013-2/+27
| | | | | | | | | | | | | | | | this is a patch for #7777.
| * | | fix cache store testSteve Klabnik2012-09-301-0/+1
| | | | | | | | | | | | | | | | Pull #7800 broke the build, this should fix it.
| * | | Add a changelog entry for asset aliasing update in sprockets-rails. Supports ↵Jeremy Kemper2012-09-301-0/+14
| | | | | | | | | | | | | | | | referencing foo.js as foo/index.js and vice versa.
| * | | Fix changelog entry about sprockets-railsGuillermo Iguaran2012-09-301-3/+2
| | | |
| * | | Whitespaces :scissors: [ci skip]Rafael Mendonça França2012-09-302-11/+14
| | | |
| * | | `assert_template` no more passing with what ever string that matches.Hugo Roque2012-09-294-5/+51
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given Im rendering an template `/layout/hello.html.erb`, assert_template was passing with any string that matches. This behavior allowed false passing like: assert_template "layout" assert_template "out/hello" Now the passing possibilities are: assert_template "layout/hello" assert_template "hello" fixing assert_template bug when template matches expected, but not ends with Cherry Pick Merge: Fixes issue #3849 assert_template false positive taking redundant test off prevening incorrect assert_template when rendering with repeated names in path updating CHANGELOG with bugfix: assert_template false passing
| * | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-288-119/+139
| |\ \ | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/asset_tag_helper.rb
| | * | update image_tag output in examples to actualNihad Abbasov2012-09-251-4/+4
| | | | | | | | | | | | [ci-skip]
| | * | update AC::ConditionalGet documentation [ci skip]Francesco Rodriguez2012-09-221-27/+31
| | | |
| | * | update AC::Caching documentation [ci skip]Francesco Rodriguez2012-09-225-87/+103
| | | |
| | * | remove AC::Parameters reference [ci skip]Francesco Rodriguez2012-09-211-1/+1
| | | |
| | * | fix typos in AC::StrongParameters documentation [ci skip]Francesco Rodriguez2012-09-211-2/+2
| | | |
| * | | move metal/caching_test into controller/caching_testFrancesco Rodriguez2012-09-272-37/+42
| | | |
| * | | Fix tests broken by adding a new instance variable to view test casesJeremy Kemper2012-09-271-0/+1
| | | |
| * | | remove method redefinition warningsRafael Mendonça França2012-09-272-2/+2
| | | | | | | | | | | | | | | | | | | | actionpack/test/template/spec_type_test.rb:32: warning: method redefined; discarding old test_spec_type_wont_match_non_space_characters actionpack/test/controller/spec_type_test.rb:30: warning: previous definition of test_spec_type_wont_match_non_space_characters was here
| * | | Is not needed to wrap name inside an array hereSantiago Pastorino2012-09-271-1/+1
| | | |
| * | | Change key not found to param not foundSantiago Pastorino2012-09-271-6/+6
| | | |
* | | | Move the CacheHelper#fragment_name_with_digest to be public so custom ↵Ryan Garver2012-09-271-11/+11
|/ / / | | | | | | | | | fragment caching can benefit from it.
* | | Also includes ConstantLookup dependency for controller and mailer testsAndy Lindeman2012-09-261-0/+1
| | |
* | | Adds missing dependency to ActionView::TestCase::BehaviorAndy Lindeman2012-09-261-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | * The module is needed for the `determine_constant_from_test_name` method. * Without it, the including class is required to also include `ActiveSupport::Testing::ConstantLookup` or a `NoMethodError` will be raised upon instantiation of that class. * Issue introduced in c0a24555f9e2749fb94efe1967cb9943db0b6a7e
* | | Merge pull request #7444 from szimek/params_parser_raises_parsing_errorAaron Patterson2012-09-263-7/+18
|\ \ \ | | | | | | | | Raise generic ParseError exception when ParamsParser fails parsing request params