aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Clear named routes when routes.rb is reloadedAndrew White2013-07-212-0/+9
| | | | | | | | Fix an issue where Journey was failing to clear the named routes hash when the routes were reloaded and since it doesn't overwrite existing routes then if a route changed but wasn't renamed it kept the old definition. This was being masked by the optimised url helpers so it only became apparent when passing an options hash to the url helper.
* Refactor to reduce number of loopsAndrew White2013-07-171-15/+25
| | | | | | Only build the missing_keys array once we have detected that there actually are missing keys by moving the check to be part of the block that performs the path substitution.
* Fix failing test missed for the past year :(Andrew White2013-07-172-3/+18
| | | | | | | | | When optimized path helpers were re-introduced in d7014bc the test added in a328f2f broke but no-one noticed because it wasn't being run by the test suite. Fix the test by checking for nil values or empty strings after the args have been parameterized.
* Added routing in test for actionpackArun Agrawal2013-07-171-2/+4
|
* Skip Rack applications and redirects when generating urlsAndrew White2013-07-166-13/+93
| | | | | | | | | | When generating an unnamed url (i.e. using `url_for` with an options hash) we should skip anything other than standard Rails routes otherwise it will match the first mounted application or redirect and generate a url with query parameters rather than raising an error if the options hash doesn't match any defined routes. Fixes #8018
* Removed unused file! Moved to actionviewArun Agrawal2013-07-131-91/+0
| | | | Removed unused file as this has been moved to actionview
* add test-case to verify `error.path` when a helper was not found.Yves Senn2013-07-121-0/+5
| | | | | This verifies the code added with: https://github.com/rails/rails/commit/99c9d18601539c7e7e87f26bb047add1f93072af
* move `MissingHelperError` out of the `ClassMethods` module.Yves Senn2013-07-123-16/+23
|
* Add documentation for add_flash_types [ci skip]Robin Dupret2013-07-101-0/+17
| | | | | Document a little bit the ActionController::Flash::add_flash_types class method.
* Remove accidentally committed vi .swp file.Marc Schütz2013-07-101-0/+0
|
* Show real LoadError on helpers requirePiotr Niełacny2013-07-105-1/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When helper try to require missing file rails will throw exception about missing helper. # app/helpers/my_helper.rb require 'missing' module MyHelper end And when we try do load helper class ApplicationController helper :my end Rails will throw exception. This is wrong because there is a helper file. Missing helper file helpers/my_helper.rb Now when helper try to require non-existed file rails will throw proper exception. No such file to load -- missing
* Merge pull request #11351 from jetthoughts/cleanup_requestRafael Mendonça França2013-07-091-1/+1
|\ | | | | Use content_length method instead of ENV['CONTENT_LENGTH'].to_i
| * Use helper method to get ENV['CONTENT_LENGTH']Paul Nikitochkin2013-07-081-1/+1
| |
* | Use Request#raw_post instead Request#bodyPaul Nikitochkin2013-07-083-1/+15
|/ | | | | | | | In order to get raw_post to be not empty after ParamsParser#parse_formatted_parameters, added rewinding of body stream input on parsing json params. Closes #11345
* Merge pull request #11313 from gsamokovarov/url-encoded-params-testRafael Mendonça França2013-07-061-25/+27
|\ | | | | Cleanup ul_encoded_params_parsing_test
| * Cleanup ul_encoded_params_parsing_testGenadi Samokovarov2013-07-051-25/+27
| |
* | Running isolated test for assertions and journeyArun Agrawal2013-07-061-1/+1
| | | | | | | | in actionpack
* | actionpack not having activerecord tests [ci skip]Arun Agrawal2013-07-061-10/+0
| |
* | Space is not required for Set-Cookie headerYamagishi Kazutoshi2013-07-053-1/+34
|/
* remove useless `env.merge!(env)` from ActionDispatch::IntegrationTest`Yves Senn2013-07-041-2/+0
|
* Missing closing + in documentation [ci skip]Edho Arief2013-07-041-1/+1
|
* Remove deprecated Rails application fallback for integration testingCarlos Antonio da Silva2013-07-022-4/+5
| | | | Set ActionDispatch.test_app instead.
* Remove deprecated constants autoloadCarlos Antonio da Silva2013-07-021-3/+0
| | | | | These constants were removed in 4b97ce5eb16cc20207516387fba98bf577e2e281, but I forgot to remove the autoload calls :sparkles:.
* use extract_options!Neeraj Singh2013-07-021-1/+1
|
* Remove `page_cache_extension` deprecated methodFrancesco Rodriguez2013-07-013-25/+4
|
* Remove deprecated constants from Action ControllerCarlos Antonio da Silva2013-07-013-12/+12
| | | | | | | | | | ActionController::AbstractRequest => ActionDispatch::Request ActionController::Request => ActionDispatch::Request ActionController::AbstractResponse => ActionDispatch::Response ActionController::Response => ActionDispatch::Response ActionController::Routing => ActionDispatch::Routing ActionController::Integration => ActionDispatch::Integration ActionController::IntegrationTest => ActionDispatch::IntegrationTest
* store a symbol directly inside DISPATCH_CACHE for extra roflscaleCharlie Somerville2013-06-301-1/+1
|
* use bytesize rather than force encodingAaron Patterson2013-06-281-2/+1
|
* writing the new body can cause the response to be committed and theAaron Patterson2013-06-281-1/+3
| | | | | | | | request thread to return up the stack before the instance variable is assigned. Synchronize so that the ivar is assigned before the other thread can activate. fixes #10984
* Re-remove deprecated API.kennyj2013-06-282-19/+0
|
* Minor changes to actionpack/actionview RakefileArun Agrawal2013-06-261-5/+1
|
* Merge pull request #11000 from sbeckeriv/accept_headerCarlos Antonio da Silva2013-06-253-1/+15
|\ | | | | | | Fix undefined method `ref' for nil:NilClass for bad accept headers
| * Fix undefined method `ref' for nil:NilClass for bad accept headersStephen Becker IV2013-06-193-1/+11
| |
* | Merge pull request #11046 from arunagw/verbose_mode_onCarlos Antonio da Silva2013-06-251-1/+1
|\ \ | | | | | | Verbose mode on when running tests
| * | Adding verbose in isolated test.Arun Agrawal2013-06-211-1/+1
| | |
* | | Fixing Issue #11083Akshay Khole2013-06-251-1/+1
| | | | | | | | | | | | Removing other occurrences of `the` appearing twice
* | | Fix shorthand routes where controller and action are in the scopeAndrew White2013-06-252-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856
* | | test-case => failingYves Senn2013-06-251-0/+13
| | |
* | | Merge pull request #11069 from ykzts/actiondispatch-ssl-secure-flag-igonore-caseGuillermo Iguaran2013-06-242-1/+15
|\ \ \ | | | | | | | | Flag cookies as secure with ignore case in ActionDispatch::SSL
| * | | Flag cookies as secure with ignore case in ActionDispatch::SSLYamagishi Kazutoshi2013-06-242-1/+15
| | | |
* | | | ActionDispatch:SSL: don't include STS header in non-https responsesGeoff Buesing2013-06-232-2/+6
|/ / /
* / / Saying gemcutter => rubygems [ci skip]Arun Agrawal2013-06-211-1/+1
|/ /
* | Don't remove trailing slash from PATH_INFO for mounted appsPiotr Sarnacki2013-06-213-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously when app was mounted as following: class Foo def call(env) [200, {}, [env['PATH_INFO']]] end end RackMountRailsBug::Application.routes.draw do mount RackTest.new => "/foo" end trailing slash was removed from PATH_INFO. For example requesting GET /foo/bar/ on routes defined above would result in a response containing "/foo/bar" instead of "/foo/bar/". This commit fixes the issue. (closes #3215)
* | Adjust changelog for AV & APŁukasz Strzałkowski2013-06-201-35/+2
| |
* | Template test were moved to AVŁukasz Strzałkowski2013-06-201-1/+1
| |
* | Remove digestor fixtures from APŁukasz Strzałkowski2013-06-2012-25/+0
| | | | | | | | They were moved to actionview/ and are not used in actionpack
* | Remove unneeded test fixtures in AVPiotr Sarnacki2013-06-20108-281/+0
| |
* | Remove unneeded filesPiotr Sarnacki2013-06-202-50/+0
| |
* | Move template tests from actionpack to actionviewPiotr Sarnacki2013-06-2053-16223/+2
| |
* | Move actionpack/lib/action_view* into actionview/libPiotr Sarnacki2013-06-2096-14646/+0
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-12 21:22:11 +0000