aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* we don't need the call to presence. that is my present, to you!Aaron Patterson2014-05-281-1/+1
|
* swtich to returning early if to responds to callAaron Patterson2014-05-281-35/+32
|
* return early if we have a valid controller nameAaron Patterson2014-05-281-5/+5
|
* trade 2 is_a? checks for a nil checkAaron Patterson2014-05-281-2/+4
|
* invert logic to remove nil? and exclude? checks (use ruby rather than AS ↵Aaron Patterson2014-05-281-6/+6
| | | | when possible
* fewer blank? callsAaron Patterson2014-05-281-4/+4
|
* reduce action.blank? callsAaron Patterson2014-05-281-4/+6
|
* reduce blank? checksAaron Patterson2014-05-281-4/+9
|
* extract controller checks to methodsAaron Patterson2014-05-281-19/+26
|
* set defaults at the top so we can avoid the ||= testAaron Patterson2014-05-281-6/+9
|
* add a test for existing mapper functionalityAaron Patterson2014-05-281-0/+12
| | | | | I'm not sure if this is actually used, but I'm adding a test to define the behavior
* add tests for argument error casesAaron Patterson2014-05-281-0/+27
|
* Merge pull request #15386 from ↵Santiago Pastorino2014-05-281-3/+6
|\ | | | | | | | | zuhao/refactor_actionpack_request_forgery_protection_test Avoid hardcoded `request_forgery_protection_token` value in teardown.
| * Avoid hardcoded value in teardown.Zuhao Wan2014-05-281-3/+6
| |
* | Merge pull request #15388 from zuhao/refactor_actionpack_send_file_testSantiago Pastorino2014-05-281-2/+6
|\ \ | | | | | | Unregister Mime::Type in teardown.
| * | Unregister Mime::Type in teardown.Zuhao Wan2014-05-281-2/+6
| |/
* | Merge pull request #15385 from zuhao/refactor_actionpack_render_other_testSantiago Pastorino2014-05-281-4/+7
|\ \ | |/ |/| Add and remove renderer inside the test to prevent leak.
| * Add and remove renderer inside the test to prevent leak.Zuhao Wan2014-05-281-4/+7
| |
* | Merge pull request #15383 from ↵Yves Senn2014-05-281-10/+8
|\ \ | |/ |/| | | | | zuhao/refactor_actionpack_localized_templates_test Move I18n.locale setting into setup and teardown.
| * Move I18n.locale setting into setup and teardown.Zuhao Wan2014-05-281-10/+8
| |
* | Add with_default_charset helper.Zuhao Wan2014-05-281-12/+20
|/
* Deprecate all *_filter callbacks in favor of *_action callbacksRafael Mendonça França2014-05-275-214/+224
| | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c
* rm dead codeAaron Patterson2014-05-271-5/+0
|
* PARAMETERS_KEY is only used in the request, so move the constant thereAaron Patterson2014-05-273-9/+9
|
* Merge branch 'constraints'Aaron Patterson2014-05-2711-75/+85
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
| * rm reset_parameters because we automatically do it from 9ca4839aAaron Patterson2014-05-273-9/+0
| |
| * move path_parameter encoding check to the request objectAaron Patterson2014-05-273-18/+13
| |
| * dispatcher doesn't need `call` anymoreAaron Patterson2014-05-271-4/+0
| |
| * call `serve` with the request on dispatchersAaron Patterson2014-05-271-9/+10
| |
| * constraints class does not need the request class anymoreAaron Patterson2014-05-271-4/+4
| |
| * give all endpoints a superclassAaron Patterson2014-05-274-22/+40
| |
| * skip the build business if the stack is emptyAaron Patterson2014-05-261-2/+6
| |
| * stop hardcoding path_parameters and get it from the requestAaron Patterson2014-05-261-1/+2
| |
| * we do not need to cache rack_appAaron Patterson2014-05-261-9/+3
| |
| * a redirect is not a dispatcher by definition, so eliminate testAaron Patterson2014-05-261-1/+1
| |
| * push is_a check up to where the Constraints object is allocatedAaron Patterson2014-05-262-6/+11
| |
| * pass the request object to the applicationAaron Patterson2014-05-253-6/+8
| |
| * pass a request to `matches?` so we can avoid creating excess requestsAaron Patterson2014-05-252-7/+6
| |
| * nothing is passed to `rack_app` anymore, so rm the paramsAaron Patterson2014-05-251-1/+1
| |
| * one fewer is_a checkAaron Patterson2014-05-251-4/+3
| |
| * Constraints#app should never return another Constraints object, so switch to ↵Aaron Patterson2014-05-251-1/+1
| | | | | | | | if statement
| * eliminate dispatcher is_a checksAaron Patterson2014-05-241-8/+14
| |
| * push is_a?(Dispatcher) check in to one placeAaron Patterson2014-05-244-14/+12
| |
| * Always construct route objects with Constraint objectsAaron Patterson2014-05-244-9/+10
| |
* | Merge pull request #15321 from ↵Santiago Pastorino2014-05-271-1/+4
|\ \ | | | | | | | | | | | | tgxworld/only_find_routes_as_heads_for_head_request Call get_routes_as_head only on HEAD requests.
| * | Call get_routes_as_head only on HEAD requests.Guo Xiang Tan2014-05-251-1/+4
| | |
* | | Skip individual tests upon Dalli::RingErrorMatthew Draper2014-05-271-0/+18
| | | | | | | | | | | | | | | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem.
* | | Escape user input before showing in the page.Rafael Mendonça França2014-05-261-2/+2
| | | | | | | | | | | | | | | | | | This is not a security issue since this page is not present in production and user have to type something in the field but is better to escape the input.
* | | Merge pull request #15325 from tgxworld/no_need_to_call_to_sYves Senn2014-05-262-2/+2
|\ \ \ | | | | | | | | Remove duplicated to_s method call.
| * | | Remove duplicated to_s method call.Guo Xiang Tan2014-05-252-2/+2
| |/ /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 04:25:45 +0000