aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | Use ActionView::Base.logger instead of AC::Base.loggerPiotr Sarnacki2012-08-282-2/+2
| | | |
* | | | Add ActionView::Base.default_formatsPiotr Sarnacki2012-08-284-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | default_formats array is used by LookupContext in order to allow rendering templates when :formats option is not passed. Previously it was always set to Mime::SET, which created dependency on Action Pack. In order to remove this dependency, Mime::SET is used only if ActionController is loaded.
* | | | Remove Mime::Type translations from Action ViewPiotr Sarnacki2012-08-284-11/+10
| | | | | | | | | | | | | | | | | | | | Action View should not be responsible for translating mime types. Any translation that's needed should be handled at controller level.
* | | | Deprecate mime types lookup in auto_discovery_link_tagPiotr Sarnacki2012-08-282-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | Automatically handling mime types for things other than :rss and :atom is not functionality that justifies dependency on Mime::Type from actionpack.
* | | | Remove comment about getting rid of old AV::Base.new behaviorPiotr Sarnacki2012-08-281-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've talked to José Valim, who added this comment, and there is no need to remove old API. It's good to have a simple way to instantiate ActionView::Base, by just passing view paths as a first argument, instead of constructing LookupContext and then the Renderer. [ci skip]
* | | | Remove stubs from LogSubscriber testsPiotr Sarnacki2012-08-281-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We can use another way to instantiate ActionView::Base, by passing renderer as a first option. Thanks to that we can just pass prefixes to LookupContext instead stubbing them on the controller. This is also good, because that kind of API is used in Rails code.
* | | | Move action_controller/vendor/html-scanner to action_viewPiotr Sarnacki2012-08-2816-27/+32
| | | | | | | | | | | | | | | | | | | | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
* | | | Deprecate ActionController::RecordIdentifierPiotr Sarnacki2012-08-282-0/+12
| | | |
* | | | Add ActionView::ModelNamingPiotr Sarnacki2012-08-283-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It's just a duplicate of ActionController::ModelNaming. These are just a simple helpers for decoupling Active Model, so it does not make sense to extract it to Active Support, but the point is to decouple also Action View and Action Pack
* | | | Move ActionController::RecordIdentifier to ActionViewPiotr Sarnacki2012-08-287-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round.
* | | | Remove dependency on actionpack in ActionView::AssetPathsPiotr Sarnacki2012-08-284-6/+20
|/ / / | | | | | | | | | | | | | | | Since Action View should not depend on actionpack, it's best to delegate invalid_asset_host! to controller and just rely on such simple contract instead of raising ActionController::RoutingError directly.
* | | Create variable only in the test that uses itCarlos Antonio da Silva2012-08-251-3/+3
| | | | | | | | | | | | | | | Instead of building a Blog::Post instance for every test in form helper tests, just build it in the test that uses it.
* | | correct handling of date selects when using both disabled and discard optionsVasiliy Ermolovich2012-08-253-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we should take disabled option not only from `html_options` hash but from `options` hash too like `build_select` method does it. So datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true }) datetime_select("post", "updated_at", :discard_minute => true , :disabled => true) both these variants work now closes #7431
* | | Extract ActiveRecord::SessionStore from RailsPrem Sichanugrist2012-08-243-297/+4
| | | | | | | | | | | | | | | This functionality will be available from gem `active_record-session_store` instead.
* | | copy edit the time_ago_in_words helper docsVijay Dev2012-08-231-4/+4
| | |
* | | Merge pull request #7398 from iamvery/time_ago_in_words-docsVijay Dev2012-08-221-0/+7
|\ \ \ | |/ / |/| | Extended documentation for `time_ago_in_words` helper
| * | Extended documentation for `time_ago_in_words` helperJay Hayes2012-08-201-0/+7
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-221-4/+4
|\ \ \
| * | | Make a doc example output in match actual outputEvan Farrar2012-08-151-4/+4
| | | | | | | | | | | | | | | | | | | | Make doc output in grouped_options_for_select divider example match actual output. The options groups were in backwards order of actual.
* | | | Get rid of config.preload_frameworks in favor of config.eager_load_namespacesJosé Valim2012-08-216-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The new option allows any Ruby namespace to be registered and set up for eager load. We are effectively exposing the structure existing in Rails since v3.0 for all developers in order to make their applications thread-safe and CoW friendly.
* | | | Add CHANGELOG entry for #7410Rafael Mendonça França2012-08-211-0/+5
| | | |
* | | | option_tags coerced to "" instead of nilSandeep2012-08-212-0/+13
| | | |
* | | | Merge pull request #7406 from janko-m/documentation_fixesRafael Mendonça França2012-08-212-45/+45
|\ \ \ \ | | | | | | | | | | Fixed some documentation mistakes
| * | | | Fix documentation mistakesJanko Marohnić2012-08-212-45/+45
| | | | |
* | | | | Make sure :via works with mountPratik Naik2012-08-202-2/+12
| | | | |
* | | | | Access @rs only through attr_accessortomykaira2012-08-201-11/+11
|/ / / /
* | / / Added X-Content-Type-Options to the header defaults.Jim Jones2012-08-183-4/+8
| |/ / |/| | | | | | | | With a value of "nosniff", this prevents Internet Explorer from MIME-sniffing a response away from the declared content-type.
* | | Fix slightly broken Markdown syntax in actionpack/CHANGELOG.mdhollowspace2012-08-171-10/+10
| | |
* | | Remove the active_model require from action_dispatch.Rafael Mendonça França2012-08-161-1/+0
|/ / | | | | | | | | | | | | | | Since we removed the ActiveModel dependenxy from ActionPack at 166dbaa7526a96fdf046f093f25b0a134b277a68 we don't need to require it anymore. Closes #7370
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-162-3/+15
|\ \
| * | copy edits [ci skip]Vijay Dev2012-08-161-6/+7
| | |
| * | Minor language fix. [ci skip]Erich Menge2012-08-151-2/+2
| | |
| * | Document the namespacing of controller actions per this discussion:schneems2012-08-091-0/+11
| | | | | | | | | https://github.com/rails/journey/issues/40
* | | Merge pull request #7244 from lucasuyezu/masterCarlos Antonio da Silva2012-08-153-2/+24
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix indentation on template errors to consider line number character count. For instance, when an error is shown, if the related source code snippet has line numbers from, lets say, 8-12, the lines are left aligned, which means the code indent is wrong: 8: foo 9: bar 10: raise 11: baz 12: ... This changes it to right align the source code snippet, so that the indentation is correct: 8: foo 9: bar 10: raise 11: baz 12: ...
| * | | Indentation should consider line number character count.Lucas Uyezu2012-08-133-2/+24
| | | |
* | | | Add Request#formats=(extensions) that lets you set multiple formats directly ↵David Heinemeier Hansson2012-08-142-1/+36
| | | | | | | | | | | | | | | | in a prioritized order
* | | | Add CHANGELOG entry and documentation for Routing ConcernsRafael Mendonça França2012-08-132-0/+68
| | | |
* | | | Extract common controllers to abstract_unitRafael Mendonça França2012-08-133-45/+33
| | | |
* | | | Implementing Routing ConcernsRafael Mendonça França2012-08-132-1/+117
|/ / / | | | | | | | | | | | | | | | | | | This pattern was introduced as a plugin by @dhh. The original implementation can be found in https://github.com/rails/routing_concerns
* | | push header merge down to a private method so that live responses can have ↵Aaron Patterson2012-08-133-8/+22
| | | | | | | | | | | | their own header object
* | | live response headers can be merged with a hashAaron Patterson2012-08-132-0/+10
| | |
* | | Add support for start_hour and end_hour options in select_hour helperEvan Tann2012-08-133-1/+42
| | | | | | | | | | | | Updated documentation to demonstrate start_hour and end_hour options
* | | Grammar fix in ActionView docs/commentsEdward Ocampo-Gooding2012-08-121-1/+1
| | |
* | | Missing closing tagEllis Berner2012-08-121-1/+1
| | |
* | | Ensure option_html_attributes does not modify the given option hashesCarlos Antonio da Silva2012-08-112-1/+10
| | | | | | | | | | | | We can avoid creating extra hashes with #merge, and use #merge! instead.
* | | Simplify html attributes generation for options_for_selectCarlos Antonio da Silva2012-08-112-8/+11
| | | | | | | | | | | | | | | | | | | | | Further simplify the option_html_attributes method after the changes introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the html options here (since they're going to be escaped down the chain in content tag).
* | | Sync CHANGELOGs [ci skip]Rafael Mendonça França2012-08-111-30/+91
| | |
* | | Add CHANGELOG entry for #7314Rafael Mendonça França2012-08-111-0/+5
| | |
* | | Merge pull request #7314 from schneems/schneems/form_for_errorRafael Mendonça França2012-08-102-0/+15
|\ \ \ | | | | | | | | Check for Blank Record in form_for
| * | | check for nil or empty record in form_forschneems2012-08-102-0/+15
| | | | | | | | | | | | | | | | if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.