| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
default_formats array is used by LookupContext in order to allow
rendering templates when :formats option is not passed. Previously it
was always set to Mime::SET, which created dependency on Action Pack. In
order to remove this dependency, Mime::SET is used only if
ActionController is loaded.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Action View should not be responsible for translating mime types. Any
translation that's needed should be handled at controller level.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Automatically handling mime types for things other than :rss and :atom
is not functionality that justifies dependency on Mime::Type from
actionpack.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I've talked to José Valim, who added this comment, and there is no need
to remove old API. It's good to have a simple way to instantiate
ActionView::Base, by just passing view paths as a first argument,
instead of constructing LookupContext and then the Renderer.
[ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We can use another way to instantiate ActionView::Base, by passing
renderer as a first option. Thanks to that we can just pass prefixes to
LookupContext instead stubbing them on the controller. This is also good,
because that kind of API is used in Rails code.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is another step in moving Action View's dependencies in Action Pack
to Action View itself. Also, HtmlScanner seems to be better suited for
views rather than controllers.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It's just a duplicate of ActionController::ModelNaming. These are just a
simple helpers for decoupling Active Model, so it does not make sense to
extract it to Active Support, but the point is to decouple also Action
View and Action Pack
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since it's more about DOM classes and ids it belongs to Action View
better. What's more, it's more convenient to make it part of Action View
to follow the rule that Action Pack can depend on Action View, but not
the other way round.
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Since Action View should not depend on actionpack, it's best to delegate
invalid_asset_host! to controller and just rely on such simple contract
instead of raising ActionController::RoutingError directly.
|
| | |
| | |
| | |
| | |
| | | |
Instead of building a Blog::Post instance for every test in form helper
tests, just build it in the test that uses it.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
we should take disabled option not only from `html_options` hash but from
`options` hash too like `build_select` method does it. So
datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true })
datetime_select("post", "updated_at", :discard_minute => true , :disabled => true)
both these variants work now
closes #7431
|
| | |
| | |
| | |
| | |
| | | |
This functionality will be available from gem
`active_record-session_store` instead.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Extended documentation for `time_ago_in_words` helper
|
| | | |
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Make doc output in grouped_options_for_select divider example match
actual output. The options groups were in backwards order of actual.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The new option allows any Ruby namespace to be registered and set
up for eager load. We are effectively exposing the structure existing
in Rails since v3.0 for all developers in order to make their applications
thread-safe and CoW friendly.
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fixed some documentation mistakes
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
| |/ /
|/| |
| | |
| | | |
With a value of "nosniff", this prevents Internet Explorer from MIME-sniffing a response away from the declared content-type.
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Since we removed the ActiveModel dependenxy from ActionPack at
166dbaa7526a96fdf046f093f25b0a134b277a68 we don't need to require it
anymore.
Closes #7370
|
|\ \ |
|
| | | |
|
| | | |
|
| | |
| | |
| | | |
https://github.com/rails/journey/issues/40
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix indentation on template errors to consider line number character count.
For instance, when an error is shown, if the related source code snippet has line numbers from, lets say, 8-12, the lines are left aligned, which means the code indent is wrong:
8: foo
9: bar
10: raise
11: baz
12: ...
This changes it to right align the source code snippet, so that the indentation is correct:
8: foo
9: bar
10: raise
11: baz
12: ...
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
in a prioritized order
|
| | | | |
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
This pattern was introduced as a plugin by @dhh.
The original implementation can be found in
https://github.com/rails/routing_concerns
|
| | |
| | |
| | |
| | | |
their own header object
|
| | | |
|
| | |
| | |
| | |
| | | |
Updated documentation to demonstrate start_hour and end_hour options
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
We can avoid creating extra hashes with #merge, and use #merge! instead.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Further simplify the option_html_attributes method after the changes
introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the
html options here (since they're going to be escaped down the chain in
content tag).
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Check for Blank Record in form_for
|
| | | |
| | | |
| | | |
| | | | |
if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.
|