Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Show what was the error when assertion has failed | Akira Matsuda | 2016-11-05 | 1 | -1/+1 |
| | | | | this test case fails with ruby 2.4, so we want to see what's actually happening | ||||
* | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 74 | -300/+300 |
| | |||||
* | Support plain loggers in DebugExceptions | Genadi Samokovarov | 2016-10-28 | 2 | -1/+20 |
| | | | | | | | | | | | | | | I have been seeing people setting `Logger` instances for `config.logger` and it blowing up on `rails/web-console` usage. Now, I doubt many folks are manually setting `ActionView::Base.logger`, but given that `DebugExceptions` is running in a pretty fragile environment already, having it crash (and being silent) in those cases can be pretty tricky to trace down. I'm proposing we verify whether the `ActionView::Base.logger` supports silencing before we try to do it, to save us the headache of tracing it down. | ||||
* | Fix :stopdoc: to :startdoc: [ci skip] | Ryuta Kamizono | 2016-10-28 | 1 | -1/+1 |
| | |||||
* | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 2 | -3/+0 |
| | |||||
* | let Regexp#match? be globally available | Xavier Noria | 2016-10-27 | 1 | -1/+0 |
| | | | | | | Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation. | ||||
* | remove unused `RedirectBackError` class | yuuji.yaginuma | 2016-10-27 | 1 | -8/+0 |
| | | | | Follow up to 333bfd896e87862cece95deb1ef88132d5f54ba8 | ||||
* | Remove all Journey constant from public API | Rafael Mendonça França | 2016-10-26 | 5 | -7/+17 |
| | | | | | | There were never public API only there by mistake. [ci skip] | ||||
* | Remove mona lisa image from the tests | Rafael Mendonça França | 2016-10-25 | 5 | -19/+19 |
| | | | | | This image has copyright that we are not giving so it is better to use one image that we own the copyright. | ||||
* | HSTS subdomains is now true, so let's fix documentation [ci skip] (#26870) | प्रथमेश Sonpatki | 2016-10-23 | 1 | -1/+1 |
| | | | - Followup of fda5afeb | ||||
* | Soften this test since YAML.dump may produce keys in other orders. | Charles Oliver Nutter | 2016-10-21 | 1 | -6/+4 |
| | |||||
* | Revert "Undefine assings in IntegrationTest" | Rafael Mendonça França | 2016-10-21 | 2 | -10/+0 |
| | | | | | | This reverts commit 5dde413e1d14c42eb87071db20d075a7b962cb01. Reason: The gem defines it so we don't need to remove | ||||
* | /s/integrations/integration [ci skip] (#26801) | प्रथमेश Sonpatki | 2016-10-16 | 1 | -1/+1 |
| | |||||
* | Merge pull request #26786 from codeodor/patch-1 | Eileen M. Uchitelle | 2016-10-15 | 3 | -1/+16 |
|\ | | | | | Allow any key in Renderer environment hash | ||||
| * | Allow any key in Renderer environment hash | Sammy Larbi | 2016-10-15 | 3 | -1/+16 |
| | | | | | | | | | | | | When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering. | ||||
* | | Copy-edit the documentation | Rafael Mendonça França | 2016-10-15 | 1 | -4/+4 |
| | | | | | | | | [ci skip] | ||||
* | | Make `process` a non-private method and update documentation. | Zach Aysan | 2016-10-15 | 1 | -98/+100 |
|/ | |||||
* | [ci skip] fix typo in Actionpack Changelog | Alex Kitchens | 2016-10-11 | 1 | -1/+1 |
| | |||||
* | ActionController::Parameters#deep_dup (#26567) | Pavel Evstigneev | 2016-10-11 | 2 | -0/+29 |
| | | | | | | | | | | | * ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev] | ||||
* | Add missing @, fix indents. [ci skip] | bogdanvlviv | 2016-10-10 | 1 | -6/+6 |
| | |||||
* | Remove deprecated support to non-keyword arguments in ↵ | Rafael Mendonça França | 2016-10-10 | 4 | -98/+19 |
| | | | | | | `ActionDispatch::IntegrationTest`, `#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`. | ||||
* | Remove deprecated `ActionDispatch::IntegrationTest#*_via_redirect`. | Rafael Mendonça França | 2016-10-10 | 3 | -142/+4 |
| | |||||
* | Remove deprecated `ActionDispatch::IntegrationTest#xml_http_request` | Rafael Mendonça França | 2016-10-10 | 3 | -134/+8 |
| | |||||
* | Remove deprecated support for passing `:path` and route path as stings in ↵ | Rafael Mendonça França | 2016-10-10 | 3 | -17/+7 |
| | | | | `ActionDispatch::Routing::Mapper#match` | ||||
* | Remove deprecated support passing path as `nil` in ↵ | Rafael Mendonça França | 2016-10-10 | 3 | -8/+6 |
| | | | | `ActionDispatch::Routing::Mapper#match` | ||||
* | Remove deprecated `cache_control` argument from ↵ | Rafael Mendonça França | 2016-10-10 | 3 | -18/+5 |
| | | | | `ActionDispatch::Static#initialize` | ||||
* | Remove deprecated support to passing strings to the middleware stack | Rafael Mendonça França | 2016-10-10 | 4 | -60/+8 |
| | |||||
* | Remove deprecated code in ssl middleware | Rafael Mendonça França | 2016-10-10 | 3 | -60/+21 |
| | |||||
* | Remove deprecated code in ActionDispatch::Session::SessionRestoreError | Rafael Mendonça França | 2016-10-10 | 2 | -11/+10 |
| | |||||
* | Deprecated ActionDispatch::ParamsParser::ParamsParser | Rafael Mendonça França | 2016-10-10 | 8 | -36/+34 |
| | | | | | | ActionDispatch::ParamsParser class was removed in favor of ActionDispatch::Http::Parameters so it is better to move the error constant to the new class. | ||||
* | Remove deprecated ActionDispatch::ParamsParser | Rafael Mendonça França | 2016-10-10 | 2 | -12/+5 |
| | |||||
* | Remove deprecated code in ActionDispatch::ParamsParser::ParseError | Rafael Mendonça França | 2016-10-10 | 2 | -17/+10 |
| | |||||
* | Remove deprecated access to mime types through constants | Rafael Mendonça França | 2016-10-10 | 3 | -38/+4 |
| | |||||
* | Remove deprecated support to non-keyword arguments #process | Rafael Mendonça França | 2016-10-10 | 3 | -181/+21 |
| | |||||
* | Remove deprecated `xml_http_request` and `xhr` methods | Rafael Mendonça França | 2016-10-10 | 3 | -30/+4 |
| | |||||
* | Remove deprecated methods in ActionController::Parameters | Rafael Mendonça França | 2016-10-10 | 3 | -27/+5 |
| | |||||
* | Remove deprecated comparing support with `ActionController::Parameters` | Rafael Mendonça França | 2016-10-10 | 3 | -17/+5 |
| | |||||
* | Remove deprecated support to :text in render | Rafael Mendonça França | 2016-10-10 | 4 | -212/+5 |
| | |||||
* | Remove deprecated support to :nothing in render | Rafael Mendonça França | 2016-10-09 | 3 | -15/+4 |
| | |||||
* | Remove deprecated support to `:back` in `redirect_to` | Rafael Mendonça França | 2016-10-09 | 3 | -50/+4 |
| | |||||
* | Remove deprecated support for status option in head | Rafael Mendonça França | 2016-10-09 | 3 | -28/+5 |
| | |||||
* | Remove deprecation at ActionController::BadRequest | Rafael Mendonça França | 2016-10-09 | 2 | -11/+6 |
| | |||||
* | Remove deprecated methods related to controller filters | Rafael Mendonça França | 2016-10-09 | 4 | -116/+8 |
| | | | | | | | | | | `skip_action_callback`, `skip_filter`, `before_filter`, `prepend_before_filter`, `skip_before_filter`, `append_before_filter`, `around_filter` `prepend_around_filter`, `skip_around_filter`, `append_around_filter`, `after_filter`, `prepend_after_filter`, `skip_after_filter` and `append_after_filter`. | ||||
* | Silence a warning | Rafael Mendonça França | 2016-10-07 | 1 | -1/+3 |
| | |||||
* | Undefine assings in IntegrationTest | Rafael Mendonça França | 2016-10-07 | 2 | -0/+10 |
| | | | | | assigns assert the state of a controller instance what should not be done in an integration test. | ||||
* | [ci-skip] Swap method and its alias, format doc | Andrey Molchanov | 2016-10-04 | 1 | -3/+4 |
| | |||||
* | Show an "unmatched constraints" error for mismatching and present params | Chris Carter | 2016-10-03 | 5 | -9/+23 |
| | | | | | | | | | | | | Currently a misleading "missing required keys" error is thrown when a param fails to match the constraints of a particular route. This commit ensures that these params are recognised as unmatching rather than missing. Note: this means that a different error message will be provided between optimized and non-optimized path helpers, due to the fact that the former does not check constraints when matching routes. Fixes #26470. | ||||
* | Remove obsolete comment about class-level respond_to | Andrew White | 2016-10-01 | 1 | -2/+0 |
| | | | | | | The class-level respond_to was extracted in ee77770 to responders gem [ci skip] | ||||
* | Merge pull request #26573 from kirs/action-controller-as-format | Rafael França | 2016-09-27 | 2 | -4/+9 |
|\ | | | | | Make :as option also set request format (AC::TestCase) | ||||
| * | Make :as option also set request format (AC::TestCase) | Kir Shatrov | 2016-09-21 | 2 | -4/+9 |
| | | | | | | | | | | | | | | | | right now you'd have to specify both :as and :format: ``` post :create, params: { foo: "bar" } as: :json, format: :json ``` |