aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Improve changelogsCarlos Antonio da Silva2013-11-221-1/+1
| | | | | | | | | | | | | | | Also make Action Mailer changelog format more consistent with the others [ci skip]
* | | Build fix for Routing InspectorArun Agrawal2013-11-221-2/+2
| | | | | | | | | | | | | | | | | | Broken by 6701b4cf41f6f3d9cfc6a93715acbf852d1e468e
* | | Revert "Merge pull request #12990 from vipulnsward/remove_visualizer_param"Rafael Mendonça França2013-11-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5a19346d2855ecb1c791cdef3af92589566d00db, reversing changes made to d82588ee4756b03025813b3997f4db171ee0fcdc. This argument is being used in the view https://github.com/rails/rails/blob/5a19346d2855ecb1c791cdef3af92589566d00db/actionpack/lib/action_dispatch/journey/visualizer/index.html.erb#L4 It is being set using the binding https://github.com/rails/rails/blob/5a19346d2855ecb1c791cdef3af92589566d00db/actionpack/lib/action_dispatch/journey/gtg/transition_table.rb#L108
* | | Remove unused param `title`to `TransitionTable#visualizer`Vipul A M2013-11-221-1/+1
| | |
* | | unify punctuation in Action Pack changelog. [ci skip]Yves Senn2013-11-211-5/+7
| | |
* | | Fix for routes taskSıtkı Bağdat2013-11-213-17/+22
| | | | | | | | | | | | This commit fixes formatting issue for `rake routes` task, when a section is shorter than a header.
* | | `skiping` => `skipping`Kuldeep Aggarwal2013-11-191-1/+1
| | |
* | | Merge pull request #12898 from chocoby/fix/changelog_commentCarlos Antonio da Silva2013-11-151-1/+1
|\ \ \ | | | | | | | | Fix CHANGELOG typo [ci skip]
| * | | Fix CHANGELOG typo [ci skip]chocoby2013-11-151-1/+1
| | | |
* | | | Avoid hash lookups for building an array of required defaultsCarlos Antonio da Silva2013-11-151-2/+3
| | | | | | | | | | | | | | | | Only set the value once after it's calculated.
* | | | Get rid of useless temp variableCarlos Antonio da Silva2013-11-151-2/+1
| | | |
* | | | Set values instead of building hashes with single values for mergingCarlos Antonio da Silva2013-11-151-2/+2
|/ / /
* | | Take Hash with options inside Array in #url_forAndrey Ognevsky2013-11-153-0/+29
| | |
* | | Revert "Used Yield instead of block.call" -- this causes all of ↵David Heinemeier Hansson2013-11-141-2/+2
| | | | | | | | | | | | | | | | | | atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd.
* | | Merge pull request #12892 from akshay-vishnoi/refactorRafael Mendonça França2013-11-141-9/+12
|\ \ \ | | | | | | | | avoiding next statements
| * | | avoiding next statementsAkshay Vishnoi2013-11-151-9/+12
| | | |
* | | | Merge pull request #12889 from kuldeepaggarwal/speed_upsRafael Mendonça França2013-11-141-2/+2
|\ \ \ \ | |/ / / |/| | | Used Yield instead of block.call
| * | | Used Yield instead of block.callKuldeep Aggarwal2013-11-151-2/+2
| | | |
* | | | class methods moved to already defined class<<self blockAkshay Vishnoi2013-11-151-6/+6
| | | |
* | | | #presence usedAkshay Vishnoi2013-11-141-5/+1
| | | |
* | | | Merge pull request #12838 from strzalek/remove_mime_type_order_varGuillermo Iguaran2013-11-101-4/+3
|\ \ \ \ | | | | | | | | | | Remove @order attribute from collector
| * | | | Remove order attribute from collectorLukasz Strzalkowski2013-11-101-4/+3
| |/ / / | | | | | | | | | | | | Ruby 1.8 legacy. Since 1.9 hash preserves insertion order. No need for additional array to achieve this
* | | | Merge pull request #12740 from gaurish/patch-1Rafael Mendonça França2013-11-101-2/+4
|\ \ \ \ | |/ / / |/| | | Improve Errors when Controller Name or Action isn't specfied
| * | | Improve Errors when Controller Name or Action isn't specfiedGaurish Sharma2013-11-051-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These errors occur when, there routes are wrongly defined. example, the following line would cause a missing :action error root "welcomeindex" Mostly beginners are expected to hit these errors, so lets improve the error message a bit to make their learning experience bit better.
* | | | Skip test which is broken on jrubyGaurish Sharma2013-11-091-0/+4
| |/ / |/| | | | | | | | | | | | | | This test is broken from quite a while & is expected to remain broken as encoding issues are hardest to fix in JRuby. so lets skip this test for now
* | | calculate the ivars to remove in advance as a set and cache them in aAaron Patterson2013-11-062-11/+12
| | | | | | | | | | | | | | | | | | | | | constant. `view_assigns` can use the precalculated sets and remove instance variables without allocating any extra arrays
* | | use a set and reject to avoid array allocationsAaron Patterson2013-11-061-4/+11
| | |
* | | each_with_object on the view_assigns hashAaron Patterson2013-11-061-3/+1
| | |
* | | use slice to avoid range allocationAaron Patterson2013-11-061-1/+3
| | |
* | | these variables are also privateAaron Patterson2013-11-061-0/+1
| | |
* | | instance_variables returns symbols, so we should use symbols in our listAaron Patterson2013-11-061-1/+1
| | |
* | | Eliminate `JSON.{parse,load,generate,dump}` and `def to_json`Godfrey Chan2013-11-056-26/+27
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | JSON.{dump,generate} offered by the JSON gem is not compatiable with Rails at the moment and can cause a lot of subtle bugs when passed certain data structures. This changed all direct usage of the JSON gem in internal Rails code to always go through AS::JSON.{decode,encode}. We also shouldn't be implementing `to_json` most of the time, and these occurances are replaced with an equivilent `as_json` implementation to avoid problems down the road. See [1] for all the juicy details. [1]: intridea/multi_json#138 (comment)
* | :scissors: [ci skip]Carlos Antonio da Silva2013-11-041-3/+0
| |
* | Code style for privacy indentionDavid Heinemeier Hansson2013-11-031-8/+8
| |
* | Ensure backwards compability after the #deep_munge extractionDavid Heinemeier Hansson2013-11-031-0/+10
| |
* | Improve wording in AC::ParameterMissing error messageGuillermo Iguaran2013-11-021-1/+1
| |
* | Revert "Merge pull request #9660 from ↵Guillermo Iguaran2013-11-025-57/+11
| | | | | | | | | | | | | | | | | | sebasoga/change_strong_parameters_require_behaviour" This reverts commit c2b5a8e61ba0f35015e6ac949a5c8fce2042a1f2, reversing changes made to 1918b12c0429caec2a6134ac5e5b42ade103fe90. See: https://github.com/rails/rails/pull/9660#issuecomment-27627493
* | Merge pull request #9660 from ↵Guillermo Iguaran2013-11-015-11/+57
|\ \ | | | | | | | | | | | | sebasoga/change_strong_parameters_require_behaviour Change ActionController::Parameters#require behavior when value is empty
| * | Change ActionController::Parameters#require behavior when value is emptySebastian Sogamoso2013-03-115-11/+57
| | | | | | | | | | | | | | | When the value for the required key is empty an ActionController::ParameterMissing is raised which gets caught by ActionController::Base and turned into a 400 Bad Request reply with a message in the body saying the key is missing, which is misleading. With these changes, ActionController::EmptyParameter will be raised which ActionController::Base will catch and turn into a 400 Bad Request reply with a message in the body saying the key value is empty.
* | | Fix typo in method description in Responder classLin Reid2013-11-011-1/+1
| | | | | | | | | | | | Fixes a typo in the description for the call class method in Responder.
* | | Warnings removed for ruby trunkArun Agrawal2013-11-011-1/+1
| | | | | | | | | Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
* | | session#fetch doesn't behave exactly like Hash#fetch.Damien Mathieu2013-10-302-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Mention it in the changelog and add a test checking for regressions. Hash#fetch isn't adding the defaultly returned value. However, in the session, saving it is the behavior we should expect. See discussion in #12692
* | | add the fetch method to sessionsDamien Mathieu2013-10-293-0/+37
| | |
* | | Add a changelog entry for #12656 [ci skip]Robin Dupret2013-10-271-0/+8
| | |
* | | don't mutate hash with fetchDoug Cole2013-10-262-1/+14
| | |
* | | Remove surprise if from show_exception middlewarePrem Sichanugrist2013-10-271-2/+5
| | | | | | | | | This increase the readability within the rescue block.
* | | Merge pull request #10471 from andyw8/button_to_paramsRafael Mendonça França2013-10-241-0/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add params option for button_to Conflicts: actionpack/CHANGELOG.md
| * | | Add params option for button_toAndy Waite2013-09-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | The parameters are rendered as hidden form fields within the generated form. This is useful for when a record has multiple buttons associated with it, each of which target the same controller method, but which need to submit different attributes.
* | | | Improve the CHANGELOG entry [ci skip]Rafael Mendonça França2013-10-241-10/+9
| | | |
* | | | update CHANGELOGTima Maslyuchenko2013-10-241-0/+16
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 22:18:43 +0000