aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* The instance_reader of default_url_options needs to not exist.Yehuda Katz2010-02-271-0/+1
|
* Remind us that RoutingAssertions should work in an integration contextYehuda Katz2010-02-261-0/+1
|
* 1.9 seems to have a bug involving cloned classes and super. Fix it by not ↵Carlhuda2010-02-261-8/+12
| | | | cloning (and instead creating classes on demand). The 1.9 bug should be investigated.
* Set the body using the accessor for AD::Response introspection mode so it ↵Carlhuda2010-02-261-1/+2
| | | | gets wrapped in a []
* Make ActionController::Routing::Routes a DeprecatedProxyCarlhuda2010-02-262-3/+7
|
* If IntegrationSession is initialized with an objects that responds to ↵Carlhuda2010-02-266-14/+24
| | | | #routes, automatically extend the URL helpers from the RouteSet onto it
* Upon further reflection, we realized that SharedTestRoutes is not really a ↵Carlhuda2010-02-261-1/+0
| | | | | | | | hack, but is instead a standin (in the Rails tests) for Rails.application.routes. * In a real application, action_controller/railties.rb does AC::Base.include(app.routes.url_helpers) * ActionController itself does not know about Rails.application, but instead can have named routes for any router * SharedTestRoutes are created in abstract_unit to stand in for Rails.application.routes, and is used in internal functional tests
* Relatively speaking, it's not actually that bad...Carlhuda2010-02-261-2/+0
|
* Setting UrlFor in with_routing is no longer needed now that it's not globalCarlhuda2010-02-262-7/+5
|
* Including UrlFor in Redirecting and Head will warn usefully if a controller ↵Carlhuda2010-02-262-6/+3
| | | | is wired up without a router included (and still support redirect_to "omg")
* Remove traces of SharedTestRoutes from user code; leave it as a standin for ↵Carlhuda2010-02-263-14/+0
| | | | Rails.application.routes in Rails internal tests
* Stop setting UrlFor using SharedTestHelpersCarlhuda2010-02-262-4/+4
|
* Silence test deprecation warningsCarlhuda2010-02-262-17/+56
|
* Change the API for setting global options for #url_for to self.url_options = ↵Carlhuda2010-02-264-14/+26
| | | | | | { ... } This attr_accessor can be set in a before filter or in the action itself. Overwriting default_url_options still works but will output a deprecation notice.
* Remove the :use_defaults check in UrlFor#merge optionsCarlhuda2010-02-261-1/+1
|
* Rename named_url_helpers to url_helpers and url_helpers to url_forCarlhuda2010-02-2611-25/+24
|
* Fix 1.9 issueYehuda Katz2010-02-261-1/+1
|
* Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 ↵José Valim2010-02-267-12/+15
| | | | status:resolved]
* Add missing require on abstract_controller/collector [#4061 status:resolved]José Valim2010-02-261-0/+2
|
* Rename metaclass to singleton_classCarlhuda2010-02-254-5/+5
|
* Get URL helpers working again in integration tests.Carlhuda2010-02-253-41/+33
|
* Final pass at removing the router from a global constantCarlhuda2010-02-257-12/+24
|
* Continued effort to deglobalize the routerCarlhuda2010-02-2510-79/+66
|
* Fix all of AP's tests with the non global routerCarlhuda2010-02-252-5/+7
|
* Merge branch 'master' of github.com:rails/railsCarlhuda2010-02-251-1/+1
|
* WIP: Remove the global routerCarlhuda2010-02-2526-263/+342
|
* Bump i18n for new public I18n.normalize_keysJeremy Kemper2010-02-251-1/+1
|
* Use Object#singleton_class instead of #metaclass. Prefer Ruby's choice.Jeremy Kemper2010-02-251-2/+2
|
* add time_separator for minutes only if minutes aren't hiddenSantiago Pastorino2010-02-252-1/+42
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Renamed LocalizedCache to DetailsCache.José Valim2010-02-247-56/+59
|
* Cleanup render callstack and make render(:json => {}, :status => 401) work ↵José Valim2010-02-242-23/+24
| | | | again.
* Remove ActionController::Base.resources_path_namesCarl Lerche2010-02-243-18/+18
|
* Remove the renderer option from the hash.José Valim2010-02-241-1/+1
|
* Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵Yehuda Katz2010-02-233-1/+11
| | | | Closes #8994
* Revert "Fix test load paths for those not using bundler"Carlhuda2010-02-234-19/+4
| | | | | | This reverts commit eec2d301d4ce9df9c71c1a5aa63053eb970b6818. This commit broke tests. You cannot have a file called "bundler" on the load path.
* Makes send_file work again by deferring to Rack::Sendfile. Carlhuda2010-02-235-72/+24
| | | | | | | | | | * Add the Rack::Sendfile middleware * Make the header to use configurable via config.action_dispatch.x_sendfile_header (default to "X-Sendfile"). * Add Railties tests to confirm that these work * Remove the :stream, :buffer_size, and :x_senfile default options to send_file * Change the log subscriber to always say "Sent file" * Add deprecation warnings for options that are now no-ops Note that servers can configure this by setting X-Sendfile-Type. Hosting companies and those creating packages of servers specially designed for Rails applications are encouraged to specify this header so that this can work transparently.
* Make AD::Response correctly handle bodies that respond_to?(:to_path) as per ↵Carlhuda2010-02-231-0/+12
| | | | the Rack spec
* Fix streaming by having it create a File object, which can be handled by ↵Carlhuda2010-02-233-18/+17
| | | | Rack servers as appropriate
* Rename erubis_implementation to erb_implementation.José Valim2010-02-221-3/+3
|
* Include missing modules.José Valim2010-02-223-3/+4
|
* Use ActionDispatch::Routing everywhereMartin Schürrer2010-02-2118-48/+53
|
* Add a tests which ensures filtered_parameters does not raise an error for a ↵José Valim2010-02-211-1/+1
| | | | mixed array [#3928 status:resolved]
* Store compiled parameter filters so we don't have to compile them in each ↵José Valim2010-02-211-25/+40
| | | | request.
* Require persisted? in ActiveModel::Lint and remove new_record? and ↵José Valim2010-02-2112-87/+63
| | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
* AMo #key is now #to_key and CI is probably happysnusnu2010-02-204-12/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obviously #key is a too common name to be included in the AMo interface, #to_key fits better and also relates nicely to #to_param. Thx wycats, koz and josevalim for the suggestion. AR's #to_key implementation now takes customized primary keys into account and there's a testcase for that too. The #to_param AMo lint makes no assumptions on how the method behaves in the presence of composite primary keys. It leaves the decision wether to provide a default, or to raise and thus signal to the user that implementing this method will need his special attention, up to the implementers. All AMo cares about is that #to_param is implemented and returns nil in case of a new_record?. The default CompliantObject used in lint_test provides a naive default implementation that just joins all key attributes with '-'. The #to_key default implementation in lint_test's CompliantObject now returns [id] instead of [1]. This was previously causing the (wrong) tests I added for AR's #to_key implementation to pass. The #to_key tests added with this patch should be better. The CI failure was caused by my lack of knowledge about the test:isolated task. The tests for the record_identifier code in action_controller are using fake non AR models and I forgot to stub the #to_key method over there. This issue didn't come up when running the test task, only test:isolated revealed it. This patch fixes that. All tests pass isolated or not, well, apart from one previously unpended test in action_controller that is unrelated to my patch.
* Adds #key and #to_param to the AMo interfacesnusnu2010-02-193-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces two new methods that every AMo compliant object must implement. Below are the default implementations along with the implied interface contract. # Returns an Enumerable of all (primary) key # attributes or nil if new_record? is true def key new_record? ? nil : [1] end # Returns a string representing the object's key # suitable for use in URLs, or nil if new_record? # is true def to_param key ? key.first.to_s : nil end 1) The #key method Previously rails' record_identifier code, which is used in the #dom_id helper, relied on calling #id on the record to provide a reasonable DOM id. Now with rails3 being all ORM agnostic, it's not safe anymore to assume that every record ever will have an #id as its primary key attribute. Having a #key method available on every AMo object means that #dom_id can be implemented using record.to_model.key # instead of record.id Using this we're able to take composite primary keys into account (e.g. available in datamapper) by implementing #dom_id using a newly added record_key_for_dom_id(record) method. The user can overwrite this method to provide customized versions of the object's key used in #dom_id. Also, dealing with more complex keys that can contain arbitrary strings, means that we need to make sure that we only provide DOM ids that are valid according to the spec. For this reason, this patch sends the key provided through a newly added sanitize_dom_id(candidate_id) method, that makes sure we only produce valid HTML The reason to not just add #dom_id to the AMo interface was that it feels like providing a DOM id should not be a model concern. Adding #dom_id to the AMo interface would force these concern on the model, while it's better left to be implemented in a helper. Now one could say the same is true for #to_param, and actually I think that it doesn't really fit into the model either, but it's used in AR and it's a main part of integrating into the rails router. This is different from #dom_id which is only used in view helpers and can be implemented on top of a semantically more meaningful method like #key. 2) The #to_param method Since the rails router relies on #to_param to be present, AR::Base implements it and returns the id by default, allowing the user to overwrite the method if desired. Now with different ORMs integrating into rails, every ORM railtie needs to implement it's own #to_param implementation while already providing code to be AMo compliant. Since the whole point of AMo compliance seems to be to integrate any ORM seamlessly into rails, it seems fair that all we really need to do as another ORM, is to be AMo compliant. By including #to_param into the official interface, we can make sure that this code can be centralized in the various AMo compliance layers, and not be added separately by every ORM railtie. 3) All specs pass
* Fix a bunch of pending tests by providing an introspection mode for the ↵Carlhuda2010-02-194-21/+42
| | | | Response object that does up-front parsing of the headers to populate things like @etag
* Revert "i18n translate with arrays issue solved"Yehuda Katz2010-02-191-5/+0
| | | | This reverts commit e7055e5b084f5e29e9cf8dab8d56943da65ccb43.
* i18n translate with arrays issue solvedSantiago Pastorino2010-02-191-0/+5
|
* Remove empty line and trailing hash, breaks documentation generationDirkjan Bussink2010-02-191-2/+0
| | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 16:04:43 +0000