Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove XML Parser from ActionDispatch | Prem Sichanugrist | 2013-02-20 | 4 | -339/+26 |
| | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem. | ||||
* | Fix time_zone_options_for_select to not mutate TimeZones array | Brian McManus | 2013-02-19 | 3 | -1/+16 |
| | | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests. | ||||
* | moves a CHANGELOG entry from AR to AP | Xavier Noria | 2013-02-19 | 1 | -0/+4 |
| | |||||
* | InvalidMessage is in ActiveSupport::MessageEncryptor namespace | Santiago Pastorino | 2013-02-19 | 2 | -4/+19 |
| | | | | Closes #9302 | ||||
* | Fix AP tests related to routes inspector output and the new column titles | Carlos Antonio da Silva | 2013-02-19 | 1 | -20/+65 |
| | |||||
* | Add missing require to routes inspector | Carlos Antonio da Silva | 2013-02-19 | 1 | -0/+1 |
| | |||||
* | Require AS deps in ActionDispatch::Http::URL | Miha Filej | 2013-02-19 | 1 | -0/+3 |
| | | | | Allows us to use url_for and friends in isolation. | ||||
* | Duck typing is hard. Add header to HtmlTableFormatter. | Steve Klabnik | 2013-02-18 | 1 | -0/+4 |
| | | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔ | ||||
* | editorial tweaks | Xavier Noria | 2013-02-19 | 1 | -3/+6 |
| | |||||
* | use strip_heredoc to keep indentation consistent. | Steve Klabnik | 2013-02-18 | 1 | -12/+12 |
| | | | | Thanks @sikachu. :heart: | ||||
* | Add message when you have no routes defined. | Steve Klabnik | 2013-02-18 | 2 | -0/+31 |
| | | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic. | ||||
* | Add headings to rake routes table | Steve Klabnik | 2013-02-18 | 1 | -3/+19 |
| | |||||
* | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 1 | -1/+1 |
| | | | | see: https://github.com/blog/1406-namespaced-gists | ||||
* | Return false on toggle on error pages | Bartlomiej Kozal | 2013-02-17 | 2 | -6/+7 |
| | |||||
* | Merge pull request #9307 from wangjohn/remove_unneeded_md5_digest | Xavier Noria | 2013-02-16 | 1 | -1/+0 |
|\ | | | | | Removed an old require of an MD5 digest which is no longer used. | ||||
| * | Removed an old require of an MD5 digest which is no longer used. | wangjohn | 2013-02-15 | 1 | -1/+0 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-15 | 3 | -4/+4 |
|\ \ | |/ |/| | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | Correct bullet content line wrapping | Tim "Roger" Harvey | 2013-02-12 | 1 | -1/+1 |
| | | | | | | | | | | | | The `:prefix` bullet content was not properly wrapping, dropping to the following line because the additional content was not indented properly. With this change, it will now display properly the way `:discard_type` does. | ||||
| * | Fix typo. | Carson McDonald | 2013-02-11 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
| * | Fixing the examples for button_to | Marc Baumbach | 2013-02-06 | 1 | -2/+2 |
| | | | | | | The examples do not generate the output they intend to due to not explicitly declaring the hash separations. This causes it to be treated as one parameter instead of the intended two parameters. | ||||
* | | Merge pull request #8704 from senny/remove_regexp_global_from_url_for | Aaron Patterson | 2013-02-14 | 2 | -2/+9 |
|\ \ | | | | | | | replace regexp global in #url_for | ||||
| * | | replace regexp global in #url_for | Yves Senn | 2013-01-16 | 2 | -2/+9 |
| | | | |||||
* | | | Bump rack-test dependency to 0.6.2 | Rahul P. Chaudhari | 2013-02-14 | 1 | -1/+1 |
| | | | |||||
* | | | Avoid to_sym calls | Santiago Pastorino | 2013-02-13 | 1 | -1/+1 |
| | | | |||||
* | | | Improve changelog entry from #9221 [ci skip] | Carlos Antonio da Silva | 2013-02-11 | 2 | -18/+16 |
| | | | |||||
* | | | Merge pull request #9221 from thenickcox/image_alt_attribute | Carlos Antonio da Silva | 2013-02-11 | 3 | -4/+40 |
|\ \ \ | | | | | | | | | Improve img alt attribute for screen readers | ||||
| * | | | Improve img alt attribute for screen readers | thenickcox | 2013-02-09 | 3 | -4/+40 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method | ||||
* | | | | the `:controller` option for routes can contain numbers. closes #9231. | Yves Senn | 2013-02-09 | 2 | -1/+13 |
| | | | | |||||
* | | | | Add missing require to AP | Carlos Antonio da Silva | 2013-02-08 | 1 | -0/+1 |
| | | | | |||||
* | | | | We don't need a CHANGELOG entry for an issue of something that was not ↵ | Santiago Pastorino | 2013-02-08 | 1 | -5/+0 |
| | | | | | | | | | | | | | | | | released yet | ||||
* | | | | Merge pull request #9196 from AndreyChernyh/fix-cookies-with-null-session | Santiago Pastorino | 2013-02-08 | 4 | -5/+49 |
|\ \ \ \ | | | | | | | | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | ||||
| * | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 4 | -5/+49 |
| |/ / / | |||||
* / / / | Bump rack dependency to 1.5.2 | Santiago Pastorino | 2013-02-08 | 1 | -1/+1 |
|/ / / | |||||
* | | | Update actionpack/CHANGELOG.md | Rafael Mendonça França | 2013-02-06 | 1 | -4/+4 |
| | | | | | | | | | [ci skip] | ||||
* | | | ruby constant syntax is not supported as routing `:controller` option. | Yves Senn | 2013-02-06 | 3 | -9/+59 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide. | ||||
* | | | partials inside directory work with `assert_template` | Yves Senn | 2013-02-04 | 6 | -3/+30 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'. | ||||
* | | | descriptive `assert_template` error when partial wasn't rendered | Yves Senn | 2013-02-04 | 3 | -0/+16 |
| | | | | | | | | | | | | | | | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error. | ||||
* | | | Put .rdoc at the end of the files named RUNNING_UNIT_TESTS | Yuki Nishijima | 2013-02-03 | 1 | -0/+0 |
| |/ |/| | | | | | So that they are printed nicely on GitHub. | ||||
* | | Fix markdown syntax in actionpack CHANGELOG. | Steve Klabnik | 2013-02-01 | 1 | -1/+2 |
| | | | | | | | | Starting a line with an octothorpe makes an <h1> | ||||
* | | Missing require hash/keys | Akira Matsuda | 2013-02-01 | 2 | -0/+3 |
| | | |||||
* | | Missing or unneeded require extract_options | Akira Matsuda | 2013-02-01 | 10 | -1/+10 |
| | | |||||
* | | Use \A in Regexps | Egor Homakov | 2013-02-01 | 1 | -1/+1 |
| | | | | | | | | | | So, if there is redirect_to params[:q] i can send ?q=javascript:asdf()%0A/localpath Or something more nasty, so please use \A | ||||
* | | remove dead code | Aaron Patterson | 2013-01-30 | 1 | -4/+1 |
| | | |||||
* | | change parameter name for positional args | Aaron Patterson | 2013-01-30 | 1 | -2/+1 |
| | | |||||
* | | nodoc the helper classes, cache stuff for optimized helper | Aaron Patterson | 2013-01-30 | 1 | -13/+17 |
| | | |||||
* | | cache path parts in the instance | Aaron Patterson | 2013-01-30 | 1 | -2/+3 |
| | | |||||
* | | stop evaling a string every time | Aaron Patterson | 2013-01-30 | 1 | -4/+4 |
| | | |||||
* | | moving helper classes outside the private block | Aaron Patterson | 2013-01-30 | 1 | -90/+88 |
| | | |||||
* | | pushing specialization down to the optimized class | Aaron Patterson | 2013-01-30 | 1 | -23/+25 |
| | | |||||
* | | use polymorphism to remove conditional | Aaron Patterson | 2013-01-30 | 1 | -35/+27 |
| | |