| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I would like to change the signature of the Route constructor. Since
the mapping object has all the data required to construct a Route
object, move the allocation to a factory method.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We should build the routes using the user facing API which is `Mapper`.
This frees up the library internals to change as we see fit. IOW we
shouldn't be testing internals.
|
|/ / / /
| | | |
| | | |
| | | |
| | | | |
we can directly turn it in to a regular expression here, so we don't
need to test its value twice
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is part of a larger refactoring on controller tests. We needed to
move these methods here so that we could get rid of the `|| key ==
:action || key == :controller` in `assign_parameters`. We know this is
ugly and intend to fix it but for now `generate_extras` needs to be used
in the two methods to access the path and the query_string_keys.
We're adding `:controller` and `:action` to the `query_string_keys`
because we always need a controller and action. If someone passed
`action` or `controller` in in there test they are unambigious - we
know they have to go into the query params.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The outer router object already keeps a hash of named routes, so we
should just use that.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
refactor the tests with a backwards compatible method call so we can rm
add_route2 from the journey router
|
| | | |
| | | |
| | | |
| | | |
| | | | |
then we can let the mapping object derive stuff that the Route object
needs.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
now that we aren't doing options manipulations, we can just pass the
mapping object down and read values from it.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
since we've extracted the `to` initialization, there's no need for
`process_path`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
if `to` was initialized, this method would return, so we can eliminate
the to ||= in the conditional. Finally, let's return a nil in the else
block so that it's explicit that this method can return nil
|
| | | |
| | | |
| | | |
| | | | |
Eventually we'll pull this up and delete `process_path`.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We don't need a method for something like this. I want to pull this up
the stack as well and move the module + :controller ArgumentError up the
stack as well
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
now we don't need to add it to a hash and delete it from the hash later
just to pass it around
|
| | | |
| | | |
| | | |
| | | |
| | | | |
`add_route` needs the AST, so rather than shove it in a hash and delete
later, lets move parsing up the stack so we can pass down later
|
| | | |
| | | |
| | | |
| | | |
| | | | |
also change the feeler to subclass AD::Request so that it has all the
methods that Request has
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Eventually I want to eliminate the FakeSet test class
|
| | | |
| | | |
| | | |
| | | |
| | | | |
I'm going to reimplement this using route objects, so it will be easier
if we just change ast access to go through a method rather than hashes
|
| | | |
| | | |
| | | |
| | | | |
we don't need to keep adding it and deleting if from hashes.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Eventually I want to pull up AST generation so that we don't have to add
it to the `conditions` hash.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It just constructs a Path::Pattern object with the AST that it already
has
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This was a useless object. We can just directly construct a
Path::Pattern object without a Strexp object.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
the caller already has it, there is no reason to pack it in to an object
and just throw that object away.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
we always pass all parameters, so there is no reason to provide default
arguments.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
the caller already has access to `as`, so we can stop passing it around.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
the same value that is extracted from the options hash earlier is
returned, so we don't need to pass it in in the first place. The caller
already has the data, so stop passing it around.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
this way we don't have to mutate the options hash so far away from where
the user passed it in
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it
is directly passed to `match`, so setting it in a scope must be a
mistake.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
I didn't like this method because it mutates the parameters. Now that
the method is so small, just push it up to `initialize`
|
| | | |
| | | |
| | | |
| | | |
| | | | |
now the `@defaults` variable doesn't need to be set before calling
`normalize_defaults`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
These three options are stored in the `scope` chain outside of the
options hash. If they are in the options hash, then someone passed them
in to `match` and they don't really do anything. So lets remove the
code.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
remove `format` from the options hash in the scope chain so that we
don't need to remove it later
|
| | | |
| | | |
| | | |
| | | | |
this reduces the number of times we have to mutate the options hash.
|
| | | |
| | | |
| | | |
| | | | |
This just ensures that `format` is applied to things inside the scope
|
|\ \ \ \
| | | | |
| | | | | |
Fewer objects and refactoring
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since we are always responding with an array and using `any?`, we don't
need to check if an array is empty
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Now we don't have to manually remove this from the options hash since
the scope stores it outside of "options"
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove the `options` reader from `Resource` because nobody needs to see
that hash. Also remove mutations on the options hash in
`apply_common_behavior_for` because leaving the side effects in that
method makes it difficult to understand what is going on in the caller.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
these two keys have a different merge strategy, and they also just get
removed from the options hash later in the code. If we store them in a
separate place, then we don't need to remove them later
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Eventually we don't want to expose the "options" hash from scope, only
read values from it. Lets start by adding a reader method.
|