aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8668 from guilleiguaran/exceptionsDavid Heinemeier Hansson2013-01-0112-65/+258
|\ | | | | New exceptions pages for development
| * formatted_code_for should be privateGuillermo Iguaran2012-12-311-12/+12
| |
| * Summary and Details HTML elements aren't supported in all modern browsersGuillermo Iguaran2012-12-312-12/+12
| |
| * Fix test for DebugExceptions due to template changeGuillermo Iguaran2012-12-311-1/+1
| |
| * Add style to AV::Template::Error exception pageGuillermo Iguaran2012-12-313-18/+54
| |
| * Improve line-height to have better line spacing in exception messageGuillermo Iguaran2012-12-311-0/+1
| |
| * Add new style to Routing Error pageGuillermo Iguaran2012-12-311-19/+22
| |
| * Styling for exception pageGuillermo Iguaran2012-12-316-29/+150
| |
| * Add source extract to detailed exception pageGuillermo Iguaran2012-12-314-2/+34
| |
* | Updated copyright notices for 2013Andrew Nesbitt2012-12-314-4/+4
|/
* Use ActiveSupport::TestCase in the journey testsRafael Mendonça França2012-12-3113-13/+13
|
* Merge pull request #8666 from mekishizufu/fix_lambdasSantiago Pastorino2012-12-311-2/+2
|\ | | | | Fix usage of lambda as a Rack endpoint
| * Fix usage of lambda as a Rack endpointJiri Pospisil2012-12-311-2/+2
| | | | | | | | The response body needs to respond_to? :each.
* | Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-3113-23/+23
| |
* | Do not use the same tests descriptionRafael Mendonça França2012-12-311-3/+3
| |
* | Remove unneeded testsRafael Mendonça França2012-12-315-381/+0
| | | | | | | | These tests are needed only if we are using MiniTest::Spec
* | Add active_support/testing/autorunRafael Mendonça França2012-12-313-3/+3
| | | | | | | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails
* | Inherit from MiniTest::Unit::TestCase instead of MiniTest::SpecRafael Mendonça França2012-12-313-13/+0
|/
* Merge pull request #8662 from ↵Santiago Pastorino2012-12-314-3/+25
|\ | | | | | | | | senny/8661_should_not_append_charset_if_already_present Charset should not be appended to image/* type
| * charset should not be appended for `head` responsesYves Senn2012-12-314-3/+25
| | | | | | | | | | | | | | 1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
* | Define [], []=, permanent, signed and encrypted as the only allowed methods ↵Santiago Pastorino2012-12-301-9/+57
| | | | | | | | for the non Raw Cookie classes
* | Merge pull request #8546 from hsbt/fix-testcase-strict-warningSantiago Pastorino2012-12-301-1/+2
|\ \ | |/ |/| fix testcase: ruby-2.0.0 warned unused variables
| * change spy of after invoked controller action. because ruby-2.0.0 waned ↵SHIBATA Hiroshi2012-12-201-1/+2
| | | | | | | | unused variables
* | Merge pull request #8627 from schneems/schneems/routes-1-9Rafael Mendonça França2012-12-261-1/+1
|\ \ | | | | | | Ruby 1.9 style hash in Route Inspector
| * | Ruby 1.9 style hash in Route Inspectorschneems2012-12-271-1/+1
| | |
* | | Extract the component rendering of collection_radio_buttons andRafael Mendonça França2012-12-262-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | collection_check_boxes to a private method. It will make easier to extend. Example: class CollectionRadioButtons < ActionView::Helpers::Tags::CollectionRadioButtons include CollectionExtensions def render wrap_rendered_collection(super, @options) end private def render_component(builder) builder.radio_button + builder.label(:class => "collection_radio_buttons") end end
* | | Fix collection_radio_buttons with the option `:checked` with value ofRafael Mendonça França2012-12-262-1/+8
| | | | | | | | | | | | `false`
* | | Merge pull request #8598 from NARKOZ/refactor-highlightSantiago Pastorino2012-12-261-2/+2
|\ \ \ | | | | | | | | refactor highlight method: return fast if text or phrases are blank
| * | | fetch highlighter option only when neededNihad Abbasov2012-12-241-2/+2
| | | |
* | | | Fix CHANGELOG style [ci skip]Rafael Mendonça França2012-12-261-1/+1
| | | |
* | | | We need to check explictly that env['action_dispatch.show_exceptions']Rafael Mendonça França2012-12-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | is false. If it is nil we can't raise the exception
* | | | more descriptive return parametersHrvoje Šimić2012-12-261-4/+3
|/ / /
* | | "warning: ambiguous first argument; put parentheses or even spaces"Akira Matsuda2012-12-241-1/+1
| | |
* | | we're not supporting SQLite 2Akira Matsuda2012-12-241-13/+5
| | |
* | | Merge pull request #8085 from acapilleri/format_never_nilGuillermo Iguaran2012-12-224-3/+28
|\ \ \ | | | | | | | | if format is unknown NullMimeTypeObject is returned
| * | | return Mime::NullType if format is unknownAngelo Capilleri2012-12-224-3/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a request has an unknown format, the methods html?, xml?, json? ...etc not raise an Exception. This patch add a class Mime::NullType, that is returned when request.format is unknown and it responds false to the methods that ends with '?' and true to 'nil?'. It refers to #7837, this issue is considered a improvement not a bug.
* | | | Merge pull request #8586 from balexand/cache_digests_regexRafael Mendonça França2012-12-213-2/+12
|\ \ \ \ | |/ / / |/| | | Digestor explicit dependency should not contain trailing whitespace
| * | | Digestor explicit dependency should not contain trailing whitespaceBrian Alexander2012-12-213-2/+12
| | | | | | | | | | | | | | | | test for rails/rails#8586
* | | | Move background jobs to the 'jobs' branch until fully baked. Not shipping ↵Jeremy Kemper2012-12-211-10/+0
| | | | | | | | | | | | | | | | with Rails 4.0.
* | | | Merge pull request #7312 from krainboltgreene/http-token-parser-bugSteve Klabnik2012-12-212-17/+56
|\ \ \ \ | |/ / / |/| | | Http token parser bug
| * | | Refactoring the token_and_options method to fix bugsKurtis Rainbolt-Greene2012-12-152-17/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding a test for the equal trun bug Adding a test for the after equal trunc bug Adding a test for the slash bug Adding a test for the slash quote bug Adding a helper method for creating a sample request object with token Writing a method to create params array from raw params Writing a method to rewrite param values in the params Writing a method to get the token params from an authorization value Refactoring the token_and_options method to fix bugs Removing unnessecary test A constant for this shared regex seemed appropriate Wanting to split up this logic Adding small documentation pieces
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-212-1/+6
|\ \ \ \
| * | | | Revert "Fix incorrect adjustment 4c41e87e3ae548c44810b66437b2f0f6e73b2106"Vijay Dev2012-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e1f8ec59f2cc83f052b15233147aa2d6d8114a4d. Reason: seems bad styling [ci skip]
| * | | | Fix incorrect adjustment 4c41e87e3ae548c44810b66437b2f0f6e73b2106kei2012-12-201-1/+1
| | | | |
| * | | | Fix documentation stylekei2012-12-201-1/+1
| | | | |
| * | | | Add script_name option description and example for #url_for optionsIvan Vanyak2012-12-171-0/+5
| |/ / /
* | | | Fix indentation issuing warningCarlos Antonio da Silva2012-12-201-1/+1
| | | |
* | | | Merge pull request #8567 from frodsan/update_coding_conventions_journeyRafael Mendonça França2012-12-2017-438/+440
|\ \ \ \ | | | | | | | | | | update AD::Journey to follow Rails coding conventions
| * | | | update AD::Journey to follow Rails coding conventionsFrancesco Rodriguez2012-12-2017-438/+440
| | | | |
* | | | | Fix CHANGELOG entry about scope changeGuillermo Iguaran2012-12-201-1/+1
|/ / / / | | | | | | | | I missed attribution on this :flushed: