| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
Remove original root method from Base module and kept overridden implementation in Resources module.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- The root method is defined and documented in Base module and
decorated in Resources module.
- The documentation in Base module actually talks about method
signature of decorated method from Resources module.
- Argument handling was moved to decorated method in
https://github.com/rails/rails/commit/977455cc2efb94f40b4c0d46d1842be198ed7c4c
to handle options such as :as with directly passed path parameter.
- To avoid the confusion, removed original root method from Base module
and only kept overridden version in Resources module.
- References - https://github.com/rails/rails/pull/12208 &
https://github.com/rails/rails/pull/12208#issuecomment-24350897.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Removes following warning -
`rails/actionpack/test/dispatch/ssl_test.rb:203: warning: `*' interpreted as argument prefix`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Earlier only Hash was allowed as params argument to url_helpers.
- Now ActionController::Parameters instances will also be allowed.
- If the params are not secured then it will raise an ArgumentError to
indicate that constructing URLs with non-secure params is not recommended.
- Fixes #22832.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Per-form CSRF tokens
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add ActionController:Renderers test
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
To complement actionpack/test/controller/metal/renderers_test.rb
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Replace x.times.map{} with Array.new(x){} in AD::Journey::Path::Pattern
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The former is slightly more readable, performant and has fewer method calls.
```ruby
Benchmark.ips do |x|
x.report('times.map') { 5.times.map{} }
x.report('Array.new') { Array.new(5){} }
x.compare!
end
__END__
Calculating -------------------------------------
times.map 21.188k i/100ms
Array.new 30.449k i/100ms
-------------------------------------------------
times.map 311.613k (± 3.5%) i/s - 1.568M
Array.new 590.374k (± 1.2%) i/s - 2.954M
Comparison:
Array.new: 590373.6 i/s
times.map: 311612.8 i/s - 1.89x slower
```
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Add tests for ActionController::Renderers::use_renderers
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix AC::Parameters#to_unsafe_h to return all unfiltered values
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- AC::Parameters#convert_parameters_to_hashes should return filtered or
unfiltered values based on whether it is called from `to_h` or `to_unsafe_h`
instead of always defaulting to `to_h`.
- Fixes #22841
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Configurable redirect and secure cookies for ActionDispatch::SSL
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Benchmark.ips do |x|
x.report('Time.parse') { Time.parse('2011-01-01') }
x.report('Time.new') { Time.new(2011, 1, 1) }
end
Calculating -------------------------------------
Time.parse 6.640k i/100ms
Time.new 15.082k i/100ms
-------------------------------------------------
Time.parse 71.915k (± 3.1%) i/s - 365.200k
Time.new 167.645k (± 3.3%) i/s - 844.592k
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
- Test should call `to_unsafe_h` instead of `to_h`
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add AC::Parameters#include?
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Fixes #22818
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
is not a valid type
Closes #22747
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Add #== back to ActionDispatch::MiddlewareStack::Middleware
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This was causing bug #22738 to occur. Also added extra tests to make
sure everything is A-OK.
|
|/ / / /
| | | |
| | | |
| | | | |
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Callers expect to be able to manipulate it.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the
following:
```
* No changes.
```
It is kinda confusing as there are indeed changes after it. Not a
biggie, just a small pass over the CHANGELOGs.
[ci skip]
|
|\ \ \ \
| |_|_|/
|/| | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
:tada: :beers:
|
|\ \ \ \
| | | | |
| | | | | |
Fix "instance variable not initialized" in tests
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The ActionPack test suite had a handful of these warnings when run. This
was due to `assert_response` being tested outside the context of a
controller instance where those instance variables would already have
been initialized.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Prevent ActionController::Parameters in url_for
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Still more to do. Please assist!
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If you're not familiar with how the `Referer` header works, you likely
won't understand why you need to provide a fallback or under what
circumstances it would be used.
Hopefully this clarifies things a bit.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When calling `to_h` on an `ActionController::Parameters` instance it would
`deep_dup` its internal parameters.
This inadvertently called `dup` on a passed Active Record model which would
create new models. Fix by only dupping Ruby's Arrays and Hashes.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Applications that use `redirect_to :back` can be forced to 500 by
clients that do not send the HTTP `Referer` (sic) header.
`redirect_back` requires the user to consider this possibility up front
and avoids this trivially-caused application error.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`redirect_to :back` is a somewhat common pattern in Rails apps, but it
is not completely safe. There are a number of circumstances where HTTP
referrer information is not available on the request. This happens often
with bot traffic and occasionally to user traffic depending on browser
security settings.
When there is no referrer available on the request, `redirect_to :back`
will raise `ActionController::RedirectBackError`, usually resulting in
an application error.
`redirect_back` takes a required `fallback_location` keyword argument
that specifies the redirect when the referrer information is not
available. This prevents 500 errors caused by
`ActionController::RedirectBackError`.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Delete dead code comments
|
| | | | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Deprecate passing string to define callback.
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Handle tab in token authentication header.
|