aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | `Http::Headers` directly modifies the passed environment.Yves Senn2013-03-155-12/+48
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to #9700.
* | | | | Handle conditional get in live requests - this will prevent error when using ↵Bernard Potocki2013-03-142-0/+19
| | | | | | | | | | | | | | | | | | | | stale on live streams(issue #9636)
* | | | | Add extra clarifying line in docs. [ci skip]Steve Klabnik2013-03-131-0/+1
| | | | |
* | | | | Fix docs: response -> request.Steve Klabnik2013-03-131-2/+2
| | | | | | | | | | | | | | | | | | | | Even though I read it carefully, my brain tricked me. :cry:
* | | | | Merge pull request #9698 from garethrees/request_documentationSteve Klabnik2013-03-131-0/+16
|\ \ \ \ \ | | | | | | | | | | | | Add documentation to ActionDispatch::Request
| * | | | | Add documentation to ActionDispatch::RequestGareth Rees2013-03-131-0/+16
| | | | | |
* | | | | | `Http::Headers` respects dotted env vars, symbols, headers with numbers.Yves Senn2013-03-132-11/+33
| | | | | |
* | | | | | allow headers and env to be passed in `IntegrationTest`.Yves Senn2013-03-135-36/+119
| | | | | | | | | | | | | | | | | | | | | | | | Closes #6513.
* | | | | | refactor, `Http::Headers` stores headers in env notationYves Senn2013-03-132-29/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also: cleanup, use consistent syntax for `Http::Header` and test.
* | | | | | Http::Headers respects headers that are not prefixed with HTTP_Yves Senn2013-03-133-7/+30
| | | | | |
* | | | | | Change from each to each_value in http/parameters since we don't use keyVipul A M2013-03-131-1/+1
|/ / / / /
* | | | | Skip fetching path if the iteration is going to be skippedCarlos Antonio da Silva2013-03-111-2/+2
| | | | |
* | | | | Change from each to each_value on hash to avoid unused variable warningVipul A M2013-03-111-1/+1
| | | | |
* | | | | Merge pull request #9626 from dasch/dasch/instrument-strong-paramsJosé Valim2013-03-092-1/+7
|\ \ \ \ \ | | | | | | | | | | | | Use AS::Notifications to instrument Strong Params
| * | | | | Use the instrumentation framework to instrument Strong ParamsDaniel Schierbeck2013-03-072-1/+7
| | | | | |
* | | | | | Use "Fixes" in place of "Fix" in changelogs for consistency [ci skip].Yves Senn2013-03-091-11/+11
| |_|_|/ / |/| | | |
* | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-101-1/+1
|\ \ \ \ \
| * | | | | Update capture_helper.rbJess Brown2013-03-061-1/+1
| | |/ / / | |/| | | | | | | | if there's content for the right column, then we need the two-column class, if not the one-column
* | | | | ensure response.stream is closedSam Ruby2013-03-091-0/+1
| | | | |
* | | | | Fix incorrectly appended square brackets to a multiple select boxOlek Janiszewski2013-03-083-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an explicit name has been given and it already ends with "[]" Before: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][][]" ...> After: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][]" ...>
* | | | | Fix warningsCarlos Antonio da Silva2013-03-071-2/+2
| | | | |
* | | | | Fix hash spaces and use 1.9 style hash [ci skip]Carlos Antonio da Silva2013-03-071-1/+1
| | | | |
* | | | | Move AP changelog entry to the top [ci skip]Carlos Antonio da Silva2013-03-071-6/+6
| | | | |
* | | | | Merge pull request #9464 from jcoyne/assert_template_fileRafael Mendonça França2013-03-075-2/+59
|\ \ \ \ \ | | | | | | | | | | | | Allow use of assert_template with the :file option.
| * | | | | Allow use of assert_template with the :file option.Justin Coyne2013-03-015-2/+59
| | | | | | | | | | | | | | | | | | | | | | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1
* | | | | | Merge pull request #9586 from robertomiranda/useless_trRafael Mendonça França2013-03-061-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Change useless tr to gsub
| * | | | | | Change useless tr to gsubrobertomiranda2013-03-061-2/+2
| | | | | | |
* | | | | | | Typo in comment to ActionView::Resolver#find_allRKushnir2013-03-061-1/+1
| |_|_|/ / / |/| | | | |
* | | | | | Add missing require to debug helper testCarlos Antonio da Silva2013-03-051-2/+2
|/ / / / /
* | | | | Add DebugHelperTestrobertomiranda2013-03-051-0/+8
| | | | |
* | | | | Use gsub intead of tr when the to_str is longer than the from_strrobertomiranda2013-03-051-1/+1
| |/ / / |/| | |
* | | | change useless gsub to trrobertomiranda2013-03-054-5/+5
| | | |
* | | | Merge pull request #9561 from ↵Carlos Antonio da Silva2013-03-051-1/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | inossidabile/explicit_match_via_requirement_exception_message Routing match `via` option requirement exception message made more explicit
| * | | | Routing match `via` option requirement exception message made more explicitBoris Staal2013-03-051-1/+2
| | |_|/ | |/| |
* / | | change useless gsub to deleteBenjamin Sullivan2013-03-051-1/+1
|/ / /
* | | Fix formats on xhr requests when HTTP_ACCEPT is empty stringmaximerety2013-03-042-1/+6
| | | | | | | | | | | | | | | | | | Fix ActionDispatch::Request#formats on xhr requests when HTTP_ACCEPT header is empty string. About issue #7774, same fix as in commit bebb02f but for xhr requests.
* | | Use custom visitor class for optimized url helpersAndrew White2013-03-034-9/+19
|/ / | | | | | | | | | | | | | | Rather than trying to use gsub to remove the optional route segments, which will fail with nested optional segments, use a custom visitor class that returns a empty string for group nodes. Closes #9524
* | Improve the CHANGELOG entryRafael Mendonça França2013-02-281-2/+6
| | | | | | | | [ci skip]
* | Merge pull request #9366 from killthekitten/fix-content_for-regressionRafael Mendonça França2013-02-283-1/+7
|\ \ | | | | | | Fix for #9360 content_for regression
| * | Fix #9360 regression in content_forNikolay Shebanov2013-02-253-1/+7
| | |
* | | Minor changelog improvement [ci skip]Carlos Antonio da Silva2013-02-281-1/+1
| | |
* | | Remove redundant methodAndrew White2013-02-281-8/+0
| | |
* | | `format: true` does not override existing format constraints.Yves Senn2013-02-273-1/+35
| | | | | | | | | | | | | | | | | | | | | Closes #9466. Passing `format: true` used to override the constraints: { format: /json/ } with `/.+/`. This patch only sets the format if there is no constraint present.
* | | Improve docs for AbsC::RenderingJosé Valim2013-02-271-3/+11
| | |
* | | Merge pull request #9218 from Fivell/masterCarlos Antonio da Silva2013-02-271-0/+14
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix calculation of db_runtime property in ActiveRecord::Railties::ControllerRuntime#cleanup_view_runtime. Previously, after raising ActionView::MissingTemplate, db_runtime was not populated. Closes #9218, Fixes #9215. Conflicts: activerecord/CHANGELOG.md
| * | | fix db_runtime attribute value after raising ActionView::MissingTemplate ↵Igor2013-02-271-0/+14
| | | | | | | | | | | | | | | | exception
* | | | cleanup AP number_helpers_testYves Senn2013-02-271-47/+47
| | | | | | | | | | | | | | | | | | | | | | | | * use 1.9 style hash syntax * don't use brances on assert_equal * prefere " over '
* | | | remove duplicated number_helper tests in AP. They are already in AS.Yves Senn2013-02-271-270/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With 155cd5e6 the number_helpers were moved into AS all the tests were copied over but the tests in AP were not deleted. This is confusing. I removed all duplicated tests and reorganized the tests in AP to only test the functionality, that is added in AP.
* | | | Merge pull request #9452 from frodsan/remove_private_attribute_warningSteve Klabnik2013-02-261-1/+3
|\ \ \ \ | | | | | | | | | | remove private attribute? warning
| * | | | remove private attribute? warningFrancesco Rodriguez2013-02-261-1/+3
| | | | |