Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | This test is invalid for new router | Łukasz Strzałkowski | 2010-09-05 | 1 | -20/+0 |
| | |||||
* | Removed deprecated_mapper - we don't need it anymore | Łukasz Strzałkowski | 2010-09-05 | 1 | -525/+0 |
| | |||||
* | Removed tests for setting default value of *path in route | Łukasz Strzałkowski | 2010-09-05 | 1 | -25/+0 |
| | | | | If we want to have this - we have to change Rack::Mount source | ||||
* | Made test_generate pass | Łukasz Strzałkowski | 2010-09-05 | 1 | -9/+1 |
| | | | | I've removed assertions with @routes.generate(:use_route => ...). I'm not 100% sure if not supporting :use_route in new router is intentional or it should rather be supported and backported from 2.3.x. | ||||
* | If it's unused there's no reason to keep it commented. It will always remain ↵ | Łukasz Strzałkowski | 2010-09-05 | 1 | -11/+0 |
| | | | | in git history, so removing it. | ||||
* | Ported missing functionality from Rails 2.3.x, raise error on wrong regexps ↵ | Piotr Sarnacki | 2010-09-05 | 1 | -0/+9 |
| | | | | in :constraints in routes | ||||
* | Fixed routes to use new API in a few more actionpack tests | Piotr Sarnacki | 2010-09-05 | 5 | -18/+56 |
| | |||||
* | Removed rest of errors and failures in routing_test.rb. Almost all squashed, ↵ | Łukasz Strzałkowski | 2010-09-05 | 1 | -92/+79 |
| | | | | only few left | ||||
* | raise error on invalid HTTP methods or :head passed with :via in routes | Piotr Sarnacki | 2010-09-05 | 2 | -1/+10 |
| | |||||
* | Implemented resources :foos, :except => :all option | Piotr Sarnacki | 2010-09-05 | 2 | -5/+20 |
| | |||||
* | Test for recognizing routes with http method set | Łukasz Strzałkowski | 2010-09-05 | 1 | -1/+40 |
| | |||||
* | Fixed about half of broken tests in routing_test | Łukasz Strzałkowski | 2010-09-05 | 1 | -125/+82 |
| | |||||
* | Fixed almost all resources tests | Piotr Sarnacki | 2010-09-05 | 1 | -159/+213 |
| | |||||
* | Fixed url_for test | Łukasz Strzałkowski | 2010-09-05 | 1 | -1/+1 |
| | | | | Added route which matches all: controller, action, id and format | ||||
* | Revert "Extended default route for match in tests - now it matches ↵ | Łukasz Strzałkowski | 2010-09-05 | 1 | -2/+2 |
| | | | | | | controller, action, id and format if given." This reverts commit 05e9d0df0dea68ca4655aa8723c3ee69049fac78. | ||||
* | Extended default route for match in tests - now it matches controller, ↵ | Łukasz Strzałkowski | 2010-09-05 | 1 | -2/+2 |
| | | | | | | action, id and format if given. This fixes url_for tests | ||||
* | Removed deprecated RouteSet API, still many tests fail | Piotr Sarnacki | 2010-09-05 | 34 | -606/+567 |
| | |||||
* | Do not use ActionController::Base.page_cache_extension in initialize to not ↵ | Piotr Sarnacki | 2010-09-04 | 1 | -4/+8 |
| | | | | load more ActiveSupport than we need | ||||
* | Optimize ActionDispatch::Static | Piotr Sarnacki | 2010-09-04 | 1 | -51/+35 |
| | |||||
* | Forgot to move that line to railtie on rebase | Piotr Sarnacki | 2010-09-03 | 1 | -1/+1 |
| | |||||
* | Implemented RouteSet#default_scope, which allows to set the scope for the ↵ | Piotr Sarnacki | 2010-09-03 | 3 | -2/+41 |
| | | | | entire routes object | ||||
* | Remove namespace for isolated namespaced models in forms | Piotr Sarnacki | 2010-09-03 | 3 | -5/+37 |
| | |||||
* | Use new ActiveModel::Naming.route_key in polymorphic_routes | Piotr Sarnacki | 2010-09-03 | 2 | -12/+3 |
| | |||||
* | Add short note on using url_for instead of directly calling named route in ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -0/+3 |
| | | | | polymorphic_url | ||||
* | Add possibility to explicitly call engine's routes through ↵ | Piotr Sarnacki | 2010-09-03 | 2 | -1/+28 |
| | | | | polymorphic_routes, for example: polymorphic_url([blog, @post]) | ||||
* | Move RoutesProxy to separate file | Piotr Sarnacki | 2010-09-03 | 3 | -32/+36 |
| | |||||
* | Include all helpers from non-namespaced engines | Piotr Sarnacki | 2010-09-03 | 1 | -9/+3 |
| | |||||
* | Set only helpers_path on inherited hook in action_controller/railtie.rb and ↵ | Piotr Sarnacki | 2010-09-03 | 3 | -9/+11 |
| | | | | use helper(:all) just after that | ||||
* | Added more tests for polymorphic_url with namespaced models and implemented ↵ | Piotr Sarnacki | 2010-09-03 | 2 | -5/+66 |
| | | | | missing use cases | ||||
* | This was used only to clear warning in ActionMailer tests, it shouldn't be ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -5/+0 |
| | | | | done like that | ||||
* | Moved ActionMailer and ActionController railties options to inherited hook | Piotr Sarnacki | 2010-09-03 | 3 | -16/+32 |
| | | | | | | | | | | | This change is needed, because we must take namespace into account and if controller's/mailer's class is namespaced, engine's paths should be set instead of application's ones. The nice side effect of this is removing unneeded logic in ActionController::Base.inherited - now the helpers_path should be set correctly even for engine's controllers, so helper(:all) will always include correct helpers. | ||||
* | Modified polymorphic_url to check for model's namespace | Piotr Sarnacki | 2010-09-03 | 1 | -0/+4 |
| | | | | | | | | | | | This change allows using namespaced models with polymorphic_url, in the way that you would use them without namespace. Let's say that you have Blog::Post model in namespaced Engine. When you use polymorphic_path with Blog::Post instances, like in form_for(@post), it will look for blog_posts_path named url helper. As we are inside Blog::Engine, it's annoying to always use the prefix. With this commit, blog_ prefix will be removed and posts_path will be called. | ||||
* | Refactor RoutesProxy to avoid using _with_routes in helpers | Piotr Sarnacki | 2010-09-03 | 3 | -4/+10 |
| | |||||
* | Refactor ActionMailer to not use hide_actions | Piotr Sarnacki | 2010-09-03 | 4 | -15/+36 |
| | |||||
* | Move ActionController::Railties::RoutesHelpers and ↵ | Piotr Sarnacki | 2010-09-03 | 2 | -5/+6 |
| | | | | ActionMailer::Railties::RoutesHelper to AbstractController::Railties::RoutesHelpers | ||||
* | Fix generating urls with mounted helpers in view context | Piotr Sarnacki | 2010-09-03 | 3 | -3/+5 |
| | | | | | | | | | | There were actually 2 problems with this one: * script_name was added to options as a string and then it was used in RouteSet#url_for with usage of <<, which was changing the original script_name * the second issue was with _with_routes method. It was called in RoutesProxy to modify _routes in view_context, but url_helpers in views is just delegating it to controller, so another _with_routes call is needed there | ||||
* | Include application's helpers and router helpers by default, but include ↵ | Piotr Sarnacki | 2010-09-03 | 4 | -4/+30 |
| | | | | engine's ones for controllers inside isolated namespace | ||||
* | For view_context we need to initialize RoutesProxy in context of controller, ↵ | Piotr Sarnacki | 2010-09-03 | 1 | -2/+4 |
| | | | | not view, quick fix, I need to dig into it later | ||||
* | This is not needed | Piotr Sarnacki | 2010-09-03 | 1 | -26/+0 |
| | |||||
* | Modified ActionDispatch::Static to allow passing multiple roots | Piotr Sarnacki | 2010-09-03 | 6 | -21/+104 |
| | |||||
* | Add Rails::Railtie.railtie_name method to allow setting custom name for railtie | Piotr Sarnacki | 2010-09-03 | 1 | -2/+7 |
| | |||||
* | to_param shoul return a string | Piotr Sarnacki | 2010-09-03 | 1 | -1/+1 |
| | |||||
* | We don't need delegating polymorphic_url and polymorphic_path anymore | Piotr Sarnacki | 2010-09-03 | 1 | -10/+6 |
| | |||||
* | Added ability to set asset_path for engines | Piotr Sarnacki | 2010-09-03 | 3 | -1/+27 |
| | |||||
* | Ensure that url_helpers included after application's ones have higher priority | Piotr Sarnacki | 2010-09-03 | 1 | -0/+15 |
| | |||||
* | Add mounted_helpers to routes | Piotr Sarnacki | 2010-09-03 | 8 | -90/+168 |
| | | | | | | | | | | | | | | | | mounted_helpers are a bit similar to url_helpers. They're automatically included in controllers for Rails.application and each of mounted Engines. Mounted helper allows to call url_for and named helpers for given application. Given Blog::Engine mounted as blog_engine, there are 2 helpers defined: app and blog_engine. You can call routes for app and engine using those helpers: app.root_url app.url_for(:controller => "foo") blog_engine.posts_path blog_engine.url_for(@post) | ||||
* | Routes refactoring: | Piotr Sarnacki | 2010-09-03 | 4 | -55/+77 |
| | | | | | | | * added more tests for prefix generation * fixed bug with generating host for both prefix and url * refactored url_for method * organized tests for prefix generation | ||||
* | Use new url_for API instead of including routes.url_helpers | Piotr Sarnacki | 2010-09-03 | 1 | -3/+2 |
| | |||||
* | Ensure that env is always available in controllers | Piotr Sarnacki | 2010-09-03 | 2 | -2/+6 |
| | |||||
* | Extended url_for to handle specifying which router should be used. | Piotr Sarnacki | 2010-09-03 | 7 | -80/+136 |
| | | | | | | | A few examples: url_for Blog::Engine, :posts_path url_for Blog::Engine, @post url_for Blog::Engine, :action => "main", :controller => "index" |