aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | remove select, collect and then inject withNeeraj Singh2010-11-221-1/+1
| | | | | | | | | | | | something better Signed-off-by: José Valim <jose.valim@gmail.com>
* | string include method is 10x faster than creatingNeeraj Singh2010-11-221-1/+1
| | | | | | | | | | | | a new regex object every single time Signed-off-by: José Valim <jose.valim@gmail.com>
* | Compile regex only onceNeeraj Singh2010-11-221-3/+5
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | move the mime registration code to setup so thatNeeraj Singh2010-11-221-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | it could be cleaned up on teardown. Currently the test code test/controller/mime_responds_test.rb impacts test/dispatch/mime_type_test.rb. dispatch/mime_type_test.rb runs independently fine but when run as part of rake breaks because of new mime types registered in controller/mime_responds_test.rb Signed-off-by: José Valim <jose.valim@gmail.com>
* | rename star star to just one starNeeraj Singh2010-11-221-3/+3
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | cleanup Mime::LOOKUP after registering image/gifNeeraj Singh2010-11-221-0/+1
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | fix testNeeraj Singh2010-11-221-3/+3
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | implement code that handles text/*, appplication/*,Neeraj Singh2010-11-221-1/+16
| | | | | | | | | | | | and image/* Signed-off-by: José Valim <jose.valim@gmail.com>
* | test for text/*, application/* and image/*Neeraj Singh2010-11-221-1/+27
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | declare regex as a constantNeeraj Singh2010-11-221-1/+3
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | add the fixture fileNeeraj Singh2010-11-221-0/+1
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | do not assume that there is no space betweenNeeraj Singh2010-11-222-1/+5
| | | | | | | | | | | | leading */* and comma Signed-off-by: José Valim <jose.valim@gmail.com>
* | failing test for #6022Neeraj Singh2010-11-221-0/+34
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | current code ignores http header "Accept" if itNeeraj Singh2010-11-222-1/+7
| | | | | | | | | | | | | | | | | | | | | | has ....,*/* . It is possible to a device to send request such that */* appear at the beginning of the "Accept" header. This patch ensures that "Accept" header is ignored for such cases too. Signed-off-by: José Valim <jose.valim@gmail.com>
* | Remove unused constantSantiago Pastorino2010-11-221-2/+0
| |
* | There's no need for ternary op hereSantiago Pastorino2010-11-221-1/+1
| |
* | Remove unneeded metaprogramming and method generation in favor of direct ↵Santiago Pastorino2010-11-221-24/+10
| | | | | | | | definition
* | realigns a series of hash arrowsXavier Noria2010-11-211-10/+10
| |
* | use_accept_header is no longer supportedNeeraj Singh2010-11-211-1/+1
| |
* | Mention the case that `render` will return nil if given `:collection` is nil ↵Prem Sichanugrist2010-11-211-0/+5
| | | | | | | | or empty when rendering partial.
* | Ensure calling reset session twice does not raise errors.José Valim2010-11-201-0/+12
| |
* | class inheritable attributes is used no more! all internal use of class ↵Josh Kalderimis2010-11-203-6/+8
| | | | | | | | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com>
* | Fix indentationSantiago Pastorino2010-11-201-24/+23
| |
* | Avoid range object creationSantiago Pastorino2010-11-201-1/+1
| |
* | do not require ruby-debug automatically. please require it if you have ↵Aaron Patterson2010-11-191-8/+0
| | | | | | | | declared it as a dependency
* | Fix AssetIncludeTag ensuring that files are in the wrong directory [#6015 ↵Henning Koch2010-11-192-3/+47
| | | | | | | | | | | | state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | Fix indentationSantiago Pastorino2010-11-191-1/+1
| |
* | Don't merge just directly add to the action to the :partial keySantiago Pastorino2010-11-191-1/+1
| |
* | Useless assignationSantiago Pastorino2010-11-191-1/+1
| |
* | Revert "Quick fix for not escaping []s (not ideal)"Santiago Pastorino2010-11-181-3/+3
| | | | | | | | | | | | | | | | | | According to http://www.ietf.org/rfc/rfc2616.txt and http://tools.ietf.org/rfc/rfc3986.txt [ and ] are reserved characters and should be escaped using "%" HEX HEX This reverts commit 856d2fd874d72dd9f83204affff4edfef3308361 and 1ee9b40b18a0bed5bb10a0785f7e2730bac983f6..
* | Revert "Remove deprecated form_for with strings or symbols"José Valim2010-11-184-8/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code was not deprecated. What was deprecated is the following: form_for(:foo, @foo) Which now should be rewritten as: form_for(@foo, :as => :foo) The following format is valid: form_for(:foo) This reverts commit be797750e6ce866ea08307f63bf35304a965c8d4.
* | Remove deprecated form_for with strings or symbolsLeonardo Capillera2010-11-184-44/+8
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | delegating path and open to internal tempfileAaron Patterson2010-11-182-2/+20
| |
* | Added config.action_controller.include_all_helpers to CHANGELOG.Piotr Sarnacki2010-11-181-0/+2
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* | Add config.action_controller.include_all_helpers, by default it is set to true.Piotr Sarnacki2010-11-182-2/+5
| | | | | | | | | | | | | | In older rails versions there was a way to use only helpers from helper file corresponding to current controller and you could also include all helpers by saying 'helper :all' in controller. This config allows to return to older behavior by setting it to false.
* | Pass the view object as parameter to the handler. Useful if you need to ↵José Valim2010-11-172-1/+11
| | | | | | | | access the lookup context or other information when compiling the template.
* | fix warning during test executionNeeraj Singh2010-11-171-1/+1
| | | | | | | | | | | | [#5997 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | Bump builder to 3.0.0Santiago Pastorino2010-11-171-1/+1
| |
* | Anchors should be allowed on constraints that are not on path segmentsCarl Lerche2010-11-162-9/+20
| |
* | Update the version.rb files to include a PRE partCarl Lerche2010-11-161-2/+2
| |
* | Brought the domain method in AD http url inline with subdomain where ↵Josh Kalderimis2010-11-162-1/+5
| | | | | | | | @@tld_length is used by default. Also set the default value of @@tld_length to 1.
* | changed asset_timestamps_cache to asset_ids_cache, added an rdoc comment to ↵Josh Kalderimis2010-11-162-17/+21
| | | | | | | | the new public api, and updated the railtie
* | corrected the AV railtie to use the new home for cache_asset_timestamps, and ↵Josh Kalderimis2010-11-164-75/+47
| | | | | | | | merged asset id caching and asset paths together.
* | reorganised the the common asset helpers module into a class and have it ↵Josh Kalderimis2010-11-166-125/+128
| | | | | | | | include the id caching module, this class is now shared from the view instance to the asset include tag helpers (js and css)
* | incorporated most of the feedback from JoséJosh Kalderimis2010-11-167-290/+281
| |
* | reduced duplication between the javascript and stylesheet asset tag methods, ↵Josh Kalderimis2010-11-168-264/+312
| | | | | | | | also split the asset id caching methods into a separate module for easy inclusion and use by the asset include tag class and base asset tag helpers
* | removed an assert from a test as it was testing a private methodJosh Kalderimis2010-11-161-1/+0
| |
* | separated the asset id methods to a separate module, removed some dupliation ↵Josh Kalderimis2010-11-166-413/+486
| | | | | | | | with the various path methods, and moved the base asset tag methods to a base module so the asset id module can play nice with the path generation
* | split the javascript and stylesheet tag helpers into separate files as a ↵Josh Kalderimis2010-11-163-313/+348
| | | | | | | | precusor before removing the duplication between the two
* | rejecting blank stringsAaron Patterson2010-11-151-2/+2
| |