Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Added NodeSet comparison to possible root element in determine_root_from. | Timm | 2014-06-16 | 1 | -1/+1 |
| | |||||
* | Changed html_document to use fragments. Changed response_from_page to be an ↵ | Timm | 2014-06-16 | 1 | -6/+3 |
| | | | | alias of html_document. | ||||
* | Changed xml_namespace test to correct syntax. However, Nokogiri won't ↵ | Timm | 2014-06-16 | 1 | -2/+3 |
| | | | | recognize the namespace. | ||||
* | Fixed bug by switching to Loofah fragment instead of document. | Timm | 2014-06-16 | 1 | -2/+2 |
| | |||||
* | Changed test methods to use new substitution syntax more in line with css ↵ | Timm | 2014-06-16 | 1 | -3/+3 |
| | | | | selectors. | ||||
* | Changed css_select to not count on multiple selectors. Fixed bug in ↵ | Timm | 2014-06-16 | 1 | -8/+10 |
| | | | | determine_root_from where @selected was an Array. Changed assert_select_encoded to use a fragment instead of a document. | ||||
* | Added a proper substitution context class. Changed ArgumentFilter to be a ↵ | Timm | 2014-06-16 | 1 | -34/+47 |
| | | | | selector. It is now called HTMLSelector. | ||||
* | Fixed nested assert_select bug. Trying to create a full document for a ↵ | Timm | 2014-06-16 | 1 | -1/+1 |
| | | | | nested call that already had a document. | ||||
* | Added implementation for substitution values via Nokogiri's custom pseudo ↵ | Timm | 2014-06-16 | 1 | -5/+35 |
| | | | | classes. | ||||
* | Readded some documentation about substitution values. | Timm | 2014-06-16 | 1 | -2/+12 |
| | |||||
* | Fixed typo in method name. Fixed Nokogiri::CSS::SyntaxError. | Timm | 2014-06-15 | 1 | -2/+2 |
| | |||||
* | Updated documentation to remove mention of HTML::Selector and clarify what ↵ | Timm | 2014-06-15 | 1 | -21/+9 |
| | | | | is expected of a selector now. | ||||
* | Changed tests to assert_kind_of Loofah::HTML::Document. | Timm | 2014-06-15 | 1 | -3/+3 |
| | |||||
* | Readded html_document method since it is used integration tests. | Timm | 2014-06-15 | 1 | -1/+5 |
| | |||||
* | Removed selector_test.rb since HTML::Selector will be removed. Soon. | Timm | 2014-06-15 | 1 | -629/+0 |
| | |||||
* | Changed filter_matches to return a new NodeSet instead of Array. | Timm | 2014-06-15 | 1 | -1/+2 |
| | |||||
* | Fixed Nokogiri::CSS::SyntaxErrors. | Timm | 2014-06-15 | 1 | -2/+2 |
| | | | | Fixed a Nokogiri::CSS::SyntaxError by using its expected format for unicode characters. | ||||
* | Initialized @css_selector_is_second_argument in determine_root_from. | Timm | 2014-06-15 | 1 | -0/+1 |
| | |||||
* | Changed early return for filter_matches as well as reassigning matches. ↵ | Timm | 2014-06-15 | 1 | -6/+6 |
| | | | | Meddled with initialize in ArgumentFilter. | ||||
* | Removed redundant comments from assert_select. | Timm | 2014-06-15 | 1 | -3/+1 |
| | | | | Cleaned up a comment. | ||||
* | Added assert_size_match! with the assertions for assert_select. | Timm | 2014-06-15 | 1 | -14/+18 |
| | |||||
* | Changed some documentation for css_select. | Timm | 2014-06-15 | 1 | -1/+1 |
| | |||||
* | Replaced fragment calls with document, since we assume the responses are ↵ | Timm | 2014-06-15 | 1 | -9/+8 |
| | | | | complete documents. | ||||
* | Added filter_matches to reduce line count in assert_select. | Timm | 2014-06-15 | 1 | -24/+19 |
| | |||||
* | Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵ | Timm | 2014-06-15 | 1 | -59/+39 |
| | | | | ArgumentFilter. | ||||
* | Removed the custom selected proc. It's no longer needed. | Timm | 2014-06-15 | 1 | -10/+8 |
| | |||||
* | Updated selector to not have reponse_from_page. | Timm | 2014-06-15 | 1 | -5/+6 |
| | |||||
* | Changed css_select and pulled out response_from_page from Selector. | Timm | 2014-06-15 | 1 | -23/+17 |
| | |||||
* | Changed comparison from HTML::Node to Nokogiri::XML::Node in ↵ | Timm | 2014-06-15 | 1 | -1/+1 |
| | | | | assert_select_encoded. | ||||
* | Removed more redundant lines. Removed fix_content block that circumvented a ↵ | Timm | 2014-06-15 | 1 | -7/+1 |
| | | | | bug in html-scanner. | ||||
* | Removed more lines of code in assert_select. | Timm | 2014-06-15 | 1 | -7/+6 |
| | |||||
* | Simplified the first delete_if loop in assert_select to use Loofah's text ↵ | Timm | 2014-06-15 | 1 | -14/+13 |
| | | | | method. | ||||
* | Removed argument and root variable in assert_select proc. | Timm | 2014-06-15 | 1 | -4/+2 |
| | |||||
* | Changed name to selector. And a bunch of other things. | Timm | 2014-06-15 | 1 | -60/+51 |
| | |||||
* | The first attempt at abstracting argument parsing from selection methods. | Timm | 2014-06-15 | 1 | -81/+114 |
| | |||||
* | Removed tag.rb since it has been deprecated. | Timm | 2014-06-15 | 4 | -321/+0 |
| | |||||
* | Corrected documentation bug. | Timm | 2014-06-15 | 1 | -10/+57 |
| | |||||
* | Removed whitespace between dependencies. | Timm | 2014-06-15 | 1 | -0/+1 |
| | |||||
* | Added Loofah as a dependency in actionview.gemspec. | Timm | 2014-06-11 | 2 | -9/+11 |
| | | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah. | ||||
* | Merge pull request #15545 from zuhao/refactor_actionpack_assert_select_test | Yves Senn | 2014-06-08 | 1 | -1/+4 |
|\ | | | | | Restore test deliveries for ActionMailer. | ||||
| * | Restore test deliveries for ActionMailer. | Zuhao Wan | 2014-06-07 | 1 | -1/+4 |
| | | |||||
* | | Handle client disconnect during live streaming | Matthew Draper | 2014-06-08 | 4 | -13/+189 |
| | | | | | | | | .. even when the producer is blocked for a write. | ||||
* | | adds some details to the rationale of converted_arrays [ci skip] | Xavier Noria | 2014-06-07 | 2 | -1/+5 |
| | | |||||
* | | adds a regression test for the strong params converted arrays cache | Xavier Noria | 2014-06-07 | 1 | -1/+18 |
| | | | | | | | | This is a regression test for 29844dd. | ||||
* | | Revert "Convert StrongParameters cache to a hash. This fixes an unbounded" | Xavier Noria | 2014-06-07 | 2 | -7/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot cache keys because arrays are mutable. We rather want to cache the arrays. This behaviour is tailor-made for the usage pattern strongs params is designed for. In a forthcoming commit I am going to add a test that covers why we need to cache by value. Every strong params instance has a live span of a request, the cache goes away with the object. Since strong params have such a concrete intention, it would be interesting to see if there are actually any real-world use cases that are an actual leak, one that practically may matter. I am not convinced that the theoretical leak has any practical consequences, but if it can be shown there are, then I believe we should either get rid of the cache (which is an optimization), or else wipe it in the mutating API. This reverts commit e63be2769c039e4e9ada523a8497ce3206cc8a9b. | ||||
* | | [ci skip] Fix capitalization | Akshay Vishnoi | 2014-06-07 | 2 | -3/+3 |
| | | |||||
* | | remove another wasteful AS::SafeBuffer allocation | Aaron Patterson | 2014-06-06 | 1 | -1/+1 |
| | | |||||
* | | eliminate wasteful AS::SafeBuffer allocation | Aaron Patterson | 2014-06-06 | 1 | -1/+1 |
|/ | |||||
* | Use a frozen Set instance for CGI_VARIABLES. | Nathaniel Bibler | 2014-06-05 | 1 | -8/+21 |
| | | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility. | ||||
* | Avoid misuse of underscore argument | Corey Ward | 2014-06-05 | 1 | -2/+2 |
| | | | Per convention, underscore-only argument names should be used for unused parameters. |