aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* revises 877e42eXavier Noria2015-08-282-8/+8
| | | | | | | | | | | | | | | | | | | | | | * A string in the example lacked quotes. * The tests asserted stuff about :last_name, whereas test params do not have that key. * But, the first one passed, why? After hitting my head against the wall and doing some obscure rituals realized the new #require had an important typo, wanted to iterate over the array argument (key), but it ran over its own hash keys (method #keys). * Modified the test to prevent the same typo to happen again. * The second test assigned to an unused variable safe_params that has been therefore removed. * Grammar of the second test description. * Since I was on it, reworded both test descriptions.
* [Feature] params.require requires array of paramsGaurish Sharma2015-08-282-0/+25
| | | | | | | | | | | | | | | | | This PR adds ability to accept arrays which allows you to require multiple values in one method. so instead of this: ```ruby params.require(:person).require(:first_name) params.require(:person).require(:last_name) ``` Here it will be one line for each params, so say if I require 10params, it will be 10lines of repeated code which is not dry. So I have added new method which does this in one line: ```ruby params.require(:person).require([:first_name, :last_name]) ``` Comments welcome
* Merge pull request #21396 from rodzyn/code-cleanupGuillermo Iguaran2015-08-282-13/+2
|\ | | | | Code cleanup
| * Code cleanupMarcin Olichwirowicz2015-08-272-13/+2
| | | | | | | | | | | | | | | | Cleanup for `ActionDispatch::Http::Parameters` - no need for required libraries and remove not used private method. Apparently this method was used in `ActionDispatch::Http::Request` - fixed by calling `Request::Utils` explicitly (as was done in other parts of the codebase)
* | Revert "this always sets :public to false, so just do that"Aaron Patterson2015-08-271-1/+1
| | | | | | | | | | | | This reverts commit cae2b5bb59212961c4a35c939381ebece48d1177. I am an idiot.
* | this always sets :public to false, so just do thatAaron Patterson2015-08-271-1/+1
| |
* | remove dependency on `@cache_control` ivarAaron Patterson2015-08-271-6/+6
| | | | | | | | | | eventually we'll remove this instance variable, but this is the first step
* | remove `@etag` ivarAaron Patterson2015-08-271-5/+7
| | | | | | | | | | we're storing the value in the headers hash, so lets just store the value in one place.
* | use the abstract API in modulesAaron Patterson2015-08-272-14/+15
| | | | | | | | | | Modules should be using the API that the abstract modules use so that we can move these modules between implementations
* | remove useless conditionalAaron Patterson2015-08-271-2/+0
| | | | | | | | | | cookies are always stored as a string in the header hash, so it will not need to be joined.
* | implement the API required by the abstract Rack request.Aaron Patterson2015-08-271-16/+8
| |
* | use the non-hash dependent Rack utils APIAaron Patterson2015-08-271-2/+2
| | | | | | | | eventually we will refactor this to not know about header hashes
* | minor copy edit. [ci skip]Yves Senn2015-08-271-2/+2
| | | | | | | | Follow up to #21384.
* | Merge pull request #21384 from ↵Yves Senn2015-08-273-2/+17
|\ \ | |/ |/| | | | | jeremyf/updating-ActionController-TestSession-to-behave-as-a-hash-with-indifferent Updating TestSession to access with indifference
| * Updating TestSession to access with indifferenceJeremy Friesen2015-08-263-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following Rails code failed (with a `KeyError` exception) under test: ```ruby class ApplicationController < ActionController::Base def user_strategy # At this point: # ```ruby # session == { # "user_strategy"=>"email", # "user_identifying_value"=>"hello@world.com" # } # ``` if session.key?(:user_strategy) session.fetch(:user_strategy) end end end ``` When I checked the session's keys (`session.keys`), I got an array of strings. If I accessed `session[:user_strategy]` I got the expected `'email'` value. However if I used `session.fetch(:user_strategy)` I got a `KeyError` exception. This appears to be a Rails 4.2.4 regression (as the code works under Rails 4.2.3). Closes #21383
* | remove redefined methodAaron Patterson2015-08-261-3/+0
| | | | | | | | | | Rack::Response::Helpers implements this method, so we can safely remove it
* | Remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | | | | | | If the response method is defined, then calling `response` will return a response.
* | remove useless codeAaron Patterson2015-08-261-1/+0
| | | | | | | | | | | | | | | | | | | | If AV::Rendering is mixed in, then `rendered_format` will be calculated based on the current `lookup_context`, but calling `_process_format` will set the `rendered_format` back on to the same lookup context where we got the information in the first place! Instead of getting information from an object, then setting the same information back on to that object, lets just do nothing instead!
* | only call self.content_type= when there is a responseAaron Patterson2015-08-263-4/+18
| | | | | | | | | | Apparently the AbstractController (whatever "abstract" means) is expected to work without a request and response.
* | Pull `plain` content type handling up to `render`Aaron Patterson2015-08-262-8/+5
| | | | | | | | | | `render` is the only possible source for the `plain` option. Pulling the conditional up to the `render` method removes far away conditionals
* | stop passing the options hash to `_process_format`Aaron Patterson2015-08-262-4/+4
| | | | | | | | | | | | We don't need to pass the full hash just to pull one value out. It's better to just pass the value that the method needs to know about so that we can abstract it away from "options"
* | remove RackDelegation moduleAaron Patterson2015-08-2613-71/+16
| | | | | | | | | | | | Since all controller instances are required to have a request and response object, RackDelegation is no longer needed (we always have to delegate to the response)
* | remove useless methodAaron Patterson2015-08-261-5/+0
| | | | | | | | | | the subclass sets the body on the response object, so we don't need the superclass doing it too
* | include ActionView::Rendering in the minimal controllerAaron Patterson2015-08-262-1/+2
| | | | | | | | without this module, the content type is not set correctly
* | Merge pull request #21387 from ronakjangir47/remove_dup_minitestKasper Timm Hansen2015-08-261-1/+0
|\ \ | | | | | | Removed duplicate require 'minitest/mock'
| * | Removed duplicate requiring minitest/mock as it is already required in ↵Ronak Jangir2015-08-261-1/+0
| |/ | | | | | | method_call_assertions
* | `headers` should delegate to the response objectAaron Patterson2015-08-261-1/+2
| |
* | remove useless status setAaron Patterson2015-08-261-2/+0
| | | | | | | | | | | | Now that `Controller#status=` just delegates to the response object, we don't need to set the response on the controller and the response. We can just set it in one place.
* | remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | | | | we always have a response object, so there is no reason to test it
* | remove ivars from the "protected" listAaron Patterson2015-08-261-1/+1
| | | | | | | | these ivars don't exist anymore, so we can remove them from the list
* | use the content_type method on the request objectAaron Patterson2015-08-261-1/+1
| | | | | | | | | | since the controller always has a request on it, we can just ask the request for the content type.
* | ask the response for the statusAaron Patterson2015-08-261-3/+2
| | | | | | | | | | | | The controller instance always has an instance of a response object. We should store the status code on the response object so that it's only store in one place.
* | remove useless conditionalAaron Patterson2015-08-261-1/+1
| | | | | | | | | | We always have a response object in controller instances, so we can remove this conditional
* | remove useless conditionalAaron Patterson2015-08-261-1/+1
|/ | | | | controller instances always have a response object, so we don't need to test to see if there is one, just always call to_a on the response.
* provide a request and response to all controllersAaron Patterson2015-08-2510-39/+49
| | | | | | | | | | Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
* :snip: whitespaceAaron Patterson2015-08-251-2/+2
|
* Fix another rack SPEC violationAaron Patterson2015-08-251-1/+1
|
* rack SPEC doesn't allow `first` on the bodyAaron Patterson2015-08-251-8/+12
| | | | collect the body and make assert against the collected body
* move response allocation to the class levelAaron Patterson2015-08-252-8/+22
| | | | | | we don't need an instance to figure out what type of response to allocate. Later we'll pull this up the stack and pass the response object down
* adding a direct dispatch method to controller classesAaron Patterson2015-08-253-9/+13
| | | | This saves a lambda and request allocation on each request.
* always dispatch to controllers the same wayAaron Patterson2015-08-253-7/+26
| | | | | controllers should always go through the `action` class method so that their middleware is respected.
* always return a controller class from the `controller_class` methodAaron Patterson2015-08-252-9/+14
| | | | | now the caller can just treat it like a regular controller even though it will return a 404
* Merge pull request #21368 from rodzyn/remove_mochaKasper Timm Hansen2015-08-255-163/+209
|\ | | | | Get rid of mocha tests in actionpack - part 2
| * Get rid of mocha tests - part 2Marcin Olichwirowicz2015-08-255-163/+209
| |
* | Merge pull request #21375 from rodzyn/unused_requiresRafael Mendonça França2015-08-251-2/+0
|\ \ | | | | | | Remove unused requires
| * | Remove unused requiresMarcin Olichwirowicz2015-08-251-2/+0
| | | | | | | | | | | | They are already required in `actionpack/lib/action_dispatch.rb` (L25-L26)
* | | Merge pull request #21366 from amitsuroliya/remove_unused_variableRafael Mendonça França2015-08-252-13/+13
|\ \ \ | |/ / |/| | Remove more unused block arguments
| * | Remove more unused block arguments amitkumarsuroliya2015-08-252-13/+13
| | |
* | | Make `assert_index` privateMarcin Olichwirowicz2015-08-251-3/+1
| | | | | | | | | | | | | | | This `protected` keyword looks like some leftover, since we are not using explicit receiver, this should go under `private`
* | | Merge pull request #21345 from aditya-kapoor/trim-apRafael Mendonça França2015-08-252-6/+4
|\ \ \ | |/ / |/| | Trim out least needed controllers from AP test suite
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 04:42:43 +0000