aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | eval_block should be privateAaron Patterson2014-07-291-0/+1
| |
* | remove the mounted? methodAaron Patterson2014-07-282-6/+2
| | | | | | | | | | we know the routes should not be "optimized" when mounting an application
* | remove some cachingAaron Patterson2014-07-281-2/+1
| | | | | | | | | | this caching doesn't increase performance, but does increase complexity. remove it for now and find better ways to speed up this code.
* | Merge pull request #16303 from rajcybage/removing_masterYves Senn2014-07-281-0/+2
|\ \ | | | | | | | | | remove empty unused method
| * | add comment to the empty each method for not removing it in futureRajarshi Das2014-07-261-1/+2
| | |
* | | Fix protect_from_forgery docsDavid Albert2014-07-271-1/+1
|/ /
* | docs, add ref where to find valid `head` status symbols.Yves Senn2014-07-251-0/+2
| | | | | | | | [ci skip]
* | Improve description of tests.Guo Xiang Tan2014-07-251-4/+4
| |
* | Bug fix for assert_template when opening a new session.Guo Xiang Tan2014-07-252-5/+49
| | | | | | | | See https://github.com/rails/rails/pull/16234#commitcomment-7115670.
* | Use PROCESS_COUNT to define the number of parallel executorsRafael Mendonça França2014-07-231-1/+1
| |
* | specify N=0 to prevent parallel tests (just run tests on the main process)Aaron Patterson2014-07-231-2/+6
| |
* | Fix AC::TemplateAssertions instance variables not resetting.Guo Xiang Tan2014-07-213-5/+66
| | | | | | | | Fixes https://github.com/rails/rails/issues/16119.
* | Merge branch 'rm-remove-mocha'Rafael Mendonça França2014-07-191-0/+2
|\ \ | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb
| * | Stop requiring mocha automaticallyRafael Mendonça França2014-07-191-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal
* | | Merge pull request #16098 from tgxworld/fixes_to_request_testRafael Mendonça França2014-07-181-22/+14
|\ \ \ | | | | | | | | Fixes to request method test.
| * | | Remove redundant test.Guo Xiang Tan2014-07-181-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we're stubbing the request, the test is actually just asserting that `@method = env['REQUEST_METHOD']`. In order to the test against the methodoverride middleware, we should test it against an actual request. However, Rack is already covering this scenario so we can remove this test.
| * | | Fix duplicated test.Guo Xiang Tan2014-07-181-2/+6
| | | | | | | | | | | | | | | | | | | | There is already another test covering Request#request_method. This test should cover Request#method.
| * | | Update test to clearly reflect what it is testing for.Guo Xiang Tan2014-07-181-5/+7
| | | |
| * | | Update outdated test.Guo Xiang Tan2014-07-181-6/+3
| |/ / | | | | | | | | | | | | The current test is asserting against an outdated version of Request#method where HEAD requests are treated as GET requests.
* | | Add CHANGELOG for #14886Arthur Neves2014-07-182-1/+6
| | | | | | | | | | | | | | | | | | | | | Also cleanup test a bit [related #14886] [related #14743]
* | | LOCALHOST definition should match any 127.0.0.0/8 addressEarl J St Sauver2014-07-183-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The entire 127.0.0.0/8 range is assigned to the loopback address, not only 127.0.0.0/24. This patch allows ActionDispatch::Request::LOCALHOST to match any IPv4 127.0.0.0/8 loopback address. The only place that the #local? method was previously under test was in the show_expectations_test.rb file. I don't particularly like that that's implicitly where this code is under test, and I feel like I should move some of that testing code into the test/dispatch/request_test.rb file, but I wanted some feedback first. Credit goes to @sriedel for discovering the issue and adding the patch.
* | | Prefer to pass block when logging.Guo Xiang Tan2014-07-181-25/+26
| | | | | | | | | | | | | | | | | | | | | | | | The Logger by default includes a guard which checks for the logging level. By removing the custom logging guards, we can decouple the logging guard from the logging action to be done. This also follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
* | | reporting is only done in one thread, so we can safely remove the lockAaron Patterson2014-07-171-1/+1
| | | | | | | | | | | | (I think)
* | | pass the test reporter by referenceAaron Patterson2014-07-171-1/+4
| | | | | | | | | | | | | | | | | | this prevents the array from being dumped as a DRbObject so we can reduce communication with the server. the reporter should always exist on the server side, so we don't have to worry about GC
* | | fix filesystem race conditionAaron Patterson2014-07-171-1/+1
| | |
* | | do not restart the service, just stop itAaron Patterson2014-07-171-1/+0
| | |
* | | only parallelize on forking systemsAaron Patterson2014-07-171-1/+1
| | |
* | | [EXPERIMENTAL] run actionpack tests in parallelAaron Patterson2014-07-171-0/+57
| | | | | | | | | | | | | | | only on forking systems though. Feel free to revert this if it causes problems.
* | | `recall` should be `path_parameters`, also make it requiredAaron Patterson2014-07-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | "recall" is a terrible name. This variable contains the parameters that we got from the path (e.g. for "/posts/1" it has :controller => "posts", :id => "1"). Since it contains the parameters we got from the path, "path_parameters" is a better name. We always pass path_parameters to `generate`, so lets make it required.
* | | pass the route name to define_url_helperAaron Patterson2014-07-173-23/+26
| | | | | | | | | | | | | | | this allows us to avoid 2 hash allocations per named helper definition, also we can avoid a `merge` and `delete`.
* | | use a strategy object for generating urls in named helpersAaron Patterson2014-07-172-21/+37
| | | | | | | | | | | | | | | | | | since we know that the route should be a path or fully qualified, we can pass a strategy object that handles generation. This allows us to eliminate an "if only_path" branch when generating urls.
* | | helper methods are public, so we can just call themAaron Patterson2014-07-171-4/+4
| | | | | | | | | | | | | | | also if you want a path from a named helper, you should call helper_path, not helper_url(:only_path => true).
* | | extract path building to a methodAaron Patterson2014-07-161-9/+11
| | |
* | | break out path building logic to methodsAaron Patterson2014-07-161-14/+22
| | |
* | | only extract :params from the options hash onceAaron Patterson2014-07-161-3/+2
| | |
* | | we do not need to dup the options hash, it is private and a new object each callAaron Patterson2014-07-161-2/+2
| | |
* | | push rails app testing upAaron Patterson2014-07-161-9/+13
| | | | | | | | | | | | this way we only have to test for whether it is a rails app once.
* | | Rails-ish apps should descend from Rails::RailtieAaron Patterson2014-07-164-14/+17
| | | | | | | | | | | | | | | Use an is_a check to ensure it's a Railsish app so we can avoid respond_to calls everywhere.
* | | app should always be a class (I suppose)Aaron Patterson2014-07-161-1/+1
| | |
* | | we should be checking if the app is a classAaron Patterson2014-07-161-1/+1
| | | | | | | | | | | | | | | Hopefully `object.class` always returns something that is_a?(Class), so the previous logic didn't really make sense.
* | | extract inner options before delegating to the helperAaron Patterson2014-07-161-7/+13
| | | | | | | | | | | | | | | If we extract the options from the user facing method call ASAP, then we can simplify internal logic.
* | | always transcode the file to utf-8Aaron Patterson2014-07-162-0/+7
| | | | | | | | | | | | | | | | | | people may be passing filenames to the constructor that are not utf-8, but they will assome that calling `original_filename` returns utf-8 (because that's what it used to do).
* | | Remove unused fixturesRafael Mendonça França2014-07-1660-98/+0
| | | | | | | | | | | | These fixtures are not used in actionpack tests.
* | | Don't accept parameters as argument for redirect to [via @homakov]Santiago Pastorino2014-07-162-0/+11
| | | | | | | | | | | | Closes #16170
* | | Fix 1.9. uggghhhhhh get it together @tenderlove :bomb:Aaron Patterson2014-07-151-2/+2
| | |
* | | fix for 1.9 kwargs syntaxAaron Patterson2014-07-151-1/+2
| | |
* | | routed applications will respond to these methodsAaron Patterson2014-07-152-2/+2
| | |
* | | stop passing recall to url_forAaron Patterson2014-07-152-37/+48
| | |
* | | rack 1.6 encodes the filenames in posts correctly nowAaron Patterson2014-07-151-8/+1
| | |
* | | fix warningsAaron Patterson2014-07-151-1/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 18:09:34 +0000