| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |/ / |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously when app was mounted as following:
class Foo
def call(env)
[200, {}, [env['PATH_INFO']]]
end
end
RackMountRailsBug::Application.routes.draw do
mount RackTest.new => "/foo"
end
trailing slash was removed from PATH_INFO. For example requesting
GET /foo/bar/
on routes defined above would result in a response containing "/foo/bar"
instead of "/foo/bar/".
This commit fixes the issue.
(closes #3215)
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
They were moved to actionview/ and are not used in actionpack
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
This commit creates structure for Action View gem and is first of a
series of commits extracting Action View from Action Pack.
|
| | |
| |
| | |
The option to disable including a hidden ID field on a `fields_for` nested association was incorrectly documented as `hidden_field_id` instead of `include_id`
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
[ci skip]
|
| |/
|
|
|
|
|
|
|
|
|
|
|
| |
Context: https://gist.github.com/radar/5793814
The `URI_REGEXP` that various AssetUrl helpers use is currently case
sensitive when checking for a URI scheme. This means if you try to pass
a URL like `HTTP://www.example.com/path/to/image.jpg`, you end up with
a bogus asset path: `/assets/HTTP://www.example.com/path/to/image.jpg`.
URLs are case insensitive, so this regexp should be as well.
Signed-off-by: David Celis <me@davidcel.is>
|
| | |
|
| |
|
|
|
|
|
| |
- Add attributes `allowfullscreen`, `default`, `inert`, `sortable`,
`truespeed`, `typemustmatch`.
- Fix attribute `seamless` (previously misspelled `seemless`).
- Use `assert_dom_equal` instead of `assert_equal` in test.
|
| |
|
|
|
|
| |
We are setting this header to chrome=1 for Chrome Frame and this will be
retired soon. Check http://blog.chromium.org/2013/06/retiring-chrome-frame.html for
details
|
| |\
| |
| | |
Warning removed for Minitest
|
| | | |
|
| |/ |
|
| | |
|
| |\
| |
| | |
Fix mismatching variable names when using an underscore
|
| | |
| |
| |
| |
| |
| |
| |
| | |
The ERBTracker template digest helper class was using a regex to match
render calls and it was incorrectly not matching against variables with
underscores in the name. This caused it to use the wrong regex match data
to populate the template dependency. Because underscore is a valid
character for a variable, this fixes the ERBTracker to match it properly.
|
| |\ \
| | |
| | | |
Refactor ActionDispatch::Http::Parameters#normalize_encode_params
|
| | | | |
|
| |\ \ \
| |_|/
|/| | |
DRY-up ActionDispatch::Routing autoloads
|
| | |/ |
|
| | |
| |
| |
| |
| | |
in 'rubygems/package_task'
|
| | | |
|
| | |
| |
| |
| | |
were deprecated.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
ActionView::Helpers::FormTagHelper were deprecated.
|
| | |
| |
| |
| | |
ActionView::Helpers::JavascriptHelper were deprecated.
|
| | |
| |
| |
| | |
ActionView::Helpers::UrlHelper#link_to and #button_to were deprecated.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is
a bit sparse. This class is useful when you're writing tests, as often you want to assert various
things about the response that's coming back. Better docs would make this easier for people new
to testing in Rails.
I only added some descriptions for various properties that were defined, and mostly just a sentence
or two. Most of these things are familliar if you're working with HTTP, but some words is better
than no words at all.
Hopefully further commits will fix up things that aren't just documentation.
|
| |\ \
| | |
| | | |
Extract ActionDispatch::Request#deep_munge
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
ActionDispatch::Request#deep_munge was introduced as a private method,
but was turned into a public one for the use of
ActionDispatch::ParamsParser.
I have extracted it into ActionDispatch::Request::Utils, so it does not
get mixed up with the Request public methods.
|
| |/ |
|
| |
|
|
| |
These stopped running don't know when.
But these should be running now.
|
| |
|
|
|
| |
minitest/autorun required minitest/spec and we are avoiding to require
it.
|
| |\
| |
| | |
Eliminate minitest warnings
|
| | |
| |
| |
| | |
https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When named route that is nested is used in 3.2.13
Example `routes.rb`:
```
resources :nested do
resources :builder, :controller => 'nested/builder'
end
```
In 3.2.12 and 3.2.12 this named route would work:
```
nested_builder_path(:last_step, :nested_id => "foo")
```
Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys.
Not sure if this is exactly how the original version worked, but this fixes this use case regression.
|
| |\
| |
| | |
Squishy minitest5
|
