Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use AS::JSON for (de)serializing cookies | Godfrey Chan | 2014-08-17 | 3 | -2/+50 |
| | | | | | | | | Use the Active Support JSON encoder for cookie jars using the `:json` or `:hybrid` serializer. This allows you to serialize custom Ruby objects into cookies by defining the `#as_json` hook on such objects. Fixes #16520. | ||||
* | `responders` 1.x won't do it. Told you to RTFM for details! | Godfrey Chan | 2014-08-17 | 2 | -3/+8 |
| | |||||
* | The gem is called 'responders' | Godfrey Chan | 2014-08-17 | 2 | -4/+4 |
| | |||||
* | Raise a more helpful error for people who are using these extracted features | Godfrey Chan | 2014-08-17 | 2 | -1/+46 |
| | |||||
* | Fixed broken reference caused by 14965ba | Godfrey Chan | 2014-08-17 | 1 | -2/+2 |
| | |||||
* | Merge pull request #16467 from strzalek/cookies-digest-config-option2 | Godfrey Chan | 2014-08-17 | 3 | -3/+64 |
|\ | | | | | | | | | | | | | | | Cookies digest config option (pt. 2) Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/middleware/cookies.rb | ||||
| * | Add config option for cookies digest | Łukasz Strzałkowski | 2014-08-12 | 3 | -3/+64 |
| | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = 'SHA256' | ||||
* | | Merge pull request #16484 from strzalek/remove-redundant-null-serializer | Godfrey Chan | 2014-08-17 | 1 | -16/+7 |
|\ \ | | | | | | | Remove redundant NullSerializer | ||||
| * | | Remove redundant NullSerializer | Łukasz Strzałkowski | 2014-08-13 | 1 | -16/+7 |
| |/ | | | | | | | Use one from ActiveSupport::MessageEncryptor module. | ||||
* | | Remove more references to respond_with | José Valim | 2014-08-17 | 7 | -6/+0 |
| | | |||||
* | | Move respond_with to the responders gem | José Valim | 2014-08-17 | 4 | -1265/+8 |
| | | | | | | | | | | | | | | | | respond_with (and consequently the class-level respond_to) are being removed from Rails. Instead of moving it to a 3rd library, the functionality will be moved to responders gem (at github.com/plataformatec/responders) which already provides some responders extensions. | ||||
* | | When your templates change, browser caches bust automatically. | Jeremy Kemper | 2014-08-17 | 7 | -9/+136 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | New default: the template digest is automatically included in your ETags. When you call `fresh_when @post`, the digest for `posts/show.html.erb` is mixed in so future changes to the HTML will blow HTTP caches for you. This makes it easy to HTTP-cache many more of your actions. If you render a different template, you can now pass the `:template` option to include its digest instead: fresh_when @post, template: 'widgets/show' Pass `template: false` to skip the lookup. To turn this off entirely, set: config.action_controller.etag_with_template_digest = false | ||||
* | | extract methods and metaprogram less. | Aaron Patterson | 2014-08-14 | 1 | -11/+16 |
| | | |||||
* | | remove deprecated `MissingHelperError` proxy. | Yves Senn | 2014-08-14 | 2 | -3/+5 |
| | | | | | | | | The error was moved outside of the `ClassMethods` module. | ||||
* | | Merge pull request #16027 from tgxworld/template_assertions | Yves Senn | 2014-08-14 | 3 | -0/+36 |
|\ \ | | | | | | | Fixes to ActionController::TemplateAssertions | ||||
| * | | Fix assert_template for files. | Guo Xiang Tan | 2014-08-14 | 3 | -0/+36 |
| | | | | | | | | | | | | | | | The test was not failing for `assert_template file: nil` when a file has been rendered. | ||||
* | | | ask the scope object if it is a resource_method_scope | Aaron Patterson | 2014-08-13 | 1 | -10/+13 |
| | | | |||||
* | | | ask the scope for the action name | Aaron Patterson | 2014-08-13 | 1 | -14/+18 |
| | | | |||||
* | | | reduce calls to scope_level | Aaron Patterson | 2014-08-13 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | this will help us to encapsulate magical symbols so hopefully we can eliminate hardcoded magic symbols | ||||
* | | | change to attr_reader | Aaron Patterson | 2014-08-13 | 1 | -5/+1 |
| | | | |||||
* | | | scope_level is no longer a hash key, just use the ivar | Aaron Patterson | 2014-08-13 | 1 | -4/+9 |
| | | | |||||
* | | | move the scope level key fully inside the scope object | Aaron Patterson | 2014-08-13 | 1 | -1/+5 |
| | | | |||||
* | | | move scope_level to a method on the scope object | Aaron Patterson | 2014-08-13 | 1 | -7/+20 |
| | | | | | | | | | | | | now we don't have to have a hard coded key | ||||
* | | | only look up scope level once | Aaron Patterson | 2014-08-13 | 1 | -6/+7 |
| | | | | | | | | | | | | avoid hash lookups and remove depency on the instance | ||||
* | | | only test `prefix` once | Aaron Patterson | 2014-08-13 | 1 | -2/+4 |
| | | | | | | | | | | | | we don't need to repeat if statements | ||||
* | | | pass consistent parameters to canonical_action? | Aaron Patterson | 2014-08-13 | 1 | -5/+5 |
| | | | | | | | | | | | | | | | now we only have to look up @scope[:scope_level] once per call to canonical_action? and we don't have a variable named "flag" | ||||
* | | | fewer operations on the options hash | Aaron Patterson | 2014-08-13 | 2 | -11/+11 |
| | | | | | | | | | | | | | | | since we pass `as` down, then we won't have to do an insert / delete dance with the options hash | ||||
* | | | this should be accessing the hash, not calling a method | Aaron Patterson | 2014-08-13 | 1 | -1/+1 |
| | | | |||||
* | | | UnexpectedErrors may reference exceptions that can't be dumped | Aaron Patterson | 2014-08-13 | 1 | -0/+17 |
| | | | | | | | | | | | | | | | | | | UnexpectedError exceptions wrap the original exception, and the original exception may contain a reference to something that can't be marshal dumped which will cause the process to die. | ||||
* | | | [ci skip] correct default cache store class | Aditya Kapoor | 2014-08-13 | 1 | -1/+1 |
|/ / | |||||
* | | Merge pull request #16491 from akshay-vishnoi/doc-changes | Yves Senn | 2014-08-13 | 1 | -1/+1 |
|\ \ | | | | | | | [ci skip] fix spelling of overridden | ||||
| * | | [ci skip] fix spelling of override | Akshay Vishnoi | 2014-08-13 | 1 | -1/+1 |
| | | | |||||
* | | | AM, AP, AV, and AMo tests are already order_independent! | Akira Matsuda | 2014-08-13 | 1 | -5/+0 |
|/ / | |||||
* | | Merge pull request #16476 from akshay-vishnoi/doc-changes | Rafael Mendonça França | 2014-08-12 | 2 | -2/+2 |
|\ \ | | | | | | | [ci skip] use "based on" or "based off of" | ||||
| * | | use 'based on' instead of 'based off' [ci skip] | Akshay Vishnoi | 2014-08-12 | 2 | -2/+2 |
| | | | |||||
* | | | Nobody sucks so nobody should call this awful method name | Rafael Mendonça França | 2014-08-12 | 1 | -1/+1 |
|/ / | |||||
* | | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent! | Akira Matsuda | 2014-08-12 | 1 | -0/+5 |
| | | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework. | ||||
* | | Merge pull request #16440 from tgxworld/pass_log_in_block | Santiago Pastorino | 2014-08-09 | 1 | -4/+6 |
|\ \ | | | | | | | Pass block for logging. | ||||
| * | | Pass block for logging. | Guo Xiang Tan | 2014-08-09 | 1 | -4/+6 |
| | | | | | | | | | | | | This follows the good practice listed on http://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance. | ||||
* | | | Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option" | Santiago Pastorino | 2014-08-08 | 3 | -30/+2 |
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!! | ||||
* | | | Add config option for cookies digest | Łukasz Strzałkowski | 2014-08-08 | 3 | -2/+30 |
| |/ |/| | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256' | ||||
* | | Merge pull request #16427 from ryandao/full_stack_source_extract | Guillermo Iguaran | 2014-08-08 | 9 | -69/+114 |
|\ \ | | | | | | | Full stack source extract | ||||
| * | | Update actionpack CHANGELOG | Ryan Dao | 2014-08-08 | 1 | -0/+5 |
| | | | |||||
| * | | Retrieve source code for the entire stack trace | Ryan Dao | 2014-08-08 | 8 | -69/+109 |
| |/ | | | | | | | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors. | ||||
* / | Fixes to TestCaseTest. | Guo Xiang Tan | 2014-08-08 | 1 | -4/+5 |
|/ | |||||
* | Fix spelling. | Guo Xiang Tan | 2014-08-07 | 1 | -1/+1 |
| | |||||
* | Remove ActionController::RaiseActionExceptions. | Guo Xiang Tan | 2014-08-07 | 1 | -34/+0 |
| | | | | | The latest modification to the code was done in https://github.com/rails/rails/commit/5e3517ea. In Rails 3.2, `ActionController#rescue_action` was deprecated and `rescue_action_without_handler` is no longer being used. | ||||
* | refactor Redirecting so we do not need a controller instance | Aaron Patterson | 2014-08-06 | 2 | -10/+7 |
| | |||||
* | call the routes method on engines | Aaron Patterson | 2014-08-05 | 1 | -74/+37 |
| | | | | if we access the instance, we can free up lots of codes | ||||
* | a rails application should be an engine subclass | Aaron Patterson | 2014-08-05 | 1 | -1/+1 |
| |