aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | options already have symbolized keys, so we can avoid this callAaron Patterson2014-05-131-1/+1
| | | |
* | | | Get rid of unused methodCarlos Antonio da Silva2014-05-131-11/+0
| | | | | | | | | | | | | | | | It's usage has been removed in 325c9d5e5235db4b5210d9db6c863835d1ac7eed.
* | | | Simplify merge call on polymorphic helpersCarlos Antonio da Silva2014-05-131-2/+2
| | | |
* | | | Fix regression on `assert_redirected_to`.Arthur Neves2014-05-132-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691]
* | | | avoid array allocation when extracting usernames and passwordsAaron Patterson2014-05-121-1/+7
| | | |
* | | | Revert "reduce conditionals in url_for"Aaron Patterson2014-05-121-6/+3
| | | | | | | | | | | | | | | | This reverts commit 9df60693d77813b362fb528fc62381ac8f1eec12.
* | | | this class is a model, so it should act like oneAaron Patterson2014-05-121-0/+3
| | | |
* | | | use the helper method builder to construct helper methodsAaron Patterson2014-05-122-57/+112
| | | |
* | | | undo optimized calls until the builder object is finishedAaron Patterson2014-05-122-37/+20
| | | |
* | | | remove suffix from the handler methodsAaron Patterson2014-05-121-20/+19
| | | |
* | | | push list handling to the builder objectAaron Patterson2014-05-121-30/+30
| | | |
* | | | push string handling to the builder objectAaron Patterson2014-05-121-10/+8
| | | |
* | | | push model and class handling to a helper builder objectAaron Patterson2014-05-121-36/+48
| | | |
* | | | adding a method to handle strings using the same apiAaron Patterson2014-05-121-22/+32
| | | |
* | | | break each polymorphic type to it's own methodAaron Patterson2014-05-121-24/+81
| | | |
* | | | remove dead codeAaron Patterson2014-05-121-12/+0
| | | |
* | | | only test `persisted?` on the record onceAaron Patterson2014-05-121-3/+7
| | | | | | | | | | | | | | | | | | | | also avoid the case of calling `persisted?` on something that doesn't respond to it
* | | | only send options if there are any optionsAaron Patterson2014-05-121-5/+7
| | | |
* | | | remove should_pop variableAaron Patterson2014-05-121-4/+1
| | | |
* | | | only pop records when we get an arrayAaron Patterson2014-05-121-6/+7
| | | |
* | | | remove unnecessary array allocationsCoraline Ada Ehmke + Aaron Patterson2014-05-121-5/+1
| | | |
* | | | simplified route method name generationCoraline Ada Ehmke + Aaron Patterson2014-05-121-27/+17
| | | |
* | | | small refactoringCoraline Ada Ehmke + Aaron Patterson2014-05-121-6/+2
| | | |
* | | | pulling helpermethods up before refactoringCoraline Ada Ehmke + Aaron Patterson2014-05-121-20/+46
| | | |
* | | | push all is_a tests up, always pass options to the named routeAaron Patterson2014-05-121-28/+27
| | | |
* | | | pull nil checks upAaron Patterson2014-05-121-3/+5
| | | |
* | | | skip another Array is_a checkAaron Patterson2014-05-121-4/+6
| | | |
* | | | only do the Array is_a check onceAaron Patterson2014-05-121-4/+3
| | | |
* | | | we always convert this variable to a list, so we can remove the unconversionAaron Patterson2014-05-121-1/+0
| | | |
* | | | record as a hash is not possible, so rm branchAaron Patterson2014-05-121-2/+0
| | | |
* | | | stop popping in build_named_route_callAaron Patterson2014-05-121-4/+3
| | | |
* | | | remove extract_record since we have extracted the listAaron Patterson2014-05-121-12/+1
| | | |
* | | | always pass a list to build_named_route_callAaron Patterson2014-05-121-10/+19
| | | |
* | | | add a test for passing two models to the polymorphic_url methodAaron Patterson2014-05-121-1/+1
| | | |
* | | | reduce conditionals in url_forAaron Patterson2014-05-121-3/+6
| | | |
* | | | extract route key translation to a method and reuse itAaron Patterson2014-05-121-17/+14
| | | |
* | | | make the module version quack the same as the instanceAaron Patterson2014-05-121-3/+10
| | | | | | | | | | | | | | | | this way we can stop checking respond_to on every call.
* | | | Hash#except is expensive and this is a hotspot, so use a dup + deleteAaron Patterson2014-05-121-1/+2
|/ / /
* | | Remove redundant tests method.Guo Xiang Tan2014-05-111-2/+0
| | |
* | | docs, make `ActionNotFound` public API. [ci skip]Yves Senn2014-05-111-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #15058. This exception is regularly raised during development. This means it will enter the user realm. We should provide an API page to show that this exception is public API. /cc @schneems
* | | adding complete message in documentation [ci skip]Gaurav Sharma2014-05-111-3/+4
| | |
* | | Always use the provided port for protocol relative urlsAndrew White2014-05-113-0/+20
| | | | | | | | | | | | | | | There may be situations where you need to tunnel SSL connections over port 80 so we shouldn't remove it if it has been explicitly provided.
* | | ActionDispatch::Http::URL.normalize_port should not strip port for protocol ↵Guilherme Cavalcanti2014-05-112-2/+12
| | | | | | | | | | | | relative URL.
* | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-05-101-1/+22
|\ \ \
| * | | copy edits [ci skip]Vijay Dev2014-05-101-8/+8
| | | |
| * | | [ci skip] doc Http::Headers methodsschneems2014-05-091-1/+17
| | | |
| * | | copy edits [ci skip]Vijay Dev2014-05-081-2/+1
| | | |
| * | | [ci skip] document ActionDispatch::HTTP::Headersschneems2014-05-071-0/+6
| | | |
* | | | skip dealing with params if none are providedAaron Patterson2014-05-091-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us avoid 1. A slow call to Hash#slice 2. An is_a? test 3. Extra hash allocations (from slice) 4. String allocations etc.
* | | | don't mutate the options hash, so we don't have to dupAaron Patterson2014-05-091-4/+3
| | | | | | | | | | | | | | | | avoids extra hash allocations on each call