| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
| |
This will trim down the API and avoid some error that can be made
changing the cache object.
|
| |
|
|
|
|
|
| |
We should not require all the core extensions inside the frameworks.
The logger is already defined in the Action View framework.
|
|\
| |
| | |
Fix a typo in AD
|
| | |
|
|\ \
| | |
| | | |
Refactor `Mime::Type`
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`parse` method performance improvements - ~27-33%:
accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*"
Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }}
old: 1.430000 0.000000 1.430000 ( 1.440977)
new: 0.920000 0.000000 0.920000 ( 0.921813)
|
| | |
| | |
| | |
| | | |
authoritative enough
|
| | | |
|
| | |
| | |
| | |
| | | |
Also, add documentation for alternate usage.
|
|/ /
| |
| |
| |
| |
| | |
This allows us to make alterations to the generated routes based on the
scope of the current mapper, and otherwise allows us to move larger
blocks of concerns out of the routes file, altogether.
|
| | |
|
|\ \
| | |
| | | |
Properly reset the session on reset_session
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use load_for_write! to ensure a refresh of the session object.
This way the new session_id and the empty data will be stored properly.
E.g. in the case of the session cookie store this means that a new
digest will be returned to the user.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Fixes #7478
|
|\ \ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
SessionHash isn't a thing, and tenses are wrong.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Method invalid_asset_host! was delegated to controller but sprockets
compile assets in their own scope without controller. And if we set asset_host
with second parameter it should raise error through invalid_asset_host!.
But since controller is nil it cannot be reached.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 7256cb53e0c34e510a4d59a50d120c0358cf1d99, reversing
changes made to 6ebe22c3ae716d089af1e5090ddb0d12b31af8ac.
Reason: A test was failing.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit e4b33b08d6d2b88b627b1e52c4f349e57c5b89fc.
https://github.com/rails/rails/pull/7452#issuecomment-8094302
|
|\ \ \ \
| |_|/ /
|/| | | |
the example for contraint( :ip => XXXX) has an invalid regex
|
| | | |
| | | |
| | | | |
escape the '.'s
|
| | | |
| | | |
| | | | |
Since it uses request and response methods
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix markdown rendering of the ActionPack changelog [ci skip]
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | |
| | | |
computation *Jeremy Kemper/DHH*
|
| | |
| | |
| | |
| | | |
spiked in the cache_digests plugin) *DHH*
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Add Missing Keys from Journey on Failed URL Format
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The result of Generator with or without the @extras instance variable set contains the desired information. Rather than preserving state when initializing the original object, we can simply extract the keys from the resultant parameters.
ATP Actionpack, railties
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Many named routes have keys that are required to successfully resolve. If a key is left off like this:
<%= link_to 'user', user_path %>
This will produce an error like this:
No route matches {:action=>"show", :controller=>"users"}
Since we know that the :id is missing, we can add extra debugging information to the error message.
No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id]
This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url.
While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious.
This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message.
Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Changes in old branches needed to be manually synched in CHANGELOGs of newer ones.
This has proven to be brittle, sometimes one just forgets this manual step.
With this commit we switch to CHANGELOGs per branch. When a new major version is
cut from master, the CHANGELOGs in master start being blank.
A link to the CHANGELOG of the previous branch allows anyone interested to
follow the history.
|
| | | |
|