aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Fix style guide violationsRafael Mendonça França2017-01-051-3/+3
|
* String#end_with? should be faster than Regexp hereAkira Matsuda2017-01-051-1/+1
|
* No need to :doc: a public methodAkira Matsuda2017-01-051-1/+1
|
* Remove deprecated ActionController::Metal.callRafael Mendonça França2017-01-033-17/+11
|
* List full class nameJon Moss2017-01-031-1/+1
| | | | | | `Metal#env` --> `ActionController::Metal#env` [ci skip]
* Remove deprecated Metal#envRafael Mendonça França2017-01-032-5/+4
|
* Extract variant setter to process methodJon Moss2017-01-022-4/+10
| | | | | | | Provide an API interface similar to how format is handled in Controllers. In situations where variants are not needed (ex: in Action Mailer) the method will simply trigger a no-op, and will not affect end users.
* Bump license years for 2017Jon Moss2016-12-313-3/+3
| | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip]
* fix with_routing when testing api only controllersJulia López2016-12-293-2/+33
|
* Use `next` instead of `break`; avoid terminating whole loopJon Moss2016-12-292-1/+22
| | | | | | | | | | | | | | We want to avoid terminating the whole loop here, because it will cause parameters that should be removed to not be removed, since we are terminating early. In this specific case, `param2` is processed before `param1` due to the reversing of `route.parts`, and since `param2` fails the check on this line, it would previously cause the whole loop to fail, and `param1` would still be in `parameterized_parts`. Now, we are simply calling `next`, which is the intended behavior. Introduced by 8ca8a2d773b942c4ea76baabe2df502a339d05b1. Fixes #27454.
* Use proper output format [ci skip] (#27498)प्रथमेश Sonpatki2016-12-291-1/+1
|
* Update request.rb --ci skipShardul Parab2016-12-291-0/+3
| | | | | | | | | | | | | | | | Documentation for ActionDispatch::Request#key? [ci skip] Update request.rb --ci skip Documentation for ActionDispatch::Request#key? [ci skip] Also made change after the review by @rafaelfranca . Update request.rb --ci skip Documentation for ActionDispatch::Request#key? [ci skip] Also made change after the review by @rafaelfranca . Update request.rb --ci skip
* Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-283-3/+3
| | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
* Optimize Journey::Route#scoreBen Hughes2016-12-283-6/+15
| | | | | | | | Scoring routes based on constraints repeated many type conversions that could be performed in the outer loop. Determinations of score and fitness also used Array operations that required allocations. Against my benchmark with a large routeset, this reduced object allocations by over 30x and wall time by over 3x.
* Small edits to actionpack/CHANGELOG.mdJon Moss2016-12-271-2/+2
| | | | | | | [ci skip] - change a period to a comma - add backticks for class + method
* Remove random extra spaces from Action Pack and Railties CHANGELOG.mdJon Moss2016-12-271-1/+1
| | | | [ci skip]
* renderers typo fix [ci skip]ota42y2016-12-271-1/+1
|
* assert_equal takes expectation firstAkira Matsuda2016-12-262-3/+3
|
* "Use assert_nil if expecting nil from ...:in `...'. This will fail in ↵Akira Matsuda2016-12-251-2/+1
| | | | minitest 6."
* "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6."Akira Matsuda2016-12-251-4/+4
|
* "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-2515-40/+40
|
* Shave a couple of allocations off Journey scan & parseMatthew Draper2016-12-253-203/+207
|
* Privatize unneededly protected methods in Action PackAkira Matsuda2016-12-2415-83/+82
|
* No need to nodoc private methodsAkira Matsuda2016-12-245-24/+24
|
* Privatize unneededly protected methods in Action Pack testsAkira Matsuda2016-12-2310-22/+20
|
* Describe what we are protectingAkira Matsuda2016-12-231-0/+2
|
* updating docsAaron Patterson2016-12-211-0/+4
|
* Document and update API for `skip_parameter_encoding`Aaron Patterson2016-12-216-54/+52
| | | | | | | | This commit changes `parameter_encoding` to `skip_parameter_encoding`. `skip_parameter_encoding` will set encoding on all parameters to ASCII-8BIT for a given action on a particular controller. This allows the controller to handle data when the encoding of that data is unknown, for example file systems or truly binary parameters.
* Merge pull request #27414 from matthewd/fix-xml-vs-html-assertionMatthew Draper2016-12-211-12/+12
|\ | | | | Revise the "XML is not HTML" test
| * Revise the "XML is not HTML" testMatthew Draper2016-12-201-12/+12
| | | | | | | | | | | | It was depending on a side-effect of the old html-scanner, so was no longer proving what it intended to. Instead, assert more directly about the resulting observable difference.
* | Merge pull request #27408 from matthewd/charset-fixMatthew Draper2016-12-203-5/+14
|\ \ | | | | | | Only default the response charset when it is first set
| * | Only default the response charset when it is first setMatthew Draper2016-12-203-5/+14
| |/ | | | | | | | | If it is explicitly cleared (e.g., response.sending_file = true), then we should not try to set it again.
* | Merge pull request #27146 from maclover7/jm-fix-27145Eileen M. Uchitelle2016-12-192-2/+10
|\ \ | |/ |/| Do not clear HTTP_COOKIES header after request
| * Do not clear HTTP_COOKIES header after requestJon Moss2016-12-112-2/+10
| |
* | Missing require "active_support/testing/constant_lookup"Akira Matsuda2016-12-141-0/+1
|/
* Do not raise exception when content_type is a empty stringRafael Mendonça França2016-12-092-1/+6
| | | | | When content type header is blank we were raising an exception because `empty?` was being called on nil.
* Only move fixture_file_upload to IntegrationTestMatthew Draper2016-12-072-18/+22
| | | | | The rest of the helpers are better placed on Session -- and this is the only one that cares which class it is defined on.
* Do not try to set the content_type if the format is nilRafael Mendonça França2016-12-051-1/+1
|
* stop using removed `render :text`yuuji.yaginuma2016-12-031-1/+1
| | | | Follow up to 79a5ea9eadb4d43b62afacedc0706cbe88c54496
* use `Gem.win_platform?` to check windows Ruby platformsyuuji.yaginuma2016-11-301-1/+1
| | | | | `Gem.win_platform?` check if it is Windows more accurately. Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952
* Document 'false' as option for 'action_on_unpermitted_parameters'Daniel Carral2016-11-291-2/+2
| | | | [ci skip]
* Merge pull request #27195 from y-yagi/use_public_module_includeSantiago Pastorino2016-11-271-1/+1
|\ | | | | use public Module#include instead of send :include
| * use public Module#include instead of send :includeyuuji.yaginuma2016-11-271-1/+1
| | | | | | | | Follow up to #18767
* | [ci skip] Update the `as` docs.Kasper Timm Hansen2016-11-271-1/+2
| | | | | | | | Mention the Accept header and how that figures into the request format.
* | Remove default argument value.Kasper Timm Hansen2016-11-271-1/+1
|/ | | | Wrongly added when fixing the request path wrangling.
* Merge pull request #27140 from ↵Rafael França2016-11-251-1/+1
|\ | | | | | | | | supercaracal/fix-force-ssl-if-session-store-disabled Fix a force ssl redirection bug that occur when session store disabled.
| * Remove aggressive unit test with mock. And add integration level test.Taishi Kasuga2016-11-241-24/+0
| |
| * Fix a force ssl redirection bug that occur when session store disabled.Taishi Kasuga2016-11-222-1/+25
| |
* | [ci skip] Add changelog entry for 86754a8fKasper Timm Hansen2016-11-231-0/+11
| |
* | [ci skip] Explain only :json is shipped by default.Kasper Timm Hansen2016-11-231-1/+2
| | | | | | | | | | | | | | Don't want to add defensive programming to this fairly simple thing. Fixes #27060.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 04:55:07 +0000