Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | `self.` is not needed when calling its own instance method | Akira Matsuda | 2017-01-05 | 7 | -8/+8 |
| | | | | Actually, private methods cannot be called with `self.`, so it's not just redundant, it's a bad habit in Ruby | ||||
* | Fix style guide violations | Rafael Mendonça França | 2017-01-05 | 1 | -3/+3 |
| | |||||
* | String#end_with? should be faster than Regexp here | Akira Matsuda | 2017-01-05 | 1 | -1/+1 |
| | |||||
* | No need to :doc: a public method | Akira Matsuda | 2017-01-05 | 1 | -1/+1 |
| | |||||
* | Remove deprecated ActionController::Metal.call | Rafael Mendonça França | 2017-01-03 | 3 | -17/+11 |
| | |||||
* | List full class name | Jon Moss | 2017-01-03 | 1 | -1/+1 |
| | | | | | | `Metal#env` --> `ActionController::Metal#env` [ci skip] | ||||
* | Remove deprecated Metal#env | Rafael Mendonça França | 2017-01-03 | 2 | -5/+4 |
| | |||||
* | Extract variant setter to process method | Jon Moss | 2017-01-02 | 2 | -4/+10 |
| | | | | | | | Provide an API interface similar to how format is handled in Controllers. In situations where variants are not needed (ex: in Action Mailer) the method will simply trigger a no-op, and will not affect end users. | ||||
* | Bump license years for 2017 | Jon Moss | 2016-12-31 | 3 | -3/+3 |
| | | | | | | | | Per https://www.timeanddate.com/counters/firstnewyear.html, it's already 2017 in a lot of places, so we should bump the Rails license years to 2017. [ci skip] | ||||
* | fix with_routing when testing api only controllers | Julia López | 2016-12-29 | 3 | -2/+33 |
| | |||||
* | Use `next` instead of `break`; avoid terminating whole loop | Jon Moss | 2016-12-29 | 2 | -1/+22 |
| | | | | | | | | | | | | | | We want to avoid terminating the whole loop here, because it will cause parameters that should be removed to not be removed, since we are terminating early. In this specific case, `param2` is processed before `param1` due to the reversing of `route.parts`, and since `param2` fails the check on this line, it would previously cause the whole loop to fail, and `param1` would still be in `parameterized_parts`. Now, we are simply calling `next`, which is the intended behavior. Introduced by 8ca8a2d773b942c4ea76baabe2df502a339d05b1. Fixes #27454. | ||||
* | Use proper output format [ci skip] (#27498) | प्रथमेश Sonpatki | 2016-12-29 | 1 | -1/+1 |
| | |||||
* | Update request.rb --ci skip | Shardul Parab | 2016-12-29 | 1 | -0/+3 |
| | | | | | | | | | | | | | | | | Documentation for ActionDispatch::Request#key? [ci skip] Update request.rb --ci skip Documentation for ActionDispatch::Request#key? [ci skip] Also made change after the review by @rafaelfranca . Update request.rb --ci skip Documentation for ActionDispatch::Request#key? [ci skip] Also made change after the review by @rafaelfranca . Update request.rb --ci skip | ||||
* | Fix Rubocop violations and fix documentation visibility | Rafael Mendonça França | 2016-12-28 | 3 | -3/+3 |
| | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API. | ||||
* | Optimize Journey::Route#score | Ben Hughes | 2016-12-28 | 3 | -6/+15 |
| | | | | | | | | Scoring routes based on constraints repeated many type conversions that could be performed in the outer loop. Determinations of score and fitness also used Array operations that required allocations. Against my benchmark with a large routeset, this reduced object allocations by over 30x and wall time by over 3x. | ||||
* | Small edits to actionpack/CHANGELOG.md | Jon Moss | 2016-12-27 | 1 | -2/+2 |
| | | | | | | | [ci skip] - change a period to a comma - add backticks for class + method | ||||
* | Remove random extra spaces from Action Pack and Railties CHANGELOG.md | Jon Moss | 2016-12-27 | 1 | -1/+1 |
| | | | | [ci skip] | ||||
* | renderers typo fix [ci skip] | ota42y | 2016-12-27 | 1 | -1/+1 |
| | |||||
* | assert_equal takes expectation first | Akira Matsuda | 2016-12-26 | 2 | -3/+3 |
| | |||||
* | "Use assert_nil if expecting nil from ...:in `...'. This will fail in ↵ | Akira Matsuda | 2016-12-25 | 1 | -2/+1 |
| | | | | minitest 6." | ||||
* | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6." | Akira Matsuda | 2016-12-25 | 1 | -4/+4 |
| | |||||
* | "Use assert_nil if expecting nil. This will fail in minitest 6." | Akira Matsuda | 2016-12-25 | 15 | -40/+40 |
| | |||||
* | Shave a couple of allocations off Journey scan & parse | Matthew Draper | 2016-12-25 | 3 | -203/+207 |
| | |||||
* | Privatize unneededly protected methods in Action Pack | Akira Matsuda | 2016-12-24 | 15 | -83/+82 |
| | |||||
* | No need to nodoc private methods | Akira Matsuda | 2016-12-24 | 5 | -24/+24 |
| | |||||
* | Privatize unneededly protected methods in Action Pack tests | Akira Matsuda | 2016-12-23 | 10 | -22/+20 |
| | |||||
* | Describe what we are protecting | Akira Matsuda | 2016-12-23 | 1 | -0/+2 |
| | |||||
* | updating docs | Aaron Patterson | 2016-12-21 | 1 | -0/+4 |
| | |||||
* | Document and update API for `skip_parameter_encoding` | Aaron Patterson | 2016-12-21 | 6 | -54/+52 |
| | | | | | | | | This commit changes `parameter_encoding` to `skip_parameter_encoding`. `skip_parameter_encoding` will set encoding on all parameters to ASCII-8BIT for a given action on a particular controller. This allows the controller to handle data when the encoding of that data is unknown, for example file systems or truly binary parameters. | ||||
* | Merge pull request #27414 from matthewd/fix-xml-vs-html-assertion | Matthew Draper | 2016-12-21 | 1 | -12/+12 |
|\ | | | | | Revise the "XML is not HTML" test | ||||
| * | Revise the "XML is not HTML" test | Matthew Draper | 2016-12-20 | 1 | -12/+12 |
| | | | | | | | | | | | | It was depending on a side-effect of the old html-scanner, so was no longer proving what it intended to. Instead, assert more directly about the resulting observable difference. | ||||
* | | Merge pull request #27408 from matthewd/charset-fix | Matthew Draper | 2016-12-20 | 3 | -5/+14 |
|\ \ | | | | | | | Only default the response charset when it is first set | ||||
| * | | Only default the response charset when it is first set | Matthew Draper | 2016-12-20 | 3 | -5/+14 |
| |/ | | | | | | | | | If it is explicitly cleared (e.g., response.sending_file = true), then we should not try to set it again. | ||||
* | | Merge pull request #27146 from maclover7/jm-fix-27145 | Eileen M. Uchitelle | 2016-12-19 | 2 | -2/+10 |
|\ \ | |/ |/| | Do not clear HTTP_COOKIES header after request | ||||
| * | Do not clear HTTP_COOKIES header after request | Jon Moss | 2016-12-11 | 2 | -2/+10 |
| | | |||||
* | | Missing require "active_support/testing/constant_lookup" | Akira Matsuda | 2016-12-14 | 1 | -0/+1 |
|/ | |||||
* | Do not raise exception when content_type is a empty string | Rafael Mendonça França | 2016-12-09 | 2 | -1/+6 |
| | | | | | When content type header is blank we were raising an exception because `empty?` was being called on nil. | ||||
* | Only move fixture_file_upload to IntegrationTest | Matthew Draper | 2016-12-07 | 2 | -18/+22 |
| | | | | | The rest of the helpers are better placed on Session -- and this is the only one that cares which class it is defined on. | ||||
* | Do not try to set the content_type if the format is nil | Rafael Mendonça França | 2016-12-05 | 1 | -1/+1 |
| | |||||
* | stop using removed `render :text` | yuuji.yaginuma | 2016-12-03 | 1 | -1/+1 |
| | | | | Follow up to 79a5ea9eadb4d43b62afacedc0706cbe88c54496 | ||||
* | use `Gem.win_platform?` to check windows Ruby platforms | yuuji.yaginuma | 2016-11-30 | 1 | -1/+1 |
| | | | | | `Gem.win_platform?` check if it is Windows more accurately. Ref: https://github.com/ruby/ruby/blob/ruby_2_2/lib/rubygems.rb#L945..L952 | ||||
* | Document 'false' as option for 'action_on_unpermitted_parameters' | Daniel Carral | 2016-11-29 | 1 | -2/+2 |
| | | | | [ci skip] | ||||
* | Merge pull request #27195 from y-yagi/use_public_module_include | Santiago Pastorino | 2016-11-27 | 1 | -1/+1 |
|\ | | | | | use public Module#include instead of send :include | ||||
| * | use public Module#include instead of send :include | yuuji.yaginuma | 2016-11-27 | 1 | -1/+1 |
| | | | | | | | | Follow up to #18767 | ||||
* | | [ci skip] Update the `as` docs. | Kasper Timm Hansen | 2016-11-27 | 1 | -1/+2 |
| | | | | | | | | Mention the Accept header and how that figures into the request format. | ||||
* | | Remove default argument value. | Kasper Timm Hansen | 2016-11-27 | 1 | -1/+1 |
|/ | | | | Wrongly added when fixing the request path wrangling. | ||||
* | Merge pull request #27140 from ↵ | Rafael França | 2016-11-25 | 1 | -1/+1 |
|\ | | | | | | | | | supercaracal/fix-force-ssl-if-session-store-disabled Fix a force ssl redirection bug that occur when session store disabled. | ||||
| * | Remove aggressive unit test with mock. And add integration level test. | Taishi Kasuga | 2016-11-24 | 1 | -24/+0 |
| | | |||||
| * | Fix a force ssl redirection bug that occur when session store disabled. | Taishi Kasuga | 2016-11-22 | 2 | -1/+25 |
| | | |||||
* | | [ci skip] Add changelog entry for 86754a8f | Kasper Timm Hansen | 2016-11-23 | 1 | -0/+11 |
| | |