Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | Merge pull request #15386 from ↵ | Santiago Pastorino | 2014-05-28 | 1 | -3/+6 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_actionpack_request_forgery_protection_test Avoid hardcoded `request_forgery_protection_token` value in teardown. | |||||
| * | | | | | Avoid hardcoded value in teardown. | Zuhao Wan | 2014-05-28 | 1 | -3/+6 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #15388 from zuhao/refactor_actionpack_send_file_test | Santiago Pastorino | 2014-05-28 | 1 | -2/+6 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Unregister Mime::Type in teardown. | |||||
| * | | | | | | Unregister Mime::Type in teardown. | Zuhao Wan | 2014-05-28 | 1 | -2/+6 | |
| |/ / / / / | ||||||
* | | | | | | Merge pull request #15385 from zuhao/refactor_actionpack_render_other_test | Santiago Pastorino | 2014-05-28 | 1 | -4/+7 | |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Add and remove renderer inside the test to prevent leak. | |||||
| * | | | | | Add and remove renderer inside the test to prevent leak. | Zuhao Wan | 2014-05-28 | 1 | -4/+7 | |
| |/ / / / | ||||||
* | | | | | Merge pull request #15383 from ↵ | Yves Senn | 2014-05-28 | 1 | -10/+8 | |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | zuhao/refactor_actionpack_localized_templates_test Move I18n.locale setting into setup and teardown. | |||||
| * | | | | Move I18n.locale setting into setup and teardown. | Zuhao Wan | 2014-05-28 | 1 | -10/+8 | |
| |/ / / | ||||||
* / / / | Add with_default_charset helper. | Zuhao Wan | 2014-05-28 | 1 | -12/+20 | |
|/ / / | ||||||
* | | | Deprecate all *_filter callbacks in favor of *_action callbacks | Rafael Mendonça França | 2014-05-27 | 5 | -214/+224 | |
| | | | | | | | | | | | | | | | This is the continuation of the work started at 9d62e04838f01f5589fa50b0baa480d60c815e2c | |||||
* | | | rm dead code | Aaron Patterson | 2014-05-27 | 1 | -5/+0 | |
| | | | ||||||
* | | | PARAMETERS_KEY is only used in the request, so move the constant there | Aaron Patterson | 2014-05-27 | 3 | -9/+9 | |
| | | | ||||||
* | | | Merge branch 'constraints' | Aaron Patterson | 2014-05-27 | 11 | -75/+85 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb | |||||
| * | | | rm reset_parameters because we automatically do it from 9ca4839a | Aaron Patterson | 2014-05-27 | 3 | -9/+0 | |
| | | | | ||||||
| * | | | move path_parameter encoding check to the request object | Aaron Patterson | 2014-05-27 | 3 | -18/+13 | |
| | | | | ||||||
| * | | | dispatcher doesn't need `call` anymore | Aaron Patterson | 2014-05-27 | 1 | -4/+0 | |
| | | | | ||||||
| * | | | call `serve` with the request on dispatchers | Aaron Patterson | 2014-05-27 | 1 | -9/+10 | |
| | | | | ||||||
| * | | | constraints class does not need the request class anymore | Aaron Patterson | 2014-05-27 | 1 | -4/+4 | |
| | | | | ||||||
| * | | | give all endpoints a superclass | Aaron Patterson | 2014-05-27 | 4 | -22/+40 | |
| | | | | ||||||
| * | | | skip the build business if the stack is empty | Aaron Patterson | 2014-05-26 | 1 | -2/+6 | |
| | | | | ||||||
| * | | | stop hardcoding path_parameters and get it from the request | Aaron Patterson | 2014-05-26 | 1 | -1/+2 | |
| | | | | ||||||
| * | | | we do not need to cache rack_app | Aaron Patterson | 2014-05-26 | 1 | -9/+3 | |
| | | | | ||||||
| * | | | a redirect is not a dispatcher by definition, so eliminate test | Aaron Patterson | 2014-05-26 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | push is_a check up to where the Constraints object is allocated | Aaron Patterson | 2014-05-26 | 2 | -6/+11 | |
| | | | | ||||||
| * | | | pass the request object to the application | Aaron Patterson | 2014-05-25 | 3 | -6/+8 | |
| | | | | ||||||
| * | | | pass a request to `matches?` so we can avoid creating excess requests | Aaron Patterson | 2014-05-25 | 2 | -7/+6 | |
| | | | | ||||||
| * | | | nothing is passed to `rack_app` anymore, so rm the params | Aaron Patterson | 2014-05-25 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | one fewer is_a check | Aaron Patterson | 2014-05-25 | 1 | -4/+3 | |
| | | | | ||||||
| * | | | Constraints#app should never return another Constraints object, so switch to ↵ | Aaron Patterson | 2014-05-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | if statement | |||||
| * | | | eliminate dispatcher is_a checks | Aaron Patterson | 2014-05-24 | 1 | -8/+14 | |
| | | | | ||||||
| * | | | push is_a?(Dispatcher) check in to one place | Aaron Patterson | 2014-05-24 | 4 | -14/+12 | |
| | | | | ||||||
| * | | | Always construct route objects with Constraint objects | Aaron Patterson | 2014-05-24 | 4 | -9/+10 | |
| | | | | ||||||
* | | | | Merge pull request #15321 from ↵ | Santiago Pastorino | 2014-05-27 | 1 | -1/+4 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | tgxworld/only_find_routes_as_heads_for_head_request Call get_routes_as_head only on HEAD requests. | |||||
| * | | | | Call get_routes_as_head only on HEAD requests. | Guo Xiang Tan | 2014-05-25 | 1 | -1/+4 | |
| | |_|/ | |/| | | ||||||
* | | | | Skip individual tests upon Dalli::RingError | Matthew Draper | 2014-05-27 | 1 | -0/+18 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem. | |||||
* | | | | Escape user input before showing in the page. | Rafael Mendonça França | 2014-05-26 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This is not a security issue since this page is not present in production and user have to type something in the field but is better to escape the input. | |||||
* | | | | Merge pull request #15325 from tgxworld/no_need_to_call_to_s | Yves Senn | 2014-05-26 | 2 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | Remove duplicated to_s method call. | |||||
| * | | | | Remove duplicated to_s method call. | Guo Xiang Tan | 2014-05-25 | 2 | -2/+2 | |
| |/ / / | ||||||
* | | | | Fix docs for ActionController::Renderers.add | Guillermo Iguaran | 2014-05-26 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #15310 from tgxworld/small_refactor_get_routes_as_head | Carlos Antonio da Silva | 2014-05-25 | 1 | -3/+1 | |
|\ \ \ \ | |/ / / |/| | | | Remove unnecessary flatten! method call. | |||||
| * | | | Remove unnecessary flatten! method call. | Guo Xiang Tan | 2014-05-25 | 1 | -3/+1 | |
| | | | | ||||||
* | | | | The correct status to test should be :switching_protocols. | Zuhao Wan | 2014-05-25 | 1 | -2/+2 | |
|/ / / | ||||||
* | | | Merge pull request #15305 from tgxworld/remove_unnecessary_require | Guillermo Iguaran | 2014-05-24 | 1 | -1/+0 | |
|\ \ \ | |/ / |/| | | Remove unnecessary require of Minitest. | |||||
| * | | Remove unnecessary require of Minitest. | Guo Xiang Tan | 2014-05-24 | 1 | -1/+0 | |
| | | | | | | | | | | | | Minitest has already been required when calling Minitest.autorun. | |||||
* | | | unwrap the constraints object on initialization, eliminate loops | Aaron Patterson | 2014-05-24 | 4 | -3/+12 | |
| | | | | | | | | | | | | | | | | | | | | | Unwrap Constraints objects. I don't actually think it's possible to pass a Constraints object to this constructor, but there were multiple places that kept testing children of this object. I *think* they were just being defensive, but I have no idea. | |||||
* | | | Merge pull request #14986 from dlangevin/trailing-slash-url-generation | Rafael Mendonça França | 2014-05-24 | 3 | -7/+37 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb | |||||
| * | | | Fixes URL generation with trailing_slash: true | Dan Langevin | 2014-05-22 | 3 | -9/+40 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash | |||||
* | | | | Merge pull request #15291 from francocatena/router-visualizer-fix | Rafael Mendonça França | 2014-05-23 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | Fix router visualizer CSS and JS resources | |||||
| * | | | | Fix router visualizer CSS and JS resources | Franco Catena | 2014-05-23 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | Constraints contructor should always return a Constraints object | Aaron Patterson | 2014-05-23 | 1 | -9/+5 | |
| | | | | | | | | | | | | | | | | | | | | I know, it's crazy. |