aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Fixed normalize_path in Routing::Mapper to handle optional prefix segments ↵Paul Barry2010-06-262-1/+47
| | | | | | with static and dynamic parts Signed-off-by: José Valim <jose.valim@gmail.com>
* Don't force pluralization of controller name when defining a resource [#4980 ↵Andrew White2010-06-262-1/+18
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* URL fragments should not have safe characters escaped. Ref: Appendix A, ↵Andrew White2010-06-252-4/+10
| | | | | | | | http://tools.ietf.org/rfc/rfc3986.txt [#4762 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Failing test for whether glob parameters accept regexpsAndrew White2010-06-251-0/+9
| | | | | | [#4970 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Add failing test case for parameters with periodsAndrew White2010-06-251-0/+27
| | | | | | [#2536 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Do not mark the session as loaded if an error happened while doing it.José Valim2010-06-251-2/+1
|
* Calling exists? in the session store, without checking for stale sessions, ↵José Valim2010-06-252-10/+10
| | | | was causing the cookie store to panic because we need to unpack the whole session to get its key. This commit fixes this issue and also caches exists calls for performance improvements.
* Do not wrap hidden fields with error proc [#4962 state:resolved]Carlos Antonio da Silva2010-06-253-3/+23
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Make sure that Rails doesn't resent session_id cookie over and over again if ↵Prem Sichanugrist2010-06-253-1/+27
| | | | | | | | it's already there [#2485 state:resolved] This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie. Signed-off-by: José Valim <jose.valim@gmail.com>
* Just reading flash messages should not create a session if one does not ↵José Valim2010-06-253-5/+29
| | | | exist yet.
* Avoid deserializing cookies too early, which causes session objects to not ↵José Valim2010-06-243-21/+25
| | | | be available yet. Unfortunately, could not reproduce this in a test case.
* Fix namespaced redirects [#4389 state:resolved]Andrew White2010-06-242-1/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵José Valim2010-06-2411-104/+101
| | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
* Avoid using Pathname on Resolver and AS::Dependencies.José Valim2010-06-241-1/+1
|
* Sessions should not be created until written to and session data should be ↵Michael Lovitt2010-06-238-35/+190
| | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Expose view via the view() method in AV::TestCase::BehaviorDavid Chelimsky2010-06-232-17/+24
| | | | | | | | | | - was exposed as _view, which suggested it was private - left _view as an alias of view as not to break any extensions that are relying on _view [#4932 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* In ActionView::TestCase::Behavior, assign variables right beforeDavid Chelimsky2010-06-233-2/+16
| | | | | | | | | | | rendering the view. - Previously, _assigns were locked down the first time _view was referenced. [#4931 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* make text_field and hidden_field omit the value attribute if the developer ↵Jeff Dean2010-06-232-4/+14
| | | | | | explicitly passes in :value => nil [#4839 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Fix controller_name for non default controller paths [#4901 state:resolved]knapo2010-06-232-1/+39
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Tidy up asset tag a bit and make railties tests green again.José Valim2010-06-233-29/+24
|
* refactored the javascript asset tag helpers and moved the default scripts ↵Josh Kalderimis2010-06-233-29/+21
| | | | | | setup within the railtie Signed-off-by: José Valim <jose.valim@gmail.com>
* Update CHANGELOG.José Valim2010-06-231-0/+6
|
* Add the :path option to match routes when given as symbols. This is ↵Carlos Antonio da Silva2010-06-232-10/+28
| | | | | | | | | | specially useful in http helpers for generating routes in scenarios like: resources :users, :path => 'usuarios' do get :search, :on => :collection, :path => 'pesquisar' end Signed-off-by: José Valim <jose.valim@gmail.com>
* Provive resources_path_names helpers in the router.José Valim2010-06-232-0/+15
|
* Stop filling the blocks scope array with nil.José Valim2010-06-221-1/+3
|
* Allow namespace accept options in routes [#4936 state:resolved]Carlos Antonio da Silva2010-06-222-3/+17
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Deprecate :name_prefix in the new router DSL.José Valim2010-06-223-23/+27
|
* Remove unused variable on assert_recognizes [#4912 state:resolved]Paco Guzman2010-06-221-1/+0
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* update the list of instance variables that are excluded from assigns in view ↵David Chelimsky2010-06-221-9/+10
| | | | | | | | tests [#4930 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* adds minus to value part of id [#4862 state:resolved]RainerBlessing2010-06-221-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* test for #4862Neeraj Singh2010-06-221-0/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add support for specifying locals in view tests with assert template [#4927 ↵David Chelimsky2010-06-223-5/+44
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Ensure overwritten callbacks conditions in controllers work [#4761 ↵José Valim2010-06-221-2/+12
| | | | state:resolved] [#3913 state:resolved]
* Bump rack-mount to 0.6.5 for tokenizer speedupJeremy Kemper2010-06-211-1/+1
|
* removed 'unless const_defined?' code smellJosh Kalderimis2010-06-216-47/+39
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'rails/master'Xavier Noria2010-06-2028-281/+727
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb
| * Use the new ActiveSupport::FileUpdateChecker instead of RoutesReloader.José Valim2010-06-201-1/+1
| |
| * Fixed date_select date_separator when discard_month and/or discard_day are ↵Thibaud Guillaume-Gentil2010-06-202-2/+31
| | | | | | | | | | | | true [#4856 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Adding missing test to autolink with other protocols (file) [#4886 ↵Carlos Antonio da Silva2010-06-201-0/+1
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Make sure a namespaced <%= render form %> still renders the _form partial ↵Jan De Poorter2010-06-203-1/+13
| | | | | | | | | | | | [#4784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Use Rack::Utils.bytesize when calculating content-length of exception pages. ↵Tarsoly András2010-06-201-1/+1
| | | | | | | | | | | | [#4727 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * remove executable permission from files that don't need it. [#4802 ↵rohit2010-06-201-0/+0
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Support render_template in view tests. Useful for specifying whichDavid Chelimsky2010-06-202-0/+9
| | | | | | | | | | | | | | | | partials are rendered under different conditions. [#4903 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Don't use module to work out shallow name prefix and path as it may not ↵Andrew White2010-06-202-10/+33
| | | | | | | | | | | | accurately reflect the actual namespace [#4899 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Make polymorphic_url and scaffolding work with uncountable resources [#3930 ↵Andrew White2010-06-204-6/+35
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Accept an object for :constraints option [#4904 state:resolved]Andrew White2010-06-202-1/+9
| | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com>
| * Merge branch 'master' of github.com:rails/railsJosé Valim2010-06-206-32/+105
| |\
| | * option_groups_from_collection_for_select should return HTML-safe string ↵Wincent Colaiuta2010-06-192-19/+13
| | | | | | | | | | | | | | | | | | [#4879 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com>
| | * Remove a relic of #request being in RackDelegationwycats2010-06-192-6/+9
| | |
| | * Custom resource routes should be scopedAndrew White2010-06-192-7/+83
| | | | | | | | | | | | | | | | | | [#3765] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>