| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
* General style fixes.
* Add changes to configuration guide.
* Add missing tests.
|
|
|
|
|
|
|
|
|
| |
* This commit adds back the always_permitted_parameters
configuration option to strong paramaters.
* The initial pull requests where this feature was added
are the following:
- https://github.com/rails/rails/pull/12682
- https://github.com/rails/strong_parameters/pull/174
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example:
# application routes.rb
mount BlogEngine => '/blog'
# engine routes.rb
get '/admin' => redirect('admin/dashboard')
This now redirects to the path `/blog/admin/dashboard`, whereas before it
would've generated an invalid url because there would be no slash between
the host name and the path. It also allows redirects to work where the
application is deployed to a subdirectory of a website.
Fixes #7977
|
|
|
|
|
|
|
|
|
| |
Fixing the typo which is formed a not required link. Check
here http://api.rubyonrails.org/classes/ActionController/Base.html
under paramters section
keeping it under tt tag
gets reverted here ec8ef1e1055c4e1598da13f49d30261f07f4a9b4
|
| |
|
|
|
|
|
|
|
|
| |
This fixes an issue where the respond_with worked directly with the given
options hash, so that if a user relied on it after calling respond_with,
the hash wouldn't be the same.
Fixes #12029
|
| |
|
|\
| |
| |
| | |
tamird-fix-ip-spoof-errors
|
| | |
|
|\ \
| | |
| | | |
Closes #12293. Strong parameters should permit nested number as key.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Thread safety fixes
|
| | | |
| | | |
| | | |
| | | | |
From now on only the `[]=` method is allowed to modify the internal states hashes.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The documentation is showing the link_to method as just returning
the contents of the url_for method. It should be returning an
"<a>" tag with the correct href set.
|
|\ \ \ \
| |_|/ /
|/| | | |
Remove HelperyTestHelper not used in any test
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
HelperyTestHelper was introduced in 66ef922 by @josevalim
to pair with HelperyTestController. This test controller was
later removed in e10a253 by @strzalek, leaving HelperyTestHelper unused
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Onf of the sides can be nil and it will raise a Conversion error
|
| | | |
| | | |
| | | |
| | | | |
test for regression introduced by https://github.com/rails/rails/pull/9155
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Adding documentation and tests to ``polymorphic_url`` and ``link_to``
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
concerning the options that it inherits from +url_for+. The way that
+polymorhpic_url+ is built allows it to have options
like +:anchor+, +:script_name+, etc. but this is currently not
documented.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Rewrite Journey::Visitors::Formatter for performance
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The previous regex was allowing `_` in the URI scheme, which is not
allowed by RFC 3986. This change brings the regex in line with the RFC.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In some instances, `assert_redirected_to` assertion was returning an
incorrect and misleading failure message when the assertion failed.
This was due to a disconnect in how the assertion computes the redirect
string for the failure message and how `redirect_to` computes the
string that is actually used for redirection.
I made the `_compute_redirect_to_loaction` method used by `redirect_to`
public and call that from the method `assert_redirect_to` uses to
calculate the URL.
The reveals a new test failure due to the regex used by
`_compute_redirect_to_location` allow `_` in the URL scheme.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove 1.8 compatible code
|
| | | | | | | |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Previously it was raising a NilException
|
| | | | | | |
|
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | | |
This gem is used by Active Support but it should not be a dependency of
Action Pack.
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Custom flash should be defined only for the class that defines it and it's subclasses
Fixes #12057
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
subclasses.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fix typos: the indefinite articles(a -> an).
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
do not break params filtering on nil values
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
closes #12149
|
| | | | | | | |
|
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This reverts commit ab5cd54b7e791f8419f689d1bef5394890268a6f, reversing
changes made to cdc10c898d4865302740340eedec4f5f4ca76565.
Reason: This way of defining root path is still supported. See
https://github.com/rails/rails/blob/d262773ab7f0aae5de2d354ac2eca168e95b653d/actionpack/test/controller/routing_test.rb#L450-457
|
|\ \ \ \ \ \ |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The documentation in this section is referring to a profile,
so the resource that's created should probably also be a
profile of some sort.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The docs refference a blacklist, but really what's being described
is a whitelist. Anything that matches the constraint gets through to
the path.
|
| | | | | | | |
|