aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Use `#tr` instead of `#gsub`Nicolas Cavigneaux2014-10-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | `#tr` is more efficient than `#gsub` and can be used as a drop in replacement in this context.
* | | | | Improve Journey compliance to RFC 3986Nicolas Cavigneaux2014-10-143-11/+34
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The scanner in Journey fails to recognize routes that use literals from the sub-delims section of RFC 3986. This commit enhance the compatibility of Journey with the RFC by adding support of authorized delimiters to the scanner. Fix #17212
* | | | Merge pull request #17234 from arthurnn/add_regression_for_path_and_cascadeRafael Mendonça França2014-10-131-0/+8
|\ \ \ \ | | | | | | | | | | Add regression test for router was overwriting PATH_INFO
| * | | | Add regression test for router was overwriting PATH_INFOArthur Neves2014-10-101-0/+8
| |/ / / | | | | | | | | | | | | [related #17233]
* / / / Replace Array#shuffle.first with Array#sampleErik Michaels-Ober2014-10-131-2/+2
|/ / /
* | | Request#check_method no longer breaks when :en is not available localeStefan Henzen2014-10-092-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | Request#check_method would use to_sentence(locale: :en), which breaks when I18n.available_locales does not include :en and I18n.enforce_available_locales is true (default). Inlined to_sentence functionality to solve this.
* | | Rephrasing sentencesNeeraj Singh2014-10-071-2/+2
| | |
* | | Merge pull request #17088 from robin850/jruby-devRafael Mendonça França2014-10-011-0/+1
|\ \ \ | | | | | | | | Follow up to #16613
| * | | Follow up to #16613Robin Dupret2014-09-281-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we want this flag to be enabled anytime we are running the tests under JRuby, let's enable this at the Rakefile level so people get the performance boost on their local checkout. Moreover, we avoid having to update this particular line anytime the option changes on the JRuby side. The only drawback is that we have to define it in every Rakefile but there's no big deal, this is already the case for other options.
* | | | Remove RUNNING UNIT TESTS from ActionPackclaudiob2014-09-301-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] Following discussion with @senny https://github.com/rails/rails/pull/17100#issuecomment-57285273 it only makes sense to keep this file form projects that require extra instructions.
* | | | Responder was removed at ee77770d57de9da87b05a2fe84b9d46ec6852c62Akira Matsuda2014-09-301-1/+0
| | | |
* | | | Parse HTML as document fragment.Kasper Timm Hansen2014-09-294-6/+6
| | | | | | | | | | | | | | | | This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20.
* | | | Use Hash#each_key instead of Hash#keys.eachErik Michaels-Ober2014-09-294-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | Hash#keys.each allocates an array of keys; Hash#each_key iterates through the keys without allocating a new array. This is the reason why Hash#each_key exists.
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-09-281-6/+6
|\ \ \ \ | |/ / / |/| | |
| * | | Consistently markup etag options.Steven Harman2014-09-161-3/+3
| | | |
| * | | Consistently capitalize ETag.Steven Harman2014-09-161-3/+3
| | | |
* | | | Preparing for 4.2.0.beta2 releaseRafael Mendonça França2014-09-261-1/+1
| | | |
* | | | Revert "Merge pull request #16966 from why-el/symbolize-path-params"Rafael Mendonça França2014-09-252-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9d05d6de52871e57bfbf54a60de005e8a5f5b0e4, reversing changes made to 0863c9248fd47a15e88e05ce4fcd80966684c0e3. The change in the behaviour reported at #16958 doesn't exist since 4.0 and 4.1 works in the same way
* | | | Ensure named path params are symbols (Fixes #16958)Mohamed Wael Khobalatte2014-09-252-0/+9
| | | |
* | | | No need CHANGLOG entry for a bug in a non released versionRafael Mendonça França2014-09-251-7/+0
| | | | | | | | | | | | | | | | [ci skip]
* | | | Keep the original implementation to not having to allocate new objectsRafael Mendonça França2014-09-251-2/+15
| | | |
* | | | Merge pull request #17058 from eval/issue-17057Rafael Mendonça França2014-09-252-18/+10
|\ \ \ \ | | | | | | | | | | | | | | | Remove internal options from query string of paths
| * | | | Remove internal options from query string of pathsGert Goet2014-09-252-18/+10
| | | | | | | | | | | | | | | | | | | | Fixes #17057
* | | | | Fix actionpack test cases broken by #16888Godfrey Chan2014-09-262-29/+9
| | | | |
* | | | | Use released rails-html-sanitizer and rails-deprecated_sanitizerGodfrey Chan2014-09-261-1/+1
| | | | |
* | | | | Use released rails-dom-testingRafael Mendonça França2014-09-251-1/+1
|/ / / /
* | | | Rescue Rack::Utils::ParameterTypeError instead of TypeErrorYuki Nishijima2014-09-132-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of rack/rack@167b6480235ff00ed5f355698bf00ec2f250f72e, Rack raises Rack::Utils::ParameterTypeError which inherits TypeError. In terms of the behavior, Rescuing TypeError still works but this method shouldn't rescue if TypeError is raised for other reasons.
* | | | Merge pull request #16839 from chancancode/default_test_orderRafael Mendonça França2014-09-101-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | Default to sorting user's test cases for now
| * | | | Default to sorting user's test cases for nowGodfrey Chan2014-09-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769
* | | | | [ci skip]Correct variables in the sample codesuginoy2014-09-101-2/+2
| | | | |
* | | | | Remove extra 'has been' from deprecation warning about asserting selectorsPrathamesh Sonpatki2014-09-091-1/+1
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Remove extra 'has been' from the deprecation messagePrathamesh Sonpatki2014-09-091-1/+1
|/ / / / | | | | | | | | | | | | - [ci skip]
* | | | Removing unused fake modelsThiago Pradi2014-09-071-45/+0
| | | |
* | | | Add support for Rack::ContentLength middelwareJavan Makhmali2014-09-062-0/+18
| | | |
* | | | Deprecate implicit AD::Response splatting and Array conversionJeremy Kemper2014-09-063-5/+43
| | | |
* | | | :scissors:Rafael Mendonça França2014-09-051-1/+1
| | | |
* | | | Add test to assert_recognizes with custom messageRafael Mendonça França2014-09-051-1/+9
| | | |
* | | | Message doesn't need to be optionalRafael Mendonça França2014-09-051-2/+2
| | | |
* | | | Merge pull request #14911 from estsauver/14908Rafael Mendonça França2014-09-052-7/+15
|\ \ \ \ | | | | | | | | | | | | | | | Propagate test messages through assert_routing helper, Fixes #14908
| * | | | Propagate test messages through assert_routing helper, Fixes #14908Earl St Sauver2014-04-292-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_routing was not raising the message passed into the assertion violation that it raised. This change propagates messages through the on_fail error. This fixes this error: https://github.com/rails/rails/issues/14908 A test case for this issue is located here. https://github.com/estsauver/test14908 To see that test case fail in the example app, just run ruby -Itest test/controllers/guests_controller_test.rb
* | | | | For now, we will keep sorting the tests.Matthew Draper2014-09-051-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commits e969c928463e329fd6529ac59cad96385c538ffb and bd2b3fbe54e750ba97469a7896e8d143d6dfd465.
* | | | | code gardening in ActionController::RenderersXavier Noria2014-09-041-7/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Renames _handle_render_options to _render_to_body_with_renderer, which is more intention-revealing. * The name of the dynamically generated method for a renderer with key :js was "_render_option_js". That name is too weak. :js is an option if you see the render argument as just a generic options hash, but in the context of renderers that's the renderer key, is what identifies the renderer. Now "_render_with_renderer_js" is generated instead, which is crystal clear. * The name of the dynamically generated method for the renderer was constructed using string literals in a few places. That is now encapsulated in a method. * Since we were on it, also removed a couple of redundant selfs.
* | | | | Ship with rails-html-sanitizer instead.Kasper Timm Hansen2014-09-031-1/+1
| |/ / / |/| | |
* | | | Leave all our tests as order_dependent! for nowMatthew Draper2014-09-021-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're seeing too many failures to believe otherwise. This reverts commits bc116a55ca3dd9f63a1f1ca7ade3623885adcc57, cbde413df3839e06dd14e3c220e9800af91e83ab, bf0a67931dd8e58f6f878b9510ae818ae1f29a3a, and 2440933fe2c27b27bcafcd9019717800db2641aa.
* | | | Allow polymorphic routes with nil when a route can still be drawnSammy Larbi2014-08-311-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Suppose you have two resources routed in the following manner: ```ruby resources :blogs do resources :posts end resources :posts ``` When using polymorphic resource routing like `url_for([@blog, @post])`, and `@blog` is `nil` Rails should still try to match the route to the top-level posts resource. Fixes #16754
* | | | Refer to the library name instead of the constantRobin Dupret2014-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we are loading a component and we want to know its version, we are actually not speaking about the constant but the library itself. [ci skip] [Godfrey Chan & Xavier Noria]
* | | | Merge pull request #16644 from Agis-/drb-tests-actionpack-vagrantXavier Noria2014-08-301-3/+1
|\ \ \ \ | | | | | | | | | | Use system /tmp for temp files when testing actionpack
| * | | | Use system /tmp when testing actionpackAgis-2014-08-221-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/c64bff2c87ebf363703c63ecd4a96d56a1a78364 added support and enabled parallel execution of the actionpack tests. However it introduced https://github.com/rails/rails/commit/c64bff2c87ebf363703c63ecd4a96d56a1a78364 since one cannot connect to a socket file that's inside a Vagrant synced folder due to security restrictions, and DRb tries to. Also rename the temporary files to make it obvious that they're rails-related, since now they're placed outside the project's directory. Fixes https://github.com/rails/rails/commit/c64bff2c87ebf363703c63ecd4a96d56a1a78364
* | | | | Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-2924-112/+288
|\ \ \ \ \
| * | | | | Don't rescue IPAddr::InvalidAddressErrorPeter Suschlik2014-08-292-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IPAddr::InvalidAddressError does not exist in Ruby 1.9.3 and fails for JRuby in 1.9 mode. As IPAddr::InvalidAddressError is a subclass of ArgumentError (via IPAddr::Error) just rescuing ArgumentError is fine.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-07 09:19:07 +0000