| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ /
| |
| |
| |
| |
| |
| | |
We will support only Ruby >= 2.1.
But right now we don't accept pull requests with syntax changes to drop
support to Ruby 1.9.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Update cookies.rb
Conflicts:
actionpack/lib/action_dispatch/middleware/cookies.rb
|
|\ \
| | |
| | |
| | | |
Allow authentication header to not have to specify 'token=' key.
|
| | |
| | |
| | |
| | | |
Fixes: https://github.com/rails/rails/issues/17108.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Adding simple docs for ActionDispatch::Flash::FlashHash#to_session_value
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Do not rescue Exception in ActionDispatch::ParamsParser
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Unlike ShowExceptions or PublicExceptions, ParamsParser shouldn't
transform exceptions like Interrupt and NoMemoryError into ParserError.
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Don't center the routes table on routing errors
|
| | | | | |
|
|\ \ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
url_for
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #17615 #17616
when script_name is nil in the options hash, script_name is set to nil.
options = {script_name: nil}
script_name = options.delete(:script_name) {‘’} # => nil
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
|
| | | | | |
|
|\ \ \ \ \ |
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes https://github.com/rails/rails/issues/16958
[Byron Bischoff & Melanie Gilman]
|
| |/ / /
|/| | | |
|
|\ \ \ \
| | | | |
| | | | | |
Show source view and backtrace on missing template errors
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This will help you debug missing template errors, especially if they
come from a programmatic template selection. Thanks to @dhh for
suggesting that.
As a bonus, also show request and response info on the routing error
page for consistency.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If the route set is empty, or if none of the routes matches with a score > 0,
there is no point showing the deprecation message because we are already be
raising the `ActionController::UrlGenerationError` mentioned in the warning.
In this case it is the expected behavior and the user wouldn't have to take any
actions.
|
| | | |
| | | |
| | | |
| | | | |
Reference #17453
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The internal tests that (incorrectly) relied on this were already fixed in
938d130. However, we cannot simply fix this bug because the guides prior to
b7b9e92 recommended a workaround that relies on this buggy behavior.
Reference #17453
|
|/ / /
| | |
| | |
| | |
| | | |
These are currently working "by accident" because `match_route` does not check
that the name is valid.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Reference #17453
[Godfrey Chan, Washington Luiz]
|
|\ \ \
| | | |
| | | | |
Anchor should not be appended when set to nil/false.
|
| | | |
| | | |
| | | |
| | | | |
Fixes https://github.com/rails/rails/issues/17714.
|
| | | |
| | | |
| | | |
| | | | |
cc ddce3dd
|
|/ / /
| | |
| | | |
They were introduced in 23b6def; the serial stuff has been removed since a5d80f8
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I grepped the source code for code snippets wrapped in backticks in the comments
and replaced the backticks with plus signs so they are correctly displayed in
the Rails documentation.
[ci skip]
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | | |
of ActionDispatch::Request#method to pick up overrides by the middleware
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit f93df52845766216f0fe36a4586f8abad505cac4, reversing
changes made to a455e3f4e9dbfb9630d47878e1239bc424fb7d13.
Conflicts:
actionpack/lib/action_controller/test_case.rb
actionview/lib/action_view/test_case.rb
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix for assigns(:..) resetting template assertions
|
| | | |
| | | |
| | | |
| | | | |
When calling assigns(:...) or cookies(:...), template assertions would be reset, which they obviously shouldn't be.
|
|\ \ \ \
| | | | |
| | | | | |
Rename #source_extract to #source_extracts in ExceptionWrapper
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It returns multiple source extracts since 1ed264bc. Also cleaned its
result structure, as we no longer need the file in a code extract.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Don't double check trace origin in ExceptionWrapper#traces
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If a trace isn't an application one, then it comes from a framework.
That's the definition of framework trace. We can speed up the traces
generation if we don't double check that.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since dbcbbcf2bc58e8971672b143d1c52c0244e33f26 the full trace is shown
by default on routing errors. While this is a nice feature to have, it
does take the attention off the routes table in this view and I think
this is what most of the people look for in this page.
Added an exception to the default trace switching rule to remove that
noise.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Those three can be nil when exception backtrace is nil. This happens and
that forced a couple of nil guards in the code. I'm proposing to make
those always return an array, even on nil backtrace.
|
|\ \ \ \
| |/ / /
|/| | | |
Add basic tests for ActionDispatch::ExceptionWrapper
|