Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use frozen string literal in actionpack/ | Kir Shatrov | 2017-07-29 | 280 | -3/+560 |
| | |||||
* | Fix search input's type & placeholder conflict in Routing Error page | Kaan Kölköy | 2017-07-26 | 1 | -0/+4 |
| | |||||
* | Merge pull request #29919 from kirs/actionpack-frozen-friendly | Rafael França | 2017-07-24 | 9 | -10/+26 |
|\ | | | | | Make actionpack frozen string friendly | ||||
| * | Make actionpack frozen string friendly | Kir Shatrov | 2017-07-24 | 9 | -10/+26 |
| | | |||||
* | | Merge pull request #29866 from rlue/master | Rafael França | 2017-07-24 | 1 | -4/+4 |
|\ \ | | | | | | | [API DOCUMENTATION] [MINOR] Correct description of ActionController::Parameters#delete | ||||
| * | | Fix typo in API docs | Ryan Lue | 2017-07-20 | 1 | -1/+1 |
| | | | |||||
| * | | Correct API documentation for ActionController::Parameters#delete | Ryan Lue | 2017-07-20 | 1 | -4/+4 |
| |/ | |||||
* | | Merge pull request #29898 from ↵ | Rafael França | 2017-07-24 | 2 | -1/+27 |
|\ \ | | | | | | | | | | | | | deivid-rodriguez/follow_up_to_multiple_location_engine_mounting Fix regression introduced by fixing mounting the same engine in multiple locations | ||||
| * | | Fix regression from multiple mountpoint support | David Rodríguez | 2017-07-24 | 2 | -1/+27 |
| |/ | |||||
* / | Update rack-test dependency constraint | Dwight Watson | 2017-07-24 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #29775 from yui-knk/assign_once | Sean Griffin | 2017-07-18 | 1 | -2/+2 |
|\ | | | | | Assign `content_type` only once | ||||
| * | Assign `content_type` only once | yui-knk | 2017-07-13 | 1 | -2/+2 |
| | | |||||
* | | Scrub the invalid paramter value before using it in the error | Arthur Neves | 2017-07-17 | 2 | -2/+3 |
| | | | | | | | | | | | | | | You should be able to safely use the String error message. So when finding the paramter has an invalid encoding we need to remove the invalid bytes before using it in the error. Otherwise the caller might get another Encoding error if they use the message. | ||||
* | | `Response#charset=` uses `default_charset` when `nil` is passed | yui-knk | 2017-07-13 | 1 | -1/+1 |
|/ | |||||
* | normalize_path used to be nil tolerant | Akira Matsuda | 2017-07-12 | 2 | -0/+5 |
| | | | | fixes a regression introduced at 8607c25ba7810573733d9b37d0015154ba059f5e | ||||
* | [Action Pack] `rubocop -a --only Layout/EmptyLineAfterMagicComment` | Koichi ITO | 2017-07-11 | 16 | -0/+16 |
| | |||||
* | Add backticks for class names in CHANGELOG [ci skip] | Ryuta Kamizono | 2017-07-11 | 1 | -3/+3 |
| | |||||
* | Add ActionController::Base.skip_forgery_protection | Lisa Ugray | 2017-07-10 | 2 | -0/+39 |
| | | | | | | Since we now default to `protect_from_forgery with: :exception`, provide a wrapper to `skip_before_action :verify_authenticity_token` for disabling forgery protection. | ||||
* | Protect from forgery by default | Lisa Ugray | 2017-07-10 | 3 | -0/+22 |
| | | | | | | | | Rather than protecting from forgery in the generated ApplicationController, add it to ActionController::Base by config. This configuration defaults to false to support older versions which have removed it from their ApplicationController, but is set to true for Rails 5.2. | ||||
* | Merge pull request #29655 from kirs/frozen-friendly-ap-ar | Matthew Draper | 2017-07-10 | 15 | -17/+32 |
|\ | | | | | Prepare AP and AR to be frozen string friendly | ||||
| * | Prepare AP and AR to be frozen string friendly | Kir Shatrov | 2017-07-06 | 15 | -17/+32 |
| | | |||||
* | | Don't call register on custom drivers | eileencodes | 2017-07-08 | 2 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | It's possible for developers toadd a custom driver and then call it using `driven_by`. Because we were only skipping `register` for `:rack_test` that meant any custom driver would attempt to be registered as well. The three listed here are special because Rails registers them with special options. If you're registering your own custom driver then you don't want to separately register that driver. Fixes #29688 | ||||
* | | Allow mounting same engine under several locations | David Rodríguez | 2017-07-05 | 3 | -10/+20 |
| | | |||||
* | | Fix end | Rafael Mendonça França | 2017-07-04 | 1 | -0/+1 |
| | | |||||
* | | Load the Parameters configurations on the right time | Rafael Mendonça França | 2017-07-04 | 1 | -7/+8 |
|/ | | | | | | | We need to configure it only when ActionController::Base is loaded otherwise configs on initializers will not work. Closes #29527. | ||||
* | Merge branch 'master' into require_relative_2017 | Xavier Noria | 2017-07-02 | 11 | -31/+91 |
|\ | |||||
| * | Merge pull request #29566 from eugeneius/wrap_parameters_query | Kasper Timm Hansen | 2017-07-02 | 2 | -7/+10 |
| |\ | | | | | | | Don't wrap parameters if query parameter exists | ||||
| | * | Don't wrap parameters if query parameter exists | Eugene Kenny | 2017-06-25 | 2 | -7/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to avoid overwriting a query parameter with the wrapped parameters hash. Previously this was implemented by merging the wrapped parameters at the root level if the key already existed, which was effectively a no-op. The query parameter was still overwritten in the filtered parameters hash, however. We can fix that discrepancy with a simpler implementation and less unnecessary work by skipping parameter wrapping entirely if the key was sent as a query parameter. | ||||
| * | | Merge pull request #29622 from yalab/warning_system_tesing_http_verb | Eileen M. Uchitelle | 2017-07-01 | 3 | -0/+58 |
| |\ \ | | | | | | | | | Warning http verb method call in SystemTestCase | ||||
| | * | | SystemTestCase undef some IntegrationTest methods because it's confused to use. | yalab | 2017-07-01 | 3 | -0/+58 |
| | | | | |||||
| * | | | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 310 | -310/+0 |
| | | | | | | | | | | | | | | | | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
| * | | | Merge pull request #29540 from kirs/rubocop-frozen-string | Matthew Draper | 2017-07-02 | 310 | -0/+310 |
| |\ \ \ | | | | | | | | | | | | | | | | Enforce frozen string in Rubocop | ||||
| | * | | | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 310 | -0/+310 |
| | |/ / | |||||
| * | | | Merge pull request #29506 from pat/frozen-string-literals | Matthew Draper | 2017-07-02 | 4 | -6/+6 |
| |\ \ \ | | | | | | | | | | | | | | | | Make ActiveSupport frozen-string-literal friendly. | ||||
| | * | | | Make ActionView frozen string literal friendly. | Pat Allan | 2017-06-20 | 3 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | Plus a couple of related ActionPack patches. | ||||
| | * | | | Make ActionMailer frozen string literal friendly. | Pat Allan | 2017-06-20 | 2 | -2/+2 |
| | | | | | |||||
| | * | | | Make ActiveModel frozen string literal friendly. | Pat Allan | 2017-06-20 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | Includes two external changes because they're referenced within the ActiveModel test suite. | ||||
| * | | | | Merge pull request #29644 from wilson/unify-route-helper-visibility | Matthew Draper | 2017-07-01 | 2 | -18/+17 |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | Properly register "custom" URL helpers as named helpers. | ||||
| | * | | | | Properly register "custom" URL helpers as named helpers. | Wilson Bilkovich | 2017-06-30 | 2 | -18/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CustomUrlHelpers were introduced in ce7d5fb2e6, closing issue #22512. They currently register themselves in an ivar that is never accessed. This change removes the @custom_helpers special-case, and registers them the way named routes are normally handled. Without this, you can get route_defined?(:example_url) == false, while still being able to call url_helpers.example_url and example_path. Various popular gems such as 'rspec-rails' make use of route_defined?() when determining how to proxy method calls or whether to define a route. | ||||
* | | | | | | [Action Pack] require => require_relative | Akira Matsuda | 2017-07-01 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | [Action Controller] require => require_relative | Akira Matsuda | 2017-07-01 | 7 | -9/+9 |
| | | | | | | |||||
* | | | | | | [Abstract Controller] require => require_relative | Akira Matsuda | 2017-07-01 | 2 | -2/+2 |
| | | | | | | |||||
* | | | | | | [Action Dispatch] require => require_relative | Akira Matsuda | 2017-07-01 | 27 | -57/+57 |
|/ / / / / | |||||
* / / / / | Fix format of `ActionController::Parameters#to_s` doc [ci skip] | yuuji.yaginuma | 2017-07-01 | 1 | -0/+1 |
|/ / / / | |||||
* | | | | Add CHANGELOG for #29630 [ci skip] | Prathamesh Sonpatki | 2017-07-01 | 1 | -0/+4 |
| | | | | |||||
* | | | | Fallback Parameters#to_s to Hash#to_s | Kir Shatrov | 2017-06-30 | 2 | -1/+13 |
| |/ / |/| | | | | | Fixes https://github.com/rails/rails/issues/29617 | ||||
* | | | Merge pull request #29588 from greysteil/add-gemspec-links | Rafael França | 2017-06-28 | 1 | -0/+5 |
|\ \ \ | | | | | | | | | Add source code and changelog links to gemspecs | ||||
| * | | | Add source code and changelog links to gemspecs | Grey Baker | 2017-06-28 | 1 | -0/+5 |
| | |/ | |/| | |||||
* | | | Merge pull request #29595 from fatkodima/result_lambda_class_checking | Rafael França | 2017-06-28 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda | ||||
| * | | | Remove useless class checking for `ActiveSupport::Callbacks`s result_lambda | fatkodima | 2017-06-27 | 1 | -1/+1 |
| |/ / |