aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
...
* | fix variable names, only pass hashes to the positional args methodAaron Patterson2014-05-201-8/+10
| |
* | Merge pull request #11346 from tomykaira/fix_10257Rafael Mendonça França2014-05-202-2/+21
|\ \ | | | | | | Check authentication scheme in Basic auth
| * | Run login_procedure only when the auth_scheme is validtomykaira2013-07-081-7/+14
| | |
| * | Check authentication scheme in Basic authtomykaira2013-07-072-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `authenticate_with_http_basic` and its families should check the authentication schema is "Basic". Different schema, such as OAuth2 Bearer should be rejected by basic auth, but it was passing as the test shows. This fixes #10257.
* | | remove dead codeAaron Patterson2014-05-201-57/+0
| | |
* | | cache the formatter on the path objectAaron Patterson2014-05-202-2/+6
| | |
* | | translate AST to a formatter before url generationAaron Patterson2014-05-202-1/+72
| | |
* | | prepopulate the dispatch cache so we don't need the ThreadSafe cache.Aaron Patterson2014-05-201-7/+9
| | |
* | | make the each visitor top-down left-rightAaron Patterson2014-05-201-1/+1
| | |
* | | Merge pull request #15182 from zuhao/refactor_actionpack_respond_with_test_2Yves Senn2014-05-201-4/+10
|\ \ \ | | | | | | | | Un-define :to_json for Customer class after stubbing.
| * | | Add using_resouce_with_json to controller.Zuhao Wan2014-05-201-4/+10
| | |/ | |/|
* | | Merge pull request #15178 from zuhao/refactor_actionpack_respond_with_testYves Senn2014-05-202-0/+35
|\ \ \ | | | | | | | | Deregister csv renderer after test to prevent leak.
| * | | Add ActionController::Renderers.remove.Zuhao Wan2014-05-202-0/+35
| |/ /
* | | make the AST go from left to right, rather than right to leftAaron Patterson2014-05-192-45/+48
| | |
* | | fix escaping in generationAaron Patterson2014-05-191-1/+7
| | |
* | | Revert "Rewrite journey routes formatter for performance"Aaron Patterson2014-05-192-28/+43
|/ / | | | | | | | | | | | | | | | | | | This reverts commit 5c224de9e110763ec7a0f01f5b604bcf81f40bfb. Conflicts: actionpack/lib/action_dispatch/journey/visitors.rb 5c224de9e110763ec7a0f01f5b604bcf81f40bfb introduced a bug in the formatter. This commit includes a regression test.
* | Merge pull request #15132 from zuhao/refactor_actionpack_abstract_collector_testYves Senn2014-05-171-5/+11
|\ \ | | | | | | Ensure :js is defined regardless of the outcome of the test.
| * | Ensure :js is defined regardless of the outcome of the test.Zuhao Wan2014-05-171-5/+11
| | |
* | | fixed a typo [ci skip]Aida2014-05-171-1/+1
|/ /
* | Merge pull request #15118 from ↵Rafael Mendonça França2014-05-156-2/+47
|\ \ | | | | | | | | | | | | | | | khelben/head_with_status_action_stack_level_too_deep fixes stack level too deep exception on action named 'status' rendering 'head :ok'
| * | fixes stack level too deep exception on action named 'status' returning ↵Christiaan Van den Poel2014-05-156-2/+47
|/ / | | | | | | 'head :ok'
* | Merge pull request #15121 from skarpesh/rfc4791-methodsRafael Mendonça França2014-05-153-3/+10
|\ \ | | | | | | | | | Add RFC 4791 MKCALENDAR method
| * | Add RFC4791 MKCALENDAR methodkasper2014-05-153-3/+10
|/ /
* | Remove unused method in RouteSet test.Guo Xiang Tan2014-05-151-4/+0
| |
* | Only path requirements are relevant to optimized urlsAndrew White2014-05-151-1/+1
| | | | | | | | | | The bit of URL generation that is optimized is the generation of the path so things like :host, :port, etc. are irrelevant.
* | Add missing requires for require 'action_dispatch/routing'Andrew White2014-05-152-0/+3
| |
* | Merge pull request #14137 from dasch/better-fragment-cache-instrumentationRafael Mendonça França2014-05-143-1/+31
|\ \ | | | | | | | | | | | | | | | | | | Add controller and action name to the fragment caching instrumentation payload Conflicts: actionpack/CHANGELOG.md
| * | Add controller and action name to the instrumentation payloadDaniel Schierbeck2014-05-103-1/+31
| | |
* | | Merge pull request #15070 from ayamomiji/sse-patchAaron Patterson2014-05-142-1/+18
|\ \ \ | | | | | | | | Add multiple lines message support for SSE module
| * | | Add multiple lines message support for SSE moduleayaya2014-05-122-1/+18
| | | |
* | | | _recall should be set to a hash or not setAaron Patterson2014-05-132-4/+4
| | | | | | | | | | | | | | | | Then we can avoid nil checks
* | | | we never call url_for with a block, so rmAaron Patterson2014-05-131-1/+0
| | | |
* | | | drop || test for cases that do not need itAaron Patterson2014-05-132-4/+6
| | | |
* | | | no need to check for presence, script names can be blankAaron Patterson2014-05-131-2/+2
| | | |
* | | | extend with a module then use define_methodAaron Patterson2014-05-131-7/+4
| | | | | | | | | | | | | | | | no need for redefine_method
* | | | this method should always have a parameter passed to it, so remove the defaultAaron Patterson2014-05-131-1/+1
| | | |
* | | | options should always be passed to url_forAaron Patterson2014-05-131-2/+2
| | | |
* | | | calls with :host should still use the optimized pathAaron Patterson2014-05-131-2/+2
| | | |
* | | | use fewer method calls to determine the url_for optionsAaron Patterson2014-05-131-5/+4
| | | |
* | | | just merge instead of dup and mergeAaron Patterson2014-05-131-2/+1
| | | |
* | | | the :only_path option is applied by the time the helper is calledAaron Patterson2014-05-131-4/+1
| | | |
* | | | options already have symbolized keys, so we can avoid this callAaron Patterson2014-05-131-1/+1
| | | |
* | | | Get rid of unused methodCarlos Antonio da Silva2014-05-131-11/+0
| | | | | | | | | | | | | | | | It's usage has been removed in 325c9d5e5235db4b5210d9db6c863835d1ac7eed.
* | | | Simplify merge call on polymorphic helpersCarlos Antonio da Silva2014-05-131-2/+2
| | | |
* | | | Fix regression on `assert_redirected_to`.Arthur Neves2014-05-132-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_redirected_to` would fail if there is no controller set on a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location would be called on the controller to build the url. This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0. [fixes #14691]
* | | | avoid array allocation when extracting usernames and passwordsAaron Patterson2014-05-121-1/+7
| | | |
* | | | Revert "reduce conditionals in url_for"Aaron Patterson2014-05-121-6/+3
| | | | | | | | | | | | | | | | This reverts commit 9df60693d77813b362fb528fc62381ac8f1eec12.
* | | | this class is a model, so it should act like oneAaron Patterson2014-05-121-0/+3
| | | |
* | | | use the helper method builder to construct helper methodsAaron Patterson2014-05-122-57/+112
| | | |
* | | | undo optimized calls until the builder object is finishedAaron Patterson2014-05-122-37/+20
| | | |