| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Method invalid_asset_host! was delegated to controller but sprockets
compile assets in their own scope without controller. And if we set asset_host
with second parameter it should raise error through invalid_asset_host!.
But since controller is nil it cannot be reached.
|
|
|
|
|
|
|
| |
This reverts commit 7256cb53e0c34e510a4d59a50d120c0358cf1d99, reversing
changes made to 6ebe22c3ae716d089af1e5090ddb0d12b31af8ac.
Reason: A test was failing.
|
|
|
|
|
|
| |
This reverts commit e4b33b08d6d2b88b627b1e52c4f349e57c5b89fc.
https://github.com/rails/rails/pull/7452#issuecomment-8094302
|
|\
| |
| | |
the example for contraint( :ip => XXXX) has an invalid regex
|
| |
| |
| | |
escape the '.'s
|
| |
| |
| | |
Since it uses request and response methods
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Fix markdown rendering of the ActionPack changelog [ci skip]
|
| |/ |
|
|/ |
|
|
|
|
| |
computation *Jeremy Kemper/DHH*
|
|
|
|
| |
spiked in the cache_digests plugin) *DHH*
|
| |
|
| |
|
|\
| |
| | |
Add Missing Keys from Journey on Failed URL Format
|
| |
| |
| |
| |
| |
| | |
The result of Generator with or without the @extras instance variable set contains the desired information. Rather than preserving state when initializing the original object, we can simply extract the keys from the resultant parameters.
ATP Actionpack, railties
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Many named routes have keys that are required to successfully resolve. If a key is left off like this:
<%= link_to 'user', user_path %>
This will produce an error like this:
No route matches {:action=>"show", :controller=>"users"}
Since we know that the :id is missing, we can add extra debugging information to the error message.
No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id]
This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url.
While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious.
This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message.
Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
Changes in old branches needed to be manually synched in CHANGELOGs of newer ones.
This has proven to be brittle, sometimes one just forgets this manual step.
With this commit we switch to CHANGELOGs per branch. When a new major version is
cut from master, the CHANGELOGs in master start being blank.
A link to the CHANGELOG of the previous branch allows anyone interested to
follow the history.
|
| |
|
| |
|
|\
| |
| | |
Memcached to dalli for actionpack test.
|
| | |
|
| |
| |
| | |
There is no memcache gem left in repo.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Methods provided by RecordIdentifier are not widely used in controllers
nowadays as they're view specific (this is probably a legacy left after
RJS rendering directly in controllers). However if people still need to
use it, it's trivial to include ActionView::RecordIdentifier by
themselves.
|
| |
| |
| |
| |
| | |
We extend it with self, but the methods were not working properly were
used directly on module.
|
| |
| |
| |
| |
| | |
When module is extended ActiveSupport::Concern, include calls are lazily
loaded, so there is no need to wrap it with included hook.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
AV::Template::Types is a small abstraction to allow to specify template types
that can be used in ActionView. When Action Pack is loaded it's replaced with
Mime::Type.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This
was changed by splitting previous implementation of UrlHelper into 2
modules: ActionView::Helpers::UrlHelper and
ActionView::Routing::UrlHelper. The former one keeps only basic
implementation of url_for. The latter adds features that allow to use
routes and is only required when url_helpers or mounted_helpers are
required.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
default_formats array is used by LookupContext in order to allow
rendering templates when :formats option is not passed. Previously it
was always set to Mime::SET, which created dependency on Action Pack. In
order to remove this dependency, Mime::SET is used only if
ActionController is loaded.
|
| |
| |
| |
| |
| | |
Action View should not be responsible for translating mime types. Any
translation that's needed should be handled at controller level.
|
| |
| |
| |
| |
| |
| | |
Automatically handling mime types for things other than :rss and :atom
is not functionality that justifies dependency on Mime::Type from
actionpack.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I've talked to José Valim, who added this comment, and there is no need
to remove old API. It's good to have a simple way to instantiate
ActionView::Base, by just passing view paths as a first argument,
instead of constructing LookupContext and then the Renderer.
[ci skip]
|
| |
| |
| |
| |
| |
| |
| | |
We can use another way to instantiate ActionView::Base, by passing
renderer as a first option. Thanks to that we can just pass prefixes to
LookupContext instead stubbing them on the controller. This is also good,
because that kind of API is used in Rails code.
|
| |
| |
| |
| |
| |
| | |
This is another step in moving Action View's dependencies in Action Pack
to Action View itself. Also, HtmlScanner seems to be better suited for
views rather than controllers.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
It's just a duplicate of ActionController::ModelNaming. These are just a
simple helpers for decoupling Active Model, so it does not make sense to
extract it to Active Support, but the point is to decouple also Action
View and Action Pack
|
| |
| |
| |
| |
| |
| |
| | |
Since it's more about DOM classes and ids it belongs to Action View
better. What's more, it's more convenient to make it part of Action View
to follow the rule that Action Pack can depend on Action View, but not
the other way round.
|
|/
|
|
|
|
| |
Since Action View should not depend on actionpack, it's best to delegate
invalid_asset_host! to controller and just rely on such simple contract
instead of raising ActionController::RoutingError directly.
|
|
|
|
|
| |
Instead of building a Blog::Post instance for every test in form helper
tests, just build it in the test that uses it.
|
|
|
|
|
|
|
|
|
|
|
|
| |
we should take disabled option not only from `html_options` hash but from
`options` hash too like `build_select` method does it. So
datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true })
datetime_select("post", "updated_at", :discard_minute => true , :disabled => true)
both these variants work now
closes #7431
|