| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It's faster, and doesn't force us to dup the timezones array.
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This seemed to be introduced in master by
9dd64f2e0c1b3ce85b503b0f81c50c93f89ffbcd, so there's no need to add a
changelog entry for fixing it.
[ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
remove assigned but unused variables
|
| | | | | | |
|
|/ / / / / |
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing
changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7.
This was causing issues in one of our apps we just upgraded.
ActionController::RoutingError: No route matches [GET]
"/images/favicon.ico"
favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned
'/favicon.ico'
Browsers by default look for favicon.ico in the root directory
Conflicts:
actionpack/CHANGELOG.md
actionpack/lib/action_view/helpers/asset_tag_helper.rb
|
|/ / /
| | |
| | |
| | |
| | | |
If you want an ability to parse XML parameters, please install
`actionpack-xml_parser` gem.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previous implementation of time_zone_options_for_select did not dup the
ActiveSupport::TimeZone.all array. When :priority_zones were provided
the method would reject! the zones from the memoized TimeZones array
thus affecting future requests to the server. Essentially whatever
zones were specified as :priority_zones would show up for the first
request but then disappear from the time zone options on future
requests.
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes #9302
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Allows us to use url_for and friends in isolation.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Somehow I missed this method, which was then throwing an error
when viewing routes as HTML.
Make @rubys happy: ✔
|
| | | |
|
| | |
| | |
| | |
| | | |
Thanks @sikachu. :heart:
|
| | |
| | |
| | |
| | |
| | |
| | | |
Print a message in both `rake routes` and at GET "/rails/info/routes"
that lets you know you have no routes defined, as well as linking to the
Rails Guide on the topic.
|
| | | |
|
| | |
| | |
| | |
| | | |
see: https://github.com/blog/1406-namespaced-gists
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Removed an old require of an MD5 digest which is no longer used.
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
Conflicts:
guides/source/upgrading_ruby_on_rails.md
|
| | |
| | |
| | |
| | |
| | |
| | | |
The `:prefix` bullet content was not properly wrapping,
dropping to the following line because the additional
content was not indented properly. With this change, it
will now display properly the way `:discard_type` does.
|
| | |
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | | |
The examples do not generate the output they intend to due to not explicitly declaring the hash separations. This causes it to be treated as one parameter instead of the intended two parameters.
|
|\ \ \
| | | |
| | | | |
replace regexp global in #url_for
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Improve img alt attribute for screen readers
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, the img_alt method in ActionView keeps underscores
in the alt attribute. Because underscores are pronounced in
Apple's VoiceOver Utility, this has serious implications for
accessibility. This patch makes underscored or hyphenated file
names (both common in projects) read more naturally in screen
readers by replacing them with spaces. See method documentation
for details.
Added documentation to image_alt method
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
released yet
|
|\ \ \ \
| | | | |
| | | | | |
Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator
|
| |/ / / |
|
|/ / / |
|
| | |
| | |
| | | |
[ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The current implementation only works correctly if you supply the `:controller`
with directory notation (eg. `:controller => 'admin/posts'`).
The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`.
This patch prints a warning for every non supported `:controller` option. I also added documentation how
to work with namespaced controllers. The warning links to that documentation in the rails guide.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
previously when a partial was placed inside a directory
(eg. '/dir/_partial'), `assert_template` did not replace
the '_' prefix when looking through rendered tempaltes,
which resulted in an error.
I modified it to replace both, the leading '_' and the last '_'
after a '/'.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When `assert_template` is used with the :locals option, and the
partial was not rendered, a method_missing error was raised.
This changes first checks, if the partial actually was rendered
and raises a descriptive error.
|
| |/
|/|
| |
| | |
So that they are printed nicely on GitHub.
|
| |
| |
| |
| | |
Starting a line with an octothorpe makes an <h1>
|
| | |
|
| | |
|