aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Don't use `html_escape` to test the escapingRafael Mendonça França2012-08-054-4/+4
|
* Add CHANGELOG entry for 3c731a4ad62430100ba0b65bc966aa6dc6280c5fRafael Mendonça França2012-08-051-0/+4
|
* removes usage of Object#in? from the code base (the method remains defined ↵Xavier Noria2012-08-069-15/+16
| | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case.
* Revert "polymorphic_url with an array generates a query string"Andrew White2012-08-042-18/+1
| | | | | Passing options as the last value in an array doesn't work with form_for. This reverts commit 61c8a4d926343903593a27080216af7e4ed81268.
* Revert "Refactor passing url options via array for polymorphic_url"Andrew White2012-08-043-11/+2
| | | | | Passing options as the last value in an array doesn't work with form_for. This reverts commit 6be564c7a087773cb0b51c54396cc190e4f5c983.
* RouteSet: cleanup some unneeded compexityBogdan Gusiev2012-08-041-16/+7
|
* Renamed _path_segments to _recallBogdan Gusiev2012-08-044-5/+5
|
* Simplify logical statementBogdan Gusiev2012-08-041-4/+2
|
* Merge branch 'polymorphic_url_builds_query_string_with_array'Andrew White2012-08-043-1/+27
|\
| * Refactor passing url options via array for polymorphic_urlAndrew White2012-08-043-2/+11
| | | | | | | | | | | | | | | | Rather than keep the url options in record_or_hash_or_array, extract it and reverse merge with options as it may contain important private keys like `:routing_type`. Closes #7259
| * polymorphic_url with an array generates a query stringRomain Tribes2012-08-042-1/+18
| | | | | | | | | | Generating an URL with an array of records is now able to build a query string if the last item of the array is a hash.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-042-1/+9
|\ \ | |/ |/| | | | | | | Conflicts: activemodel/lib/active_model/secure_password.rb activerecord/lib/active_record/associations/collection_proxy.rb
| * copy edits [ci skip]Vijay Dev2012-08-041-2/+2
| |
| * fix punctuation in #resources and #match documentation [ci skip]Francesco Rodriguez2012-07-311-4/+4
| |
| * Update #match documentation [ci skip]Robert Pankowecki2012-07-311-0/+4
| |
| * Update #resources documentation [ci skip]Robert Pankowecki2012-07-311-0/+4
| |
| * use 'HTTP_AUTHORIZATION' instead of :authorization as key when dealing with ↵Francesco Rodriguez2012-07-271-1/+1
| | | | | | | | HTTP Token authentication in integration tests
* | Add test select_tag escapes promptSantiago Pastorino2012-08-031-0/+6
| |
* | Use content_tag here instead of manually building HTMLSantiago Pastorino2012-08-031-2/+6
| |
* | make sure the body finishes rendering before checking response closureAaron Patterson2012-08-031-1/+2
| |
* | Collapsed dual checks (one for content headers and one for content) into a ↵Armand du Plessis2012-08-023-8/+38
| | | | | | | | | | | | | | | | | | | | | | | | single check. Rails includes a single character body to a head(:no_content) response to work around an old Safari bug where headers were ignored if no body sent. This patch brings the behavior slightly closer to spec if :no_content/204 is explicity requested via a head only response. Status comparison done on symbolic and numeric values Not returning any content when responding with head and limited to a status code that explicitly states no content will be returned - 100..199, 204, 205, 304.
* | Merge pull request #7240 from steveklabnik/fix_2301Rafael Mendonça França2012-08-023-4/+7
|\ \ | | | | | | Fix for digest authentication bug - issue #2301 in rails/rails
| * | Changelog entry for Digest Auth fix (#2301)Steve Klabnik2012-08-021-0/+2
| | |
| * | Fix for digest authentication bug - issue #2301 in rails/railsArthur Smith2012-08-022-4/+5
| | |
* | | load active_support/deprecation in active_support/railsXavier Noria2012-08-021-1/+0
| | |
* | | load active_support/core_ext/module/delegation in active_support/railsXavier Noria2012-08-026-6/+0
| | |
* | | load active_support/core_ext/class/attribute in active_support/railsXavier Noria2012-08-0214-14/+0
| | |
* | | load active_support/concern in active_support/railsXavier Noria2012-08-024-4/+0
| | |
* | | load active_support/dependencies/autoload in active_support/railsXavier Noria2012-08-022-2/+0
| | |
* | | load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-0211-11/+0
| | |
* | | load active_support/core_ext/object/blank in active_support/railsXavier Noria2012-08-0227-27/+0
| | |
* | | defines a private require-hub active_support/railsXavier Noria2012-08-024-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | This is a private place to put those AS features that are used by every component. Nowadays we cherry-pick individual files wherever they are used, but that it is not worth the effort for stuff that is going to be loaded for sure sooner or later, like blank?, autoload, concern, etc.
* | | Check validity of options[:as] just onceJosé Valim2012-08-021-12/+18
| | |
* | | Improve error handling when using partial name with hyphen. Fix #7079kennyj2012-08-032-7/+19
|/ /
* | Merge pull request #7204 from frodsan/update_conventionsRafael Mendonça França2012-07-311-8/+8
|\ \ | | | | | | Follow code conventions in metal/live
| * | update coding conventions in metal/liveFrancesco Rodriguez2012-07-301-8/+8
| | |
* | | html_escape should escape single quotesSantiago Pastorino2012-07-318-25/+25
| | | | | | | | | | | | | | | https://www.owasp.org/index.php/XSS_%28Cross_Site_Scripting%29_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content Closes #7215
* | | fix nodoc in metal/liveFrancesco Rodriguez2012-07-301-4/+4
|/ /
* | fix typo in metal/live [ci skip]Francesco Rodriguez2012-07-301-6/+6
| |
* | Merge pull request #7198 from cfcosta/refactor-cache_control_headersRafael Mendonça França2012-07-291-11/+19
|\ \ | | | | | | Refactor ActionDispatch::Http::Cache::Response#cache_control_headers
| * | Refactor ActionDispatch::Http::Cache::Response#cache_control_headers.Cainã Costa2012-07-301-11/+19
| | |
* | | updated changelogAaron Patterson2012-07-291-0/+16
| | |
* | | close the response when the response body is set so that normal render calls ↵Aaron Patterson2012-07-292-0/+14
| | | | | | | | | | | | will work
* | | header hash is duped before being sent up the rack stackAaron Patterson2012-07-293-12/+33
| | |
* | | freeze the header objectAaron Patterson2012-07-292-0/+7
| | |
* | | make sure set_response! sets the correct response objectAaron Patterson2012-07-292-0/+15
| | |
* | | adding a more docs on closing response streamsAaron Patterson2012-07-291-1/+4
| | |
* | | pushing Buffer up to LiveAaron Patterson2012-07-291-22/+22
| | |
* | | adding some docsAaron Patterson2012-07-291-1/+26
| | |
* | | Controller actions are processed in a separate thread for liveAaron Patterson2012-07-293-7/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | responses. Processing controller actions in a separate thread allows us to work around the rack api - we can allow the user to set status and headers, then block until the first bytes are written. As soon as the first bytes are written, the main thread can return the status, headers, and (essentially) a queue for the body.